Default to require_ems in FIPS mode
#1772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark resultsInstruction countsSignificant differencesThere are no significant instruction count differences Other differencesClick to expand
Wall-timeSignificant differencesThere are no significant wall-time differences Other differencesClick to expand
Additional informationCheckout details:
|
djc
reviewed
Feb 5, 2024
| @@ -280,7 +281,15 @@ impl ClientConfig { | |||
| /// Return true if connections made with this `ClientConfig` will | |||
| /// operate in FIPS mode. | |||
| pub fn fips(&self) -> bool { | |||
| self.provider.fips() | |||
| #[cfg(feature = "tls12")] | |||
There was a problem hiding this comment.
If we're going to make the config-side fips() depend on the config, should we make the CryptoProvider::fips() pub(crate) to make it harder to accidentally rely on the CryptoProvider::fips() where that is not sufficient?
There was a problem hiding this comment.
I think -- I hope -- that there is not much confusion in semantics between CryptoProvider::fips() and Client/ServerConfig::fips(), even if they were functionally the same up until this commit. Will extend the docs though.
There was a problem hiding this comment.
Maybe the distinction needs to be explained in CryptoProvider::fips()? That's where it's risky, if you use that fips() but fail to check the config.
There was a problem hiding this comment.
I have added some clarifying text to CryptoProvider::fips() -- please check.
ctz
force-pushed
the
jbp-link-fips-to-require-ems
branch
2 times, most recently
from
c7800cc
to
d1bd423
Compare
cpu
approved these changes
Feb 5, 2024
djc
approved these changes
Feb 5, 2024
Change default for `require_ems` based on `fips` crate feature, generalising the existing tests for `require_ems` to verify this too. Include `require_ems` in `fips()` determination.
ctz
force-pushed
the
jbp-link-fips-to-require-ems
branch
from
d1bd423
to
e8958e3
Compare
djc
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change default for
require_emsbased onfipscrate feature, generalising the existing tests forrequire_emsto verify this too.Include
require_emsinfips()determination.