Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take curve25519-dalek 4.1.2 #1775

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Take curve25519-dalek 4.1.2 #1775

merged 2 commits into from
Feb 7, 2024

Conversation

ctz
Copy link
Member

@ctz ctz commented Feb 7, 2024

This fixes the nightly build breakage currently on main.

@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented Feb 7, 2024 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 4663548 4561237 -102311 (-2.19%) 3.63%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 4111134 4080215 -30919 (-0.75%) 4.06%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 12270297 12331241 60944 (0.50%) 0.94%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 12676664 12702313 25649 (0.20%) 0.80%
handshake_session_id_ring_1.2_rsa_aes_client 4472863 4480360 7497 (0.17%) 0.74%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 30507277 30556243 48966 (0.16%) 0.72%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8682967 8670317 -12650 (-0.15%) 0.78%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 30326337 30366827 40490 (0.13%) 0.62%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 32667632 32628933 -38699 (-0.12%) 0.49%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4571982 4566636 -5346 (-0.12%) 1.12%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 57143672 57078410 -65262 (-0.11%) 0.41%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8667338 8657638 -9700 (-0.11%) 1.67%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 4249682 4245083 -4599 (-0.11%) 1.16%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 2129162 2127026 -2136 (-0.10%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3339497 3342323 2826 (0.08%) 0.24%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 57113279 57157923 44644 (0.08%) 0.43%
handshake_tickets_ring_1.2_rsa_aes_client 4745565 4741952 -3613 (-0.08%) 0.73%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 32839388 32815279 -24109 (-0.07%) 0.43%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 32639587 32617683 -21904 (-0.07%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 43858084 43886222 28138 (0.06%) 0.24%
handshake_tickets_ring_1.3_rsa_chacha_server 43880662 43908189 27527 (0.06%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 32614305 32595485 -18820 (-0.06%) 0.43%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 57963753 57936744 -27009 (-0.05%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3896534 3894737 -1797 (-0.05%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 12693542 12687782 -5760 (-0.05%) 0.85%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 30725020 30738506 13486 (0.04%) 0.45%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 91255023 91293985 38962 (0.04%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 30722550 30709807 -12743 (-0.04%) 0.39%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1886395 1885633 -762 (-0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 30339595 30327610 -11985 (-0.04%) 0.50%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 32850471 32863385 12914 (0.04%) 0.22%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 43865064 43880550 15486 (0.04%) 0.29%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 57157972 57178057 20085 (0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 30332164 30342047 9883 (0.03%) 0.47%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3345795 3346850 1055 (0.03%) 0.29%
handshake_session_id_ring_1.3_rsa_aes_client 42226719 42213562 -13157 (-0.03%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92462080 92434481 -27599 (-0.03%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 13737334 13741371 4037 (0.03%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 42395282 42383401 -11881 (-0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 32883223 32892427 9204 (0.03%) 0.78%
handshake_session_id_ring_1.2_rsa_aes_server 4371877 4372947 1070 (0.02%) 0.73%
handshake_session_id_ring_1.3_ecdsap384_aes_server 43679470 43669393 -10077 (-0.02%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 42147688 42138223 -9465 (-0.02%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 91348020 91368431 20411 (0.02%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4833213 4832151 -1062 (-0.02%) 0.67%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 91348569 91329020 -19549 (-0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 30520097 30513861 -6236 (-0.02%) 0.50%
handshake_tickets_ring_1.3_ecdsap384_aes_client 42192453 42201050 8597 (0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 32860559 32854065 -6494 (-0.02%) 0.53%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 32616061 32610251 -5810 (-0.02%) 0.29%
handshake_tickets_ring_1.3_ecdsap256_aes_server 43848671 43856243 7572 (0.02%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 43833413 43840973 7560 (0.02%) 0.33%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 30330430 30325534 -4896 (-0.02%) 0.41%
handshake_no_resume_ring_1.3_rsa_chacha_client 4547904 4548593 689 (0.02%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 42200238 42206312 6074 (0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 91371357 91358997 -12360 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 43593609 43587858 -5751 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 30523242 30519386 -3856 (-0.01%) 0.50%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 41983462 41978460 -5002 (-0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35450531 35454603 4072 (0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 57947847 57953908 6061 (0.01%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 43659205 43663583 4378 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 42023726 42027677 3951 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 42171103 42167346 -3757 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 43658858 43655105 -3753 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 57951452 57946791 -4661 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1882984 1882836 -148 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 30510245 30512591 2346 (0.01%) 0.40%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 57091312 57087032 -4280 (-0.01%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 43594145 43597337 3192 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 32829959 32832237 2278 (0.01%) 0.30%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 2131664 2131803 139 (0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92445266 92450995 5729 (0.01%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 42354948 42352423 -2525 (-0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 57975038 57971776 -3262 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 3356729 3356546 -183 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 42159623 42161829 2206 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 3367486 3367310 -176 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 42025379 42023301 -2078 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 91260098 91255893 -4205 (-0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 4441431 4441631 200 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92390672 92386596 -4076 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3899185 3899348 163 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 57092494 57094864 2370 (0.00%) 0.26%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 30530939 30532194 1255 (0.00%) 0.38%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 41971569 41970349 -1220 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 30530036 30530837 801 (0.00%) 0.42%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 57991695 57993144 1449 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 32640675 32641464 789 (0.00%) 0.45%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 3153787 3153722 -65 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92392881 92391055 -1826 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92384121 92385916 1795 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 12240518 12240288 -230 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 43596983 43596207 -776 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 4261542 4261472 -70 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 4537963 4537890 -73 (-0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 12046242 12046070 -172 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 57137093 57137843 750 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 43933126 43933492 366 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92438139 92438850 711 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 57813446 57813016 -430 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 32851936 32851702 -234 (-0.00%) 0.27%
transfer_no_resume_ring_1.3_rsa_aes_server 57087526 57087825 299 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 12250402 12250347 -55 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 56972125 56972280 155 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 57951477 57951362 -115 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 13738082 13738058 -24 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35451507 35451551 44 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 91252382 91252279 -103 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 68433899 68433961 62 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 32643126 32643115 -11 (-0.00%) 0.30%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 4265774 4265774 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_tickets_ring_1.3_ecdsap256_chacha 6.82 ms 6.88 ms 0.06 ms (0.88%) 1.27%
handshake_tickets_ring_1.3_rsa_chacha 7.45 ms 7.51 ms 0.06 ms (0.82%) 1.25%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 2.19 ms 2.17 ms -0.02 ms (-0.79%) 2.23%
handshake_session_id_ring_1.3_rsa_chacha 7.45 ms 7.50 ms 0.06 ms (0.75%) 1.13%
handshake_tickets_ring_1.3_ecdsap256_aes 6.86 ms 6.91 ms 0.05 ms (0.74%) 1.14%
handshake_tickets_ring_1.3_rsa_aes 7.50 ms 7.56 ms 0.05 ms (0.72%) 1.18%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.82 ms 6.87 ms 0.05 ms (0.68%) 1.30%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.92 ms 9.98 ms 0.07 ms (0.67%) 1.00%
transfer_no_resume_ring_1.3_rsa_aes 7.24 ms 7.29 ms 0.05 ms (0.66%) 3.09%
handshake_session_id_ring_1.3_rsa_aes 7.49 ms 7.54 ms 0.05 ms (0.65%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_aes 9.96 ms 10.02 ms 0.06 ms (0.62%) 1.00%
handshake_no_resume_ring_1.3_ecdsap256_chacha 504.36 µs 507.40 µs 3.05 µs (0.60%) 2.75%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.81 ms 5.85 ms 0.03 ms (0.60%) 4.45%
handshake_session_id_ring_1.3_ecdsap256_aes 6.85 ms 6.89 ms 0.04 ms (0.57%) 1.00%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 2.35 ms 2.33 ms -0.01 ms (-0.56%) 2.05%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.91 ms 9.97 ms 0.06 ms (0.56%) 1.14%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.59 ms 5.62 ms 0.03 ms (0.54%) 7.30%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.77 ms 9.82 ms 0.05 ms (0.53%) 2.92%
handshake_session_id_ring_1.3_ecdsap384_aes 9.94 ms 9.99 ms 0.05 ms (0.51%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.60 ms 3.62 ms 0.02 ms (0.51%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.60 ms 3.62 ms 0.02 ms (0.50%) 1.00%
handshake_no_resume_ring_1.3_ecdsap256_aes 505.67 µs 507.77 µs 2.11 µs (0.42%) 2.97%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.19 ms 1.19 ms 0.00 ms (0.37%) 1.16%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.88 ms 4.89 ms 0.02 ms (0.35%) 7.27%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.82 ms 5.84 ms 0.02 ms (0.35%) 4.04%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.67 ms 6.69 ms 0.02 ms (0.32%) 3.92%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.45 ms 16.51 ms 0.05 ms (0.32%) 2.07%
transfer_no_resume_ring_1.3_rsa_chacha 13.94 ms 13.98 ms 0.04 ms (0.29%) 1.72%
handshake_tickets_ring_1.2_rsa_aes 1.84 ms 1.85 ms 0.01 ms (0.28%) 2.03%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 14.07 ms 14.10 ms 0.04 ms (0.25%) 2.46%
handshake_session_id_ring_1.2_rsa_aes 1.76 ms 1.75 ms -0.00 ms (-0.24%) 2.26%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 14.30 ms 14.33 ms 0.03 ms (0.23%) 1.82%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 475.10 µs 475.96 µs 0.86 µs (0.18%) 3.92%
handshake_no_resume_ring_1.3_rsa_aes 1.08 ms 1.08 ms 0.00 ms (0.18%) 1.18%
handshake_no_resume_ring_1.2_rsa_aes 1.07 ms 1.07 ms -0.00 ms (-0.17%) 1.23%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.41 ms 1.42 ms 0.00 ms (0.17%) 1.36%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.36 ms 13.38 ms 0.02 ms (0.16%) 2.32%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.36 ms 1.36 ms 0.00 ms (0.15%) 1.47%
transfer_no_resume_ring_1.3_ecdsap256_chacha 13.37 ms 13.38 ms 0.02 ms (0.14%) 2.77%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 5.37 ms 5.37 ms -0.01 ms (-0.13%) 2.40%
transfer_no_resume_ring_1.2_rsa_aes 7.18 ms 7.18 ms 0.01 ms (0.13%) 3.70%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 5.41 ms 5.40 ms -0.01 ms (-0.12%) 2.65%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 6.38 ms 6.37 ms -0.01 ms (-0.11%) 2.03%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 6.07 ms 6.07 ms -0.01 ms (-0.10%) 2.31%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 475.95 µs 476.38 µs 0.42 µs (0.09%) 4.54%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 5.38 ms 5.38 ms -0.00 ms (-0.07%) 2.69%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 6.39 ms 6.38 ms -0.00 ms (-0.06%) 2.45%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.18 ms 1.18 ms 0.00 ms (0.05%) 1.54%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 6.40 ms 6.40 ms -0.00 ms (-0.04%) 2.10%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 5.41 ms 5.41 ms -0.00 ms (-0.03%) 2.41%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 6.09 ms 6.09 ms 0.00 ms (0.02%) 2.34%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.41 ms 1.41 ms 0.00 ms (0.02%) 1.20%
handshake_no_resume_ring_1.3_rsa_chacha 1.08 ms 1.08 ms 0.00 ms (0.02%) 1.30%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 6.12 ms 6.12 ms 0.00 ms (0.01%) 1.92%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 6.12 ms 6.12 ms 0.00 ms (0.01%) 2.07%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 6.41 ms 6.41 ms -0.00 ms (-0.00%) 2.01%

Additional information

Historical results

Checkout details:

@djc
Copy link
Member

djc commented Feb 7, 2024

Do you just want to take all the semver-compatible updates in this PR? IIRC we haven't done that this week yet.

@ctz ctz enabled auto-merge February 7, 2024 14:31
@ctz ctz added this pull request to the merge queue Feb 7, 2024
Merged via the queue into main with commit 501f91c Feb 7, 2024
42 checks passed
@ctz ctz deleted the jbp-fix-nightly-build branch February 7, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@cpu cpu cpu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ctz @djc @cpu