Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cargo.toml: disentangle std/aws_lc_rs features #1818

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Cargo.toml: disentangle std/aws_lc_rs features #1818

merged 1 commit into from
Feb 28, 2024

Conversation

ctz
Copy link
Member

@ctz ctz commented Feb 28, 2024

(will see what this breaks, but I think this should be orthogonal? I know aws-lc-rs itself requires std, but that should be unrelated to this crate's features.)

@cpu cpu mentioned this pull request Feb 28, 2024
Merged
@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented Feb 28, 2024 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 4058769 4014159 -44610 (-1.10%) 3.74%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4522514 4504475 -18039 (-0.40%) 1.02%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 12688060 12644708 -43352 (-0.34%) 0.88%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8687027 8664848 -22179 (-0.26%) 0.91%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 30396640 30468374 71734 (0.24%) 0.52%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 32640324 32713210 72886 (0.22%) 0.45%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 12701737 12673428 -28309 (-0.22%) 0.93%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 4515848 4525810 9962 (0.22%) 3.09%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46177676 46265956 88280 (0.19%) 0.33%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 32463792 32511529 47737 (0.15%) 0.53%
handshake_tickets_ring_1.2_rsa_aes_server 4770998 4764040 -6958 (-0.15%) 0.61%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 30233536 30275465 41929 (0.14%) 0.49%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8658256 8670074 11818 (0.14%) 0.74%
handshake_tickets_ring_1.2_rsa_aes_client 4701181 4706115 4934 (0.10%) 0.83%
handshake_session_id_ring_1.2_rsa_aes_client 4445226 4441353 -3873 (-0.09%) 0.85%
handshake_tickets_ring_1.3_ecdsap256_aes_server 43718443 43753807 35364 (0.08%) 0.33%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 30463613 30439302 -24311 (-0.08%) 0.27%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 32675641 32698695 23054 (0.07%) 0.74%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 30468877 30488081 19204 (0.06%) 0.22%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 12299135 12291511 -7624 (-0.06%) 1.09%
handshake_session_id_ring_1.3_ecdsap384_aes_server 43535184 43557069 21885 (0.05%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 32650498 32665713 15215 (0.05%) 0.25%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46288840 46267637 -21203 (-0.05%) 0.33%
handshake_tickets_ring_1.3_ecdsap384_aes_server 43730838 43750167 19329 (0.04%) 0.22%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 4183180 4184890 1710 (0.04%) 0.97%
handshake_session_id_ring_1.3_ecdsap384_aes_client 42005277 42022239 16962 (0.04%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 2129268 2128438 -830 (-0.04%) 0.38%
handshake_tickets_ring_1.3_ecdsap256_aes_client 42166252 42182422 16170 (0.04%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 32658240 32647030 -11210 (-0.03%) 0.33%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 43670074 43684957 14883 (0.03%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 43537275 43522632 -14643 (-0.03%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 57952584 57971262 18678 (0.03%) 0.23%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 32441406 32451803 10397 (0.03%) 0.31%
handshake_tickets_ring_1.3_rsa_aes_client 42398083 42384633 -13450 (-0.03%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 43657131 43643465 -13666 (-0.03%) 0.23%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 30671624 30662047 -9577 (-0.03%) 0.26%
handshake_session_id_ring_1.3_ecdsap256_aes_client 42004173 41991277 -12896 (-0.03%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1879924 1879374 -550 (-0.03%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 42164609 42176849 12240 (0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 32655930 32664481 8551 (0.03%) 0.27%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 43460461 43449293 -11168 (-0.03%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 13734317 13730808 -3509 (-0.03%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 4257540 4258627 1087 (0.03%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 30263889 30256415 -7474 (-0.02%) 0.45%
handshake_session_id_ring_1.3_rsa_aes_client 42204317 42214707 10390 (0.02%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 43440199 43450748 10549 (0.02%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 43713213 43723183 9970 (0.02%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46290528 46300812 10284 (0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 32447801 32455004 7203 (0.02%) 0.30%
handshake_session_id_ring_1.3_rsa_chacha_client 42130516 42121469 -9047 (-0.02%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 41919045 41910986 -8059 (-0.02%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46256122 46264996 8874 (0.02%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80438129 80453419 15290 (0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 30452852 30447845 -5007 (-0.02%) 0.31%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92456120 92441432 -14688 (-0.02%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80343225 80355727 12502 (0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 30427526 30432168 4642 (0.02%) 0.30%
handshake_session_id_ring_1.2_rsa_aes_server 4323544 4324197 653 (0.02%) 0.52%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35453114 35447932 -5182 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 32466265 32461665 -4600 (-0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3899976 3899445 -531 (-0.01%) 0.34%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 30256087 30260205 4118 (0.01%) 0.22%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 4262776 4262197 -579 (-0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80436431 80445600 9169 (0.01%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 42322116 42326740 4624 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 3366400 3366750 350 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1883432 1883240 -192 (-0.01%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46176198 46171790 -4408 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 41931309 41927367 -3942 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 42100864 42097183 -3681 (-0.01%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 43796604 43792839 -3765 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 32655329 32652974 -2355 (-0.01%) 0.35%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 42107765 42104772 -2993 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 32468371 32470503 2132 (0.01%) 0.25%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 30449281 30447286 -1995 (-0.01%) 0.22%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 30671428 30673304 1876 (0.01%) 0.32%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3344785 3344595 -190 (-0.01%) 0.22%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3339418 3339236 -182 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 43444742 43442733 -2009 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 30303952 30305287 1335 (0.00%) 0.25%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 3152038 3151911 -127 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3897924 3897767 -157 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 32450026 32451222 1196 (0.00%) 0.49%
handshake_no_resume_ring_1.3_rsa_aes_client 4538300 4538146 -154 (-0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 43540574 43539242 -1332 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 2126745 2126696 -49 (-0.00%) 0.34%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80346400 80344843 -1557 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46264905 46265772 867 (0.00%) 0.25%
handshake_no_resume_ring_1.3_rsa_chacha_server 12246889 12246664 -225 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 4547442 4547522 80 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46299851 46300635 784 (0.00%) 0.25%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 57967292 57968171 879 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58063674 58064487 813 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 3355705 3355659 -46 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46302162 46301570 -592 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92435554 92434554 -1000 (-0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 4440428 4440387 -41 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 57986493 57985980 -513 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80455697 80455059 -638 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58062371 58061976 -395 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 12237454 12237383 -71 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58063972 58064266 294 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92398638 92398246 -392 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 13737439 13737487 48 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 68385777 68385986 209 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92456135 92455867 -268 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92394424 92394601 177 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92397067 92396897 -170 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 57920513 57920609 96 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35455172 35455132 -40 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80343445 80343373 -72 (-0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 12042622 12042612 -10 (-0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 472.69 µs 476.93 µs 4.24 µs (0.90%) 2.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 474.62 µs 477.82 µs 3.20 µs (0.67%) 2.64%
handshake_no_resume_ring_1.3_ecdsap256_aes 505.65 µs 509.06 µs 3.40 µs (0.67%) 2.39%
handshake_no_resume_ring_1.3_ecdsap256_chacha 503.80 µs 507.12 µs 3.32 µs (0.66%) 2.35%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.70 ms 5.74 ms 0.04 ms (0.62%) 3.66%
transfer_no_resume_ring_1.2_rsa_aes 7.09 ms 7.13 ms 0.03 ms (0.48%) 2.94%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.72 ms 5.75 ms 0.03 ms (0.48%) 3.69%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.78 ms 4.80 ms 0.02 ms (0.45%) 4.70%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.50 ms 5.52 ms 0.02 ms (0.38%) 4.11%
handshake_tickets_ring_1.2_rsa_aes 1.83 ms 1.83 ms -0.01 ms (-0.35%) 1.63%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.61 ms 3.62 ms 0.01 ms (0.29%) 1.39%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.36 ms 1.37 ms 0.00 ms (0.27%) 1.02%
handshake_session_id_ring_1.2_rsa_aes 1.74 ms 1.74 ms -0.00 ms (-0.25%) 2.16%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.41 ms 1.41 ms 0.00 ms (0.21%) 1.00%
handshake_no_resume_ring_1.2_rsa_aes 1.07 ms 1.07 ms 0.00 ms (0.21%) 1.00%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 6.37 ms 6.36 ms -0.01 ms (-0.19%) 2.11%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.61 ms 3.62 ms 0.01 ms (0.19%) 1.15%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.19 ms 1.19 ms 0.00 ms (0.19%) 1.15%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 14.20 ms 14.23 ms 0.03 ms (0.19%) 1.36%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 6.10 ms 6.11 ms 0.01 ms (0.18%) 1.87%
handshake_no_resume_ring_1.3_rsa_chacha 1.08 ms 1.09 ms 0.00 ms (0.17%) 1.00%
transfer_no_resume_ring_1.3_rsa_aes 7.20 ms 7.21 ms 0.01 ms (0.17%) 2.51%
transfer_no_resume_ring_1.3_rsa_chacha 13.86 ms 13.88 ms 0.02 ms (0.15%) 1.56%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 2.16 ms 2.16 ms -0.00 ms (-0.14%) 1.50%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.62 ms 6.63 ms 0.01 ms (0.14%) 3.52%
handshake_tickets_ring_1.3_rsa_aes 7.53 ms 7.54 ms 0.01 ms (0.14%) 1.75%
handshake_tickets_ring_1.3_rsa_chacha 7.48 ms 7.49 ms 0.01 ms (0.13%) 2.03%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 6.40 ms 6.39 ms -0.01 ms (-0.13%) 2.19%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 2.32 ms 2.32 ms -0.00 ms (-0.12%) 1.76%
handshake_tickets_ring_1.3_ecdsap384_aes 10.00 ms 10.01 ms 0.01 ms (0.12%) 2.21%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.97 ms 13.99 ms 0.02 ms (0.11%) 1.65%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 5.39 ms 5.39 ms 0.01 ms (0.11%) 2.26%
transfer_no_resume_ring_1.3_ecdsap256_chacha 13.28 ms 13.30 ms 0.01 ms (0.11%) 1.78%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.18 ms 1.18 ms 0.00 ms (0.10%) 1.10%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 6.37 ms 6.37 ms -0.01 ms (-0.10%) 1.79%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.27 ms 13.28 ms 0.01 ms (0.10%) 1.59%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.96 ms 9.97 ms 0.01 ms (0.09%) 2.27%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.95 ms 9.96 ms 0.01 ms (0.09%) 1.94%
handshake_session_id_ring_1.3_rsa_chacha 7.48 ms 7.49 ms 0.01 ms (0.08%) 2.26%
handshake_no_resume_ring_1.3_rsa_aes 1.08 ms 1.08 ms 0.00 ms (0.08%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 6.10 ms 6.11 ms 0.00 ms (0.07%) 2.09%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 5.37 ms 5.36 ms -0.00 ms (-0.07%) 1.99%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.72 ms 9.73 ms 0.01 ms (0.07%) 2.64%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 5.40 ms 5.40 ms 0.00 ms (0.06%) 2.53%
handshake_session_id_ring_1.3_ecdsap384_aes 9.99 ms 9.99 ms 0.01 ms (0.06%) 1.76%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.41 ms 1.41 ms 0.00 ms (0.06%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.85 ms 6.85 ms -0.00 ms (-0.05%) 2.24%
handshake_session_id_ring_1.3_ecdsap256_aes 6.89 ms 6.88 ms -0.00 ms (-0.05%) 1.81%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.39 ms 16.40 ms 0.01 ms (0.04%) 1.62%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 5.37 ms 5.37 ms -0.00 ms (-0.04%) 2.29%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 6.06 ms 6.07 ms 0.00 ms (0.04%) 1.83%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 6.39 ms 6.38 ms -0.00 ms (-0.03%) 1.89%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 6.08 ms 6.08 ms -0.00 ms (-0.02%) 1.98%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.86 ms 6.86 ms -0.00 ms (-0.01%) 2.05%
handshake_session_id_ring_1.3_rsa_aes 7.52 ms 7.52 ms 0.00 ms (0.01%) 1.76%
handshake_tickets_ring_1.3_ecdsap256_aes 6.90 ms 6.90 ms -0.00 ms (-0.01%) 1.94%

Additional information

Historical results

Checkout details:

@ctz ctz marked this pull request as draft February 28, 2024 19:42
@codecov Codecov
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.83%. Comparing base (425b527) to head (e6e8a50).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1818   +/-   ##
=======================================
  Coverage   95.83%   95.83%           
=======================================
  Files          84       84           
  Lines       18861    18861           
=======================================
  Hits        18075    18075           
  Misses        786      786

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ctz ctz marked this pull request as ready for review February 28, 2024 19:56
cpu
cpu approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me, thank you!

@ctz ctz added this pull request to the merge queue Feb 28, 2024
Merged via the queue into main with commit cf098b0 Feb 28, 2024
44 checks passed
@ctz ctz deleted the ctz-patch-1 branch February 28, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpu cpu cpu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ctz @cpu