Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return correct ConnectionTrafficSecrets variant when AES-256-GCM is negotiated. #1834

Merged
merged 2 commits into from
Mar 3, 2024
Merged

Return correct ConnectionTrafficSecrets variant when AES-256-GCM is negotiated. #1834

merged 2 commits into from
Mar 3, 2024

Conversation

Arnavion
Copy link
Contributor

@Arnavion Arnavion commented Mar 2, 2024

55bb279 inadvertently changed extract_keys to always return ConnectionTrafficSecrets::Aes128Gcm, even when AES-256-GCM was negotiated. This change fixes it by restoring the key length check.

Fixes #1833

@Arnavion
Return correct ConnectionTrafficSecrets variant when AES-256-GCM is…
e4a3fec 
… negotiated.

55bb279 inadvertently changed `extract_keys`
to always return `ConnectionTrafficSecrets::Aes128Gcm`, even when AES-256-GCM
was negotiated. This change fixes it by restoring the key length check.

Fixes #1833
@Arnavion
Copy link
Contributor Author

Arnavion commented Mar 2, 2024

I didn't add a test for this because the existing tests don't test with the granularity of specific protocol versions / ciphersuites. I can add a test if you want, though in that case I would rather add something that exhaustively tests every combination of TLS 1.2 / TLS 1.3 and AES-128-GCM / AES-256-GCM / CHACHA20-POLY1305.

In fact I hit the original bug with a kTLS client that tests every combination in exactly that way. I have verified this branch using that client.

@codecov Codecov
Copy link

codecov bot commented Mar 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 95.82%. Comparing base (546a85d) to head (789e384).

❗ Current head 789e384 differs from pull request most recent head 6ef41f4. Consider uploading reports for the commit 6ef41f4 to get more accurate results

Files Patch % Lines
rustls/src/crypto/aws_lc_rs/tls12.rs 90.00% 1 Missing ⚠️
rustls/src/crypto/ring/tls12.rs 90.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1834      +/-   ##
==========================================
- Coverage   95.83%   95.82%   -0.01%     
==========================================
  Files          84       84              
  Lines       18864    18876      +12     
==========================================
+ Hits        18078    18088      +10     
- Misses        786      788       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ctz
Copy link
Member

ctz commented Mar 2, 2024

Thanks for the report and the fix! Going to go ahead and push a test for this on top of your PR -- I expect this will point to a similar problem in the aws-lc-rs code.

cpu
cpu approved these changes Mar 2, 2024
View reviewed changes
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️ thanks for catching my mistake here!

@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented Mar 2, 2024 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 4497784 4575528 77744 (1.73%) 3.09%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 4009682 4061215 51533 (1.29%) 3.91%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 12685984 12646264 -39720 (-0.31%) 0.88%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 12687369 12724638 37269 (0.29%) 0.88%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 32657772 32748938 91166 (0.28%) 0.39%
handshake_tickets_ring_1.2_rsa_aes_server 4761927 4772973 11046 (0.23%) 0.46%
handshake_tickets_ring_1.2_rsa_aes_client 4706517 4717313 10796 (0.23%) 0.80%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 12296888 12274288 -22600 (-0.18%) 0.94%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46256114 46332191 76077 (0.16%) 0.39%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4515418 4521993 6575 (0.15%) 0.78%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 2124367 2126871 2504 (0.12%) 0.38%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 32685445 32648513 -36932 (-0.11%) 0.65%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3899193 3894813 -4380 (-0.11%) 0.28%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80460137 80372757 -87380 (-0.11%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 32657149 32623170 -33979 (-0.10%) 0.32%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 32453519 32421284 -32235 (-0.10%) 0.49%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8673396 8665116 -8280 (-0.10%) 0.65%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 30447329 30475083 27754 (0.09%) 0.53%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 32437267 32465812 28545 (0.09%) 0.28%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 2128603 2126738 -1865 (-0.09%) 0.36%
handshake_session_id_ring_1.2_rsa_aes_client 4440185 4443269 3084 (0.07%) 0.76%
handshake_session_id_ring_1.2_rsa_aes_server 4328883 4325911 -2972 (-0.07%) 0.50%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3342476 3344535 2059 (0.06%) 0.24%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8647994 8653123 5129 (0.06%) 0.89%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 4182490 4180029 -2461 (-0.06%) 0.82%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46222920 46248595 25675 (0.06%) 0.30%
handshake_tickets_ring_1.3_rsa_aes_client 42373442 42396249 22807 (0.05%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58000804 57970091 -30713 (-0.05%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 43654814 43677636 22822 (0.05%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 32472028 32487778 15750 (0.05%) 0.51%
handshake_session_id_ring_1.3_rsa_aes_client 42211929 42192547 -19382 (-0.05%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 30257147 30243492 -13655 (-0.05%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 43678918 43659433 -19485 (-0.04%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3895616 3897188 1572 (0.04%) 0.21%
handshake_tickets_ring_1.3_rsa_aes_server 43791521 43775204 -16317 (-0.04%) 0.21%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46285919 46301505 15586 (0.03%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 43437466 43450763 13297 (0.03%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 42001647 41988912 -12735 (-0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 30460201 30450968 -9233 (-0.03%) 0.30%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 32645588 32654600 9012 (0.03%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 32475306 32466572 -8734 (-0.03%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 43712951 43723987 11036 (0.03%) 0.21%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46304897 46293322 -11575 (-0.02%) 0.24%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 30427583 30435161 7578 (0.02%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 42017348 42007121 -10227 (-0.02%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46300468 46290127 -10341 (-0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 30289058 30282602 -6456 (-0.02%) 0.49%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 41928114 41936116 8002 (0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 32440040 32445917 5877 (0.02%) 0.23%
handshake_session_id_ring_1.3_rsa_aes_server 43541269 43548961 7692 (0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 30488842 30483542 -5300 (-0.02%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 42177761 42170543 -7218 (-0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 32642679 32637314 -5365 (-0.02%) 0.27%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1883036 1882741 -295 (-0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 32660492 32665472 4980 (0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 32473632 32468913 -4719 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 30661049 30665238 4189 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 42103119 42108819 5700 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3341585 3341174 -411 (-0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80455432 80445621 -9811 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 43530140 43535427 5287 (0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92462066 92451060 -11006 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 30293979 30297582 3603 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 43738607 43733493 -5114 (-0.01%) 0.21%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58066786 58060670 -6116 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 43765878 43761373 -4505 (-0.01%) 0.28%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92392757 92401791 9034 (0.01%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 4538374 4537938 -436 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1879322 1879502 180 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 41916737 41920129 3392 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 4258085 4258424 339 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 4262326 4262635 309 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 3366457 3366214 -243 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 30448356 30450538 2182 (0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58060077 58064191 4114 (0.01%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 43440456 43437471 -2985 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80354923 80359792 4869 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 30675365 30676984 1619 (0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80344598 80348542 3944 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92396815 92401308 4493 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 4440341 4440163 -178 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 43536337 43538071 1734 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 13734628 13735173 545 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 57963545 57965833 2288 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 3151677 3151774 97 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 4547309 4547176 -133 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 13733688 13733292 -396 (-0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 42125027 42126169 1142 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92437404 92434987 -2417 (-0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 12042516 12042225 -291 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 30455752 30455021 -731 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 42169088 42168319 -769 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 12246661 12246457 -204 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92398207 92396821 -1386 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 3355455 3355504 49 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35451094 35450608 -486 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 43441583 43442127 544 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 42322739 42322316 -423 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 30278237 30277961 -276 (-0.00%) 0.36%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 42109756 42110102 346 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 57986057 57986503 446 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46176248 46176544 296 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58064082 58064423 341 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35452570 35452369 -201 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92455995 92456440 445 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46254673 46254454 -219 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 68386156 68386389 233 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46265267 46265121 -146 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80343562 80343779 217 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 12237312 12237334 22 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 57920579 57920658 79 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80455393 80455340 -53 (-0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.74 ms 4.82 ms 0.08 ms (1.59%) 4.24%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.57 ms 6.66 ms 0.09 ms (1.44%) 3.46%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.68 ms 5.76 ms 0.08 ms (1.40%) 3.47%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.46 ms 5.54 ms 0.07 ms (1.36%) 3.83%
transfer_no_resume_ring_1.3_rsa_aes 7.14 ms 7.24 ms 0.10 ms (1.36%) 2.47%
transfer_no_resume_ring_1.2_rsa_aes 7.06 ms 7.15 ms 0.09 ms (1.23%) 2.74%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.69 ms 5.76 ms 0.07 ms (1.23%) 3.48%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.67 ms 9.77 ms 0.10 ms (0.99%) 2.58%
handshake_no_resume_ring_1.3_ecdsap256_aes 508.69 µs 513.25 µs 4.56 µs (0.90%) 2.13%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 474.42 µs 478.51 µs 4.08 µs (0.86%) 2.51%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 479.60 µs 482.88 µs 3.28 µs (0.68%) 2.51%
handshake_no_resume_ring_1.3_ecdsap256_chacha 505.34 µs 508.69 µs 3.35 µs (0.66%) 2.35%
handshake_session_id_ring_1.2_rsa_aes 1.74 ms 1.75 ms 0.01 ms (0.61%) 2.16%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.24 ms 13.31 ms 0.07 ms (0.56%) 1.40%
transfer_no_resume_ring_1.3_rsa_chacha 13.82 ms 13.90 ms 0.08 ms (0.56%) 1.50%
handshake_no_resume_ring_1.3_rsa_chacha 1.08 ms 1.09 ms 0.01 ms (0.54%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.94 ms 14.01 ms 0.07 ms (0.54%) 1.60%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 14.17 ms 14.25 ms 0.08 ms (0.53%) 1.33%
transfer_no_resume_ring_1.3_ecdsap256_chacha 13.25 ms 13.32 ms 0.07 ms (0.53%) 1.64%
handshake_no_resume_ring_1.3_rsa_aes 1.08 ms 1.09 ms 0.01 ms (0.48%) 1.02%
handshake_tickets_ring_1.2_rsa_aes 1.83 ms 1.84 ms 0.01 ms (0.48%) 1.70%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.35 ms 16.43 ms 0.08 ms (0.46%) 1.53%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 5.35 ms 5.37 ms 0.02 ms (0.44%) 1.92%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.18 ms 1.18 ms 0.01 ms (0.44%) 1.10%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 6.35 ms 6.37 ms 0.02 ms (0.38%) 1.72%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 6.36 ms 6.39 ms 0.02 ms (0.38%) 1.74%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 6.06 ms 6.09 ms 0.02 ms (0.35%) 1.66%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 6.37 ms 6.39 ms 0.02 ms (0.34%) 2.12%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.41 ms 1.41 ms 0.00 ms (0.33%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 5.37 ms 5.39 ms 0.02 ms (0.33%) 2.07%
handshake_no_resume_ring_1.2_rsa_aes 1.07 ms 1.08 ms 0.00 ms (0.33%) 1.02%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 6.09 ms 6.11 ms 0.02 ms (0.31%) 1.64%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.19 ms 1.19 ms 0.00 ms (0.30%) 1.05%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 2.16 ms 2.17 ms 0.01 ms (0.28%) 1.55%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 5.38 ms 5.39 ms 0.01 ms (0.27%) 2.43%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 6.09 ms 6.10 ms 0.02 ms (0.25%) 2.02%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 6.35 ms 6.36 ms 0.01 ms (0.21%) 2.15%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.61 ms 3.62 ms 0.01 ms (0.20%) 1.15%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 6.05 ms 6.06 ms 0.01 ms (0.20%) 1.81%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 2.33 ms 2.33 ms 0.00 ms (0.18%) 1.73%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.41 ms 1.42 ms 0.00 ms (0.17%) 1.00%
handshake_session_id_ring_1.3_rsa_chacha 7.47 ms 7.48 ms 0.01 ms (0.17%) 1.74%
handshake_tickets_ring_1.3_rsa_chacha 7.49 ms 7.50 ms 0.01 ms (0.12%) 1.42%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.86 ms 6.86 ms 0.01 ms (0.10%) 1.84%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 5.35 ms 5.36 ms 0.01 ms (0.10%) 2.09%
handshake_session_id_ring_1.3_ecdsap256_aes 6.88 ms 6.89 ms 0.01 ms (0.10%) 1.71%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.84 ms 6.85 ms 0.01 ms (0.09%) 1.70%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.61 ms 3.62 ms 0.00 ms (0.08%) 1.16%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.95 ms 9.95 ms 0.01 ms (0.06%) 1.49%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.37 ms 1.37 ms 0.00 ms (0.06%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_aes 10.00 ms 10.01 ms 0.01 ms (0.05%) 1.40%
handshake_session_id_ring_1.3_rsa_aes 7.53 ms 7.53 ms 0.00 ms (0.05%) 1.53%
handshake_tickets_ring_1.3_ecdsap256_aes 6.90 ms 6.91 ms 0.00 ms (0.05%) 1.80%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.96 ms 9.96 ms 0.00 ms (0.03%) 1.30%
handshake_session_id_ring_1.3_ecdsap384_aes 9.98 ms 9.99 ms 0.00 ms (0.02%) 1.24%
handshake_tickets_ring_1.3_rsa_aes 7.54 ms 7.54 ms 0.00 ms (0.02%) 1.51%

Additional information

Historical results

Checkout details:

djc
djc reviewed Mar 2, 2024
View reviewed changes
rustls/src/crypto/ring/tls12.rs Outdated Show resolved Hide resolved
@ctz ctz added this pull request to the merge queue Mar 3, 2024
@ctz
Copy link
Member

ctz commented Mar 3, 2024

Thank you!

Merged via the queue into rustls:main with commit 9ef2150 Mar 3, 2024
24 of 25 checks passed
@djc
Copy link
Member

djc commented Mar 3, 2024

I guess we should do a release for this?

@ctz
Copy link
Member

ctz commented Mar 4, 2024

Certainly, yes. I'll aim to cut a 0.23.2 later this week.

@cpu
Copy link
Member

cpu commented Mar 11, 2024

Certainly, yes. I'll aim to cut a 0.23.2 later this week.

I think it probably merits a 0.22 point release as well

@cpu cpu mentioned this pull request Mar 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@cpu cpu cpu approved these changes

@ctz ctz ctz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@Arnavion @ctz @djc @cpu