Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix newly found unused_qualifications warnings #1839

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Fix newly found unused_qualifications warnings #1839

merged 1 commit into from
Mar 6, 2024

Conversation

ctz
Copy link
Member

@ctz ctz commented Mar 6, 2024

eg.

error: unnecessary qualification
  --> rustls/src/vecbuf.rs:88:24
   |
88 |             let used = core::cmp::min(chunk.len(), cursor.capacity());
   |                        ^^^^^^^^^^^^^^
   |
help: remove the unnecessary path segments
   |
88 -             let used = core::cmp::min(chunk.len(), cursor.capacity());
88 +             let used = cmp::min(chunk.len(), cursor.capacity());
   |

@ctz
Fix newly found unused_qualifications warnings
82c32cf 
eg.

```
error: unnecessary qualification
  --> rustls/src/vecbuf.rs:88:24
   |
88 |             let used = core::cmp::min(chunk.len(), cursor.capacity());
   |                        ^^^^^^^^^^^^^^
   |
help: remove the unnecessary path segments
   |
88 -             let used = core::cmp::min(chunk.len(), cursor.capacity());
88 +             let used = cmp::min(chunk.len(), cursor.capacity());
   |
```
@codecov Codecov
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 95.82%. Comparing base (54a9557) to head (82c32cf).

Files Patch % Lines
rustls/src/crypto/mod.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1839   +/-   ##
=======================================
  Coverage   95.82%   95.82%           
=======================================
  Files          84       84           
  Lines       18866    18866           
=======================================
  Hits        18078    18078           
  Misses        788      788

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented Mar 6, 2024 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8649100 8677552 28452 (0.33%) 0.89%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 4181496 4194279 12783 (0.31%) 0.71%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 4008447 4016214 7767 (0.19%) 3.90%
handshake_session_id_ring_1.2_rsa_aes_server 4323213 4331503 8290 (0.19%) 0.39%
handshake_tickets_ring_1.2_rsa_aes_client 4707210 4713915 6705 (0.14%) 0.81%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 12325559 12309078 -16481 (-0.13%) 0.94%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8655562 8666880 11318 (0.13%) 0.67%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 2128734 2126153 -2581 (-0.12%) 0.36%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 32458545 32495250 36705 (0.11%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 30274047 30306104 32057 (0.11%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 30456792 30429736 -27056 (-0.09%) 0.43%
handshake_tickets_ring_1.2_rsa_aes_server 4761479 4765633 4154 (0.09%) 0.29%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 30301838 30278993 -22845 (-0.08%) 0.48%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 12704784 12713557 8773 (0.07%) 0.88%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46287269 46256286 -30983 (-0.07%) 0.36%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 32434203 32455810 21607 (0.07%) 0.51%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 32444411 32424931 -19480 (-0.06%) 0.24%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 43443487 43469198 25711 (0.06%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 43711470 43688810 -22660 (-0.05%) 0.21%
handshake_session_id_ring_1.3_ecdsap384_aes_server 43541274 43563766 22492 (0.05%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 12670081 12676189 6108 (0.05%) 0.88%
handshake_tickets_ring_1.3_ecdsap256_aes_server 43749679 43770261 20582 (0.05%) 0.27%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 32474011 32458788 -15223 (-0.05%) 0.25%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 30255296 30241558 -13738 (-0.05%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 43426234 43444749 18515 (0.04%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92476159 92438478 -37681 (-0.04%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 42000101 42016218 16117 (0.04%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 2126453 2127261 808 (0.04%) 0.38%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1882728 1883440 712 (0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 32497857 32509776 11919 (0.04%) 0.51%
handshake_session_id_ring_1.3_rsa_aes_client 42199841 42184789 -15052 (-0.04%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4446225 4444648 -1577 (-0.04%) 0.72%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 30262050 30272579 10529 (0.03%) 0.36%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 32701926 32690557 -11369 (-0.03%) 0.39%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80411590 80439410 27820 (0.03%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 13734547 13729941 -4606 (-0.03%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 43732807 43747226 14419 (0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 32656171 32645734 -10437 (-0.03%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 43644576 43657948 13372 (0.03%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 30470072 30478262 8190 (0.03%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 43538125 43548858 10733 (0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4516215 4517309 1094 (0.02%) 0.82%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 32644818 32652685 7867 (0.02%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46265653 46254780 -10873 (-0.02%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46265436 46254718 -10718 (-0.02%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 41923188 41932163 8975 (0.02%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 42335131 42326479 -8652 (-0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 30451546 30445620 -5926 (-0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 32470291 32464076 -6215 (-0.02%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 42000284 41992348 -7936 (-0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1879025 1879374 349 (0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 4261793 4262525 732 (0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 30669167 30674000 4833 (0.02%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 42391165 42397132 5967 (0.01%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 42121504 42127352 5848 (0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80455561 80444675 -10886 (-0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35452685 35448031 -4654 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 4257506 4258060 554 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 30449464 30445541 -3923 (-0.01%) 0.28%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 41912921 41907998 -4923 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 3366285 3365917 -368 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3340669 3341011 342 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 30432504 30429400 -3104 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3344988 3345292 304 (0.01%) 0.25%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 30446631 30443974 -2657 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 30679802 30682372 2570 (0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46302706 46306577 3871 (0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 57967177 57963014 -4163 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58064594 58068678 4084 (0.01%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 43538243 43535482 -2761 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 32661443 32659430 -2013 (-0.01%) 0.26%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3897936 3897698 -238 (-0.01%) 0.22%
handshake_tickets_ring_1.3_ecdsap384_aes_client 42168092 42170647 2555 (0.01%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46167848 46170617 2769 (0.01%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 4538075 4537809 -266 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80353290 80357966 4676 (0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3897237 3897028 -209 (-0.01%) 0.33%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 13732877 13733596 719 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 3151814 3151667 -147 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 32650275 32651795 1520 (0.00%) 0.67%
handshake_tickets_ring_1.3_ecdsap256_aes_client 42174997 42176948 1951 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92397252 92401198 3946 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58062321 58064595 2274 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80355864 80358949 3085 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 57967799 57965828 -1971 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 4547148 4547301 153 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 42102838 42104096 1258 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92434877 92432199 -2678 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92397168 92399481 2313 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 43435868 43436927 1059 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 43647736 43648719 983 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 32637746 32637038 -708 (-0.00%) 0.24%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46293760 46292863 -897 (-0.00%) 0.22%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 4466669 4466585 -84 (-0.00%) 3.09%
handshake_no_resume_ring_1.3_rsa_aes_server 12237345 12237123 -222 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46207909 46208610 701 (0.00%) 0.29%
transfer_no_resume_ring_1.3_rsa_chacha_client 92397120 92398157 1037 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 12246619 12246503 -116 (-0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 4440599 4440633 34 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35450998 35450779 -219 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 68385966 68386328 362 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 57920315 57920010 -305 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 3355566 3355549 -17 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46300564 46300788 224 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92456036 92456461 425 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80343393 80343725 332 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 42103817 42103950 133 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 43805653 43805783 130 (0.00%) 0.21%
handshake_no_resume_ring_1.2_rsa_aes_server 12042443 12042409 -34 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58064434 58064597 163 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80455270 80455146 -124 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 57986210 57986248 38 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.80 ms 4.76 ms -0.04 ms (-0.84%) 3.52%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.75 ms 5.70 ms -0.05 ms (-0.78%) 3.48%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.52 ms 5.47 ms -0.04 ms (-0.76%) 3.36%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.64 ms 6.59 ms -0.05 ms (-0.74%) 3.44%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.75 ms 5.70 ms -0.04 ms (-0.73%) 2.96%
transfer_no_resume_ring_1.2_rsa_aes 7.13 ms 7.09 ms -0.03 ms (-0.48%) 2.74%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.75 ms 9.71 ms -0.04 ms (-0.43%) 2.44%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 476.97 µs 475.01 µs -1.96 µs (-0.41%) 2.61%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 475.89 µs 473.94 µs -1.95 µs (-0.41%) 2.37%
transfer_no_resume_ring_1.3_ecdsap256_chacha 13.31 ms 13.26 ms -0.05 ms (-0.39%) 1.55%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.30 ms 13.25 ms -0.05 ms (-0.35%) 1.37%
handshake_no_resume_ring_1.3_ecdsap256_chacha 506.03 µs 504.26 µs -1.77 µs (-0.35%) 2.05%
transfer_no_resume_ring_1.3_rsa_aes 7.21 ms 7.19 ms -0.02 ms (-0.32%) 2.40%
transfer_no_resume_ring_1.3_rsa_chacha 13.89 ms 13.84 ms -0.05 ms (-0.32%) 1.45%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 14.00 ms 13.96 ms -0.04 ms (-0.32%) 1.43%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.42 ms 16.37 ms -0.05 ms (-0.30%) 1.38%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.19 ms 1.19 ms -0.00 ms (-0.29%) 1.03%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 14.23 ms 14.19 ms -0.04 ms (-0.29%) 1.26%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.18 ms 1.18 ms -0.00 ms (-0.27%) 1.08%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 6.37 ms 6.36 ms -0.02 ms (-0.24%) 1.56%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.36 ms 1.36 ms -0.00 ms (-0.21%) 1.00%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 6.37 ms 6.35 ms -0.01 ms (-0.21%) 1.44%
handshake_no_resume_ring_1.3_ecdsap256_aes 507.93 µs 506.90 µs -1.03 µs (-0.20%) 2.10%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.41 ms 1.41 ms -0.00 ms (-0.19%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 6.10 ms 6.09 ms -0.01 ms (-0.19%) 1.56%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 5.38 ms 5.37 ms -0.01 ms (-0.17%) 1.93%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 6.07 ms 6.06 ms -0.01 ms (-0.17%) 1.59%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 6.08 ms 6.07 ms -0.01 ms (-0.17%) 1.52%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 5.37 ms 5.36 ms -0.01 ms (-0.16%) 1.60%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 6.38 ms 6.37 ms -0.01 ms (-0.15%) 1.38%
handshake_tickets_ring_1.3_ecdsap384_aes 10.01 ms 10.02 ms 0.01 ms (0.13%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.41 ms 1.41 ms -0.00 ms (-0.13%) 1.00%
handshake_session_id_ring_1.3_rsa_chacha 7.49 ms 7.48 ms -0.01 ms (-0.12%) 1.22%
handshake_session_id_ring_1.2_rsa_aes 1.76 ms 1.76 ms 0.00 ms (0.12%) 2.46%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 6.38 ms 6.38 ms -0.01 ms (-0.12%) 1.82%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 6.10 ms 6.09 ms -0.01 ms (-0.10%) 1.76%
handshake_tickets_ring_1.3_ecdsap256_aes 6.90 ms 6.90 ms 0.01 ms (0.10%) 1.53%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 5.38 ms 5.38 ms -0.00 ms (-0.09%) 1.90%
handshake_no_resume_ring_1.2_rsa_aes 1.07 ms 1.07 ms 0.00 ms (0.08%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 5.36 ms 5.36 ms -0.00 ms (-0.08%) 1.90%
handshake_session_id_ring_1.3_ecdsap256_aes 6.89 ms 6.90 ms 0.01 ms (0.08%) 1.47%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 2.17 ms 2.17 ms -0.00 ms (-0.08%) 1.69%
handshake_session_id_ring_1.3_ecdsap384_aes 10.00 ms 10.00 ms 0.01 ms (0.07%) 1.00%
handshake_tickets_ring_1.3_rsa_aes 7.54 ms 7.54 ms 0.01 ms (0.07%) 1.07%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.97 ms 9.98 ms 0.01 ms (0.06%) 1.04%
handshake_no_resume_ring_1.3_rsa_chacha 1.09 ms 1.08 ms -0.00 ms (-0.06%) 1.00%
handshake_tickets_ring_1.2_rsa_aes 1.84 ms 1.84 ms 0.00 ms (0.05%) 1.71%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.61 ms 3.61 ms 0.00 ms (0.04%) 1.18%
handshake_tickets_ring_1.3_rsa_chacha 7.50 ms 7.50 ms -0.00 ms (-0.03%) 1.06%
handshake_no_resume_ring_1.3_rsa_aes 1.08 ms 1.08 ms -0.00 ms (-0.03%) 1.00%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 2.34 ms 2.34 ms -0.00 ms (-0.03%) 1.73%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.96 ms 9.96 ms -0.00 ms (-0.03%) 1.33%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.61 ms 3.61 ms 0.00 ms (0.02%) 1.15%
handshake_session_id_ring_1.3_rsa_aes 7.53 ms 7.53 ms -0.00 ms (-0.02%) 1.10%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.85 ms 6.85 ms 0.00 ms (0.01%) 1.19%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.86 ms 6.86 ms 0.00 ms (0.01%) 1.42%

Additional information

Historical results

Checkout details:

@ctz ctz added this pull request to the merge queue Mar 6, 2024
Merged via the queue into main with commit e1eb447 Mar 6, 2024
45 of 46 checks passed
@ctz ctz deleted the jbp-new-nightly-warnings-1 branch March 6, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ctz @djc