Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix new nightly clippy lints #1842

Merged
merged 4 commits into from
Mar 11, 2024
Merged

Fix new nightly clippy lints #1842

merged 4 commits into from
Mar 11, 2024

Conversation

ctz
Copy link
Member

@ctz ctz commented Mar 11, 2024

One of these is a false positive that is being backed out upstream1.

Footnotes

  1. https://github.com/rust-lang/rust-clippy/issues/12438 ↩

ctz added 4 commits March 11, 2024 13:33
@ctz
Address clippy::assigning_clones
032ab04
@ctz
Address clippy::multiple_bound_locations
ac45f8d
@ctz
Address clippy::mixed_attributes_style
c5e26d7
@ctz
Avoid clippy::std_instead_of_core false positive
4bed31b 
This is complaining about the import of the `env` module from
`std::env`, instead of `core::env`.

However, `core::env` is a completely different item -- it is
the `env!` macro.
@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented Mar 11, 2024 •
edited

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 12631656 12674082 42426 (0.34%) 0.85%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 4024266 4037228 12962 (0.32%) 3.67%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 4478604 4490883 12279 (0.27%) 3.76%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 32762692 32680253 -82439 (-0.25%) 0.40%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 12664344 12695314 30970 (0.24%) 0.92%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 32520783 32454602 -66181 (-0.20%) 0.44%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 32500378 32437368 -63010 (-0.19%) 0.50%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 32714179 32656591 -57588 (-0.18%) 0.65%
handshake_tickets_ring_1.2_rsa_aes_client 4709548 4716889 7341 (0.16%) 0.75%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8674735 8663201 -11534 (-0.13%) 0.57%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46299866 46241115 -58751 (-0.13%) 0.30%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 2124318 2126977 2659 (0.13%) 0.39%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 12310156 12294929 -15227 (-0.12%) 0.82%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 2128799 2126289 -2510 (-0.12%) 0.35%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 32426403 32456551 30148 (0.09%) 0.25%
handshake_session_id_ring_1.2_rsa_aes_server 4328061 4324434 -3627 (-0.08%) 0.32%
handshake_session_id_ring_1.2_rsa_aes_client 4442408 4438730 -3678 (-0.08%) 0.64%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 32449277 32472218 22941 (0.07%) 0.26%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 4181519 4184203 2684 (0.06%) 0.62%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3899094 3896673 -2421 (-0.06%) 0.39%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3895659 3898056 2397 (0.06%) 0.22%
handshake_session_id_ring_1.3_rsa_chacha_client 42103631 42129125 25494 (0.06%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 32652665 32670882 18217 (0.06%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 30472602 30489109 16507 (0.05%) 0.36%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 32643290 32660680 17390 (0.05%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 57975886 58006180 30294 (0.05%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 43747533 43725944 -21589 (-0.05%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 32459755 32475474 15719 (0.05%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1882416 1883284 868 (0.05%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 30259565 30246069 -13496 (-0.04%) 0.37%
handshake_tickets_ring_1.3_rsa_chacha_client 42334350 42316192 -18158 (-0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 30254316 30267197 12881 (0.04%) 0.48%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 32656072 32642502 -13570 (-0.04%) 0.25%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 30661975 30673166 11191 (0.04%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 43747906 43762645 14739 (0.03%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46230768 46215635 -15133 (-0.03%) 0.28%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 32628241 32638760 10519 (0.03%) 0.24%
handshake_session_id_ring_1.3_rsa_aes_client 42191863 42204629 12766 (0.03%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 13730560 13734610 4050 (0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 30459900 30451794 -8106 (-0.03%) 0.28%
handshake_session_id_ring_1.3_rsa_aes_server 43532890 43543274 10384 (0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1879160 1879589 429 (0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4523613 4522612 -1001 (-0.02%) 0.78%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 43662307 43671667 9360 (0.02%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 43564970 43555755 -9215 (-0.02%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4763738 4762756 -982 (-0.02%) 0.31%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 30300326 30306479 6153 (0.02%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 43715464 43723945 8481 (0.02%) 0.21%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 4262729 4261910 -819 (-0.02%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 42391549 42383673 -7876 (-0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 30667738 30662210 -5528 (-0.02%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46167167 46175434 8267 (0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3345338 3344761 -577 (-0.02%) 0.27%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92448856 92434105 -14751 (-0.02%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 42172390 42165727 -6663 (-0.02%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 42009024 42002466 -6558 (-0.02%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 41925157 41919020 -6137 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 3365945 3366436 491 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 43440271 43434623 -5648 (-0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35447861 35452400 4539 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 32467699 32471739 4040 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 30455805 30452223 -3582 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58066256 58059653 -6603 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 30437508 30440961 3453 (0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80454810 80446012 -8798 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80355352 80346700 -8652 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 42097723 42102095 4372 (0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46295723 46300476 4753 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 30253731 30250625 -3106 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 43446690 43442702 -3988 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46306570 46302392 -4178 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58069248 58064229 -5019 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 42010205 42006823 -3382 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 30447036 30449455 2419 (0.01%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 4440134 4440470 336 (0.01%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 4537647 4537971 324 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 30487370 30485256 -2114 (-0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80454020 80459353 5333 (0.01%) 0.25%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3341032 3341217 185 (0.01%) 0.21%
handshake_session_id_ring_1.3_ecdsap256_aes_server 43536202 43538261 2059 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 43792953 43794988 2035 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 42170961 42172770 1809 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 42099530 42101164 1634 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 41933284 41931732 -1552 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 4257835 4257678 -157 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 3151678 3151567 -111 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 43664343 43665714 1371 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 4547233 4547373 140 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 12237260 12237027 -233 (-0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 12043031 12043225 194 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 13737553 13737761 208 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92433876 92435001 1125 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46290031 46290574 543 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 3355624 3355658 34 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92397082 92397770 688 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8654623 8654686 63 (0.00%) 0.72%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 57965951 57965539 -412 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 12246888 12246974 86 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58064697 58064294 -403 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 57985750 57986103 353 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92456458 92455950 -508 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80343033 80343451 418 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46255140 46255324 184 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 43438164 43438315 151 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46265035 46264877 -158 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 68386038 68386237 199 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80456069 80455854 -215 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92398150 92398390 240 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92397243 92397375 132 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35454877 35454903 26 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 57920519 57920534 15 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80355062 80355047 -15 (-0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.79 ms 4.73 ms -0.06 ms (-1.21%) 3.44%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.50 ms 5.44 ms -0.06 ms (-1.07%) 3.22%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.71 ms 5.66 ms -0.06 ms (-0.96%) 3.58%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.72 ms 5.67 ms -0.05 ms (-0.95%) 3.29%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 475.33 µs 470.95 µs -4.38 µs (-0.92%) 2.76%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.62 ms 6.56 ms -0.06 ms (-0.91%) 3.28%
transfer_no_resume_ring_1.3_rsa_aes 7.20 ms 7.13 ms -0.06 ms (-0.87%) 2.44%
transfer_no_resume_ring_1.2_rsa_aes 7.10 ms 7.04 ms -0.06 ms (-0.84%) 2.54%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 476.32 µs 472.45 µs -3.88 µs (-0.81%) 2.64%
handshake_no_resume_ring_1.3_ecdsap256_chacha 505.66 µs 501.83 µs -3.82 µs (-0.76%) 2.04%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 2.33 ms 2.32 ms -0.01 ms (-0.61%) 1.41%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.73 ms 9.67 ms -0.06 ms (-0.60%) 2.59%
handshake_session_id_ring_1.2_rsa_aes 1.75 ms 1.74 ms -0.01 ms (-0.59%) 2.38%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 5.37 ms 5.34 ms -0.03 ms (-0.54%) 1.72%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.28 ms 13.21 ms -0.07 ms (-0.50%) 1.28%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.86 ms 6.82 ms -0.03 ms (-0.49%) 1.01%
handshake_no_resume_ring_1.3_ecdsap256_aes 506.95 µs 504.53 µs -2.42 µs (-0.48%) 1.85%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.42 ms 1.41 ms -0.01 ms (-0.46%) 1.00%
handshake_tickets_ring_1.2_rsa_aes 1.84 ms 1.83 ms -0.01 ms (-0.45%) 1.56%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 6.06 ms 6.04 ms -0.03 ms (-0.45%) 1.61%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 6.36 ms 6.34 ms -0.03 ms (-0.44%) 1.43%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.18 ms 1.18 ms -0.01 ms (-0.44%) 1.08%
transfer_no_resume_ring_1.3_rsa_chacha 13.86 ms 13.80 ms -0.06 ms (-0.44%) 1.53%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.98 ms 13.92 ms -0.06 ms (-0.42%) 1.31%
transfer_no_resume_ring_1.3_ecdsap256_chacha 13.28 ms 13.22 ms -0.06 ms (-0.42%) 1.48%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 14.21 ms 14.15 ms -0.06 ms (-0.42%) 1.29%
handshake_session_id_ring_1.3_rsa_chacha 7.48 ms 7.45 ms -0.03 ms (-0.40%) 1.16%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 5.40 ms 5.37 ms -0.02 ms (-0.40%) 1.61%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.39 ms 16.33 ms -0.06 ms (-0.38%) 1.19%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 2.16 ms 2.15 ms -0.01 ms (-0.38%) 1.69%
handshake_tickets_ring_1.3_rsa_chacha 7.50 ms 7.47 ms -0.03 ms (-0.36%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.19 ms 1.18 ms -0.00 ms (-0.35%) 1.03%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.41 ms 1.40 ms -0.00 ms (-0.34%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.86 ms 6.84 ms -0.02 ms (-0.32%) 1.17%
handshake_session_id_ring_1.3_ecdsap256_aes 6.89 ms 6.87 ms -0.02 ms (-0.30%) 1.02%
handshake_no_resume_ring_1.3_rsa_aes 1.08 ms 1.08 ms -0.00 ms (-0.29%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 6.10 ms 6.08 ms -0.02 ms (-0.29%) 1.69%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 6.39 ms 6.37 ms -0.02 ms (-0.26%) 1.74%
handshake_no_resume_ring_1.3_rsa_chacha 1.09 ms 1.08 ms -0.00 ms (-0.24%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 5.37 ms 5.36 ms -0.01 ms (-0.24%) 1.51%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.95 ms 9.93 ms -0.02 ms (-0.24%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.97 ms 9.95 ms -0.02 ms (-0.23%) 1.11%
handshake_session_id_ring_1.3_rsa_aes 7.53 ms 7.51 ms -0.02 ms (-0.23%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 6.08 ms 6.07 ms -0.01 ms (-0.17%) 1.44%
handshake_no_resume_ring_1.2_rsa_aes 1.07 ms 1.07 ms -0.00 ms (-0.17%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_aes 9.99 ms 9.97 ms -0.02 ms (-0.16%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.61 ms 3.61 ms -0.00 ms (-0.13%) 1.00%
handshake_tickets_ring_1.3_rsa_aes 7.54 ms 7.53 ms -0.01 ms (-0.12%) 1.00%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 6.37 ms 6.36 ms -0.01 ms (-0.11%) 1.50%
handshake_tickets_ring_1.3_ecdsap384_aes 10.01 ms 10.00 ms -0.01 ms (-0.10%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.61 ms 3.61 ms -0.00 ms (-0.10%) 1.02%
handshake_tickets_ring_1.3_ecdsap256_aes 6.90 ms 6.89 ms -0.01 ms (-0.09%) 1.00%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.36 ms 1.36 ms -0.00 ms (-0.08%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 5.39 ms 5.39 ms 0.00 ms (0.04%) 1.86%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 6.10 ms 6.10 ms 0.00 ms (0.03%) 1.28%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 6.38 ms 6.38 ms 0.00 ms (0.02%) 1.18%

Additional information

Historical results

Checkout details:

@codecov Codecov
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.82%. Comparing base (85fdfd4) to head (4bed31b).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1842      +/-   ##
==========================================
- Coverage   95.82%   95.82%   -0.01%     
==========================================
  Files          84       84              
  Lines       18866    18865       -1     
==========================================
- Hits        18078    18077       -1     
  Misses        788      788

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cpu
cpu approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ctz ctz added this pull request to the merge queue Mar 11, 2024
Merged via the queue into main with commit 52efdc9 Mar 11, 2024
46 checks passed
@ctz ctz deleted the jbp-nightly-clippy-4 branch March 11, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@cpu cpu cpu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ctz @djc @cpu