Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare 0.23.2 #1846

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Prepare 0.23.2 #1846

merged 2 commits into from
Mar 13, 2024

Conversation

ctz
Copy link
Member

@ctz ctz commented Mar 13, 2024 •
edited

Release notes

  • Bug fix: return correct ConnectionTrafficSecrets variant from dangerous_extract_secrets() when AES-256-GCM is negotiated.
  • New feature: groundwork for supporting post-quantum key exchange. Experimental support for X25519Kyber768Draft00 will be released as a separate crate: rustls-post-quantum.
  • Add aws-lc-rs crate feature as alias for aws_lc_rs crate feature.

@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented Mar 13, 2024 •
edited

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3991929 4059529 67600 (1.69%) 3.88%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 4452271 4509931 57660 (1.30%) 3.96%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8679958 8646714 -33244 (-0.38%) 0.64%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8690998 8663171 -27827 (-0.32%) 0.86%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 12333096 12300414 -32682 (-0.26%) 0.96%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 30215506 30283262 67756 (0.22%) 0.41%
handshake_tickets_ring_1.2_rsa_aes_server 4775403 4766794 -8609 (-0.18%) 0.35%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 12677981 12695404 17423 (0.14%) 0.88%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 30226237 30266341 40104 (0.13%) 0.49%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 4179607 4174117 -5490 (-0.13%) 0.69%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 32666436 32709030 42594 (0.13%) 0.74%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 12684572 12669019 -15553 (-0.12%) 0.92%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 2128702 2126297 -2405 (-0.11%) 0.35%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46290056 46242503 -47553 (-0.10%) 0.42%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 32413612 32445676 32064 (0.10%) 0.51%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3338228 3341158 2930 (0.09%) 0.21%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 32470056 32441732 -28324 (-0.09%) 0.25%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 32671342 32699156 27814 (0.09%) 0.36%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 32507867 32481117 -26750 (-0.08%) 0.49%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 32653254 32628950 -24304 (-0.07%) 0.26%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 32452991 32430890 -22101 (-0.07%) 0.26%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46184497 46214926 30429 (0.07%) 0.28%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3899315 3896779 -2536 (-0.07%) 0.39%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 30431873 30449011 17138 (0.06%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 30265737 30282775 17038 (0.06%) 0.22%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 30234052 30217565 -16487 (-0.05%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 43726801 43704701 -22100 (-0.05%) 0.22%
handshake_tickets_ring_1.3_ecdsap384_aes_server 43758759 43737127 -21632 (-0.05%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 32477368 32461963 -15405 (-0.05%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3343031 3344589 1558 (0.05%) 0.27%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 30628393 30642193 13800 (0.05%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4326434 4328278 1844 (0.04%) 0.32%
handshake_tickets_ring_1.3_rsa_chacha_client 42285506 42303002 17496 (0.04%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 32654459 32643399 -11060 (-0.03%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 41981762 41967827 -13935 (-0.03%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92427122 92456822 29700 (0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4517421 4518838 1417 (0.03%) 0.75%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 30416482 30425796 9314 (0.03%) 0.40%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 43666709 43653577 -13132 (-0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 32640128 32630417 -9711 (-0.03%) 0.24%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 13733844 13737863 4019 (0.03%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 42083293 42094751 11458 (0.03%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1882626 1883093 467 (0.02%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 42383119 42372958 -10161 (-0.02%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 43456268 43446412 -9856 (-0.02%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 43537677 43547029 9352 (0.02%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 42116345 42107365 -8980 (-0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1879434 1879829 395 (0.02%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80426895 80443261 16366 (0.02%) 0.25%
handshake_session_id_ring_1.2_rsa_aes_client 4431867 4432763 896 (0.02%) 0.63%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 57943488 57955025 11537 (0.02%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46292605 46301720 9115 (0.02%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 43452246 43443733 -8513 (-0.02%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 43550295 43542473 -7822 (-0.02%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 43784260 43776490 -7770 (-0.02%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 43446807 43454427 7620 (0.02%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 43653222 43660768 7546 (0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 30442292 30447519 5227 (0.02%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46255034 46261582 6548 (0.01%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80353455 80342644 -10811 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 43554002 43548206 -5796 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 32659656 32655459 -4197 (-0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80454512 80444811 -9701 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 42152311 42157388 5077 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 41909558 41904751 -4807 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 42077320 42082080 4760 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 30442164 30438755 -3409 (-0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35450955 35454806 3851 (0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80346519 80354705 8186 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 43753225 43757473 4248 (0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 57968470 57962920 -5550 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 4257747 4258083 336 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 32471647 32469167 -2480 (-0.01%) 0.22%
handshake_no_resume_ring_1.2_rsa_aes_client 4440730 4440421 -309 (-0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3897668 3897456 -212 (-0.01%) 0.22%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 41891385 41893623 2238 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 3151897 3151730 -167 (-0.01%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 4538110 4538348 238 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 42142406 42144546 2140 (0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92400329 92396462 -3867 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 2126926 2126840 -86 (-0.00%) 0.38%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 30412246 30411030 -1216 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 4262285 4262441 156 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 41985640 41984287 -1353 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 3366373 3366454 81 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 12043283 12043004 -279 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58064236 58063261 -975 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 12238493 12238694 201 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80455757 80454807 -950 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 12247443 12247302 -141 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 13734553 13734710 157 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46175646 46176138 492 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 3355969 3355937 -32 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92397995 92397134 -861 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 68385957 68385380 -577 (-0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4700791 4700753 -38 (-0.00%) 0.77%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 57985101 57985530 429 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58063480 58063876 396 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 4547424 4547455 31 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46264755 46264461 -294 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46301768 46301488 -280 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 57919672 57920009 337 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92433621 92434120 499 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 42185499 42185707 208 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 30662735 30662861 126 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92396651 92396285 -366 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58063735 58063939 204 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35452575 35452458 -117 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46289326 46289209 -117 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92455451 92455653 202 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 30420781 30420733 -48 (-0.00%) 0.30%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80346429 80346385 -44 (-0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.80 ms 4.74 ms -0.06 ms (-1.18%) 4.56%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.51 ms 5.45 ms -0.06 ms (-1.05%) 3.85%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.74 ms 5.68 ms -0.06 ms (-1.03%) 3.69%
transfer_no_resume_ring_1.3_rsa_aes 7.21 ms 7.16 ms -0.06 ms (-0.77%) 2.47%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.71 ms 5.67 ms -0.04 ms (-0.75%) 3.61%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.62 ms 6.58 ms -0.04 ms (-0.66%) 3.44%
transfer_no_resume_ring_1.2_rsa_aes 7.10 ms 7.05 ms -0.05 ms (-0.65%) 2.63%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 475.07 µs 472.08 µs -2.99 µs (-0.63%) 2.90%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.74 ms 9.68 ms -0.05 ms (-0.52%) 2.66%
handshake_no_resume_ring_1.3_ecdsap256_chacha 506.15 µs 503.68 µs -2.47 µs (-0.49%) 2.12%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 475.86 µs 473.64 µs -2.22 µs (-0.47%) 2.61%
handshake_tickets_ring_1.2_rsa_aes 1.85 ms 1.84 ms -0.01 ms (-0.43%) 1.69%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.98 ms 13.93 ms -0.06 ms (-0.40%) 1.40%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.28 ms 13.23 ms -0.05 ms (-0.39%) 1.37%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 5.37 ms 5.35 ms -0.02 ms (-0.37%) 1.83%
transfer_no_resume_ring_1.3_ecdsap256_chacha 13.28 ms 13.24 ms -0.05 ms (-0.35%) 1.62%
handshake_no_resume_ring_1.3_ecdsap256_aes 507.20 µs 505.49 µs -1.71 µs (-0.34%) 1.85%
transfer_no_resume_ring_1.3_rsa_chacha 13.87 ms 13.82 ms -0.05 ms (-0.33%) 1.53%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 14.21 ms 14.17 ms -0.04 ms (-0.31%) 1.33%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 6.37 ms 6.35 ms -0.02 ms (-0.30%) 1.45%
handshake_no_resume_ring_1.3_rsa_chacha 1.09 ms 1.08 ms -0.00 ms (-0.29%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 6.07 ms 6.05 ms -0.02 ms (-0.28%) 1.68%
handshake_no_resume_ring_1.3_rsa_aes 1.08 ms 1.08 ms -0.00 ms (-0.28%) 1.00%
handshake_session_id_ring_1.2_rsa_aes 1.75 ms 1.74 ms -0.00 ms (-0.27%) 2.33%
handshake_no_resume_ring_1.2_rsa_aes 1.07 ms 1.07 ms -0.00 ms (-0.27%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.18 ms 1.18 ms -0.00 ms (-0.24%) 1.17%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 5.41 ms 5.40 ms -0.01 ms (-0.23%) 1.66%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 2.18 ms 2.17 ms -0.00 ms (-0.22%) 1.83%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.39 ms 16.36 ms -0.03 ms (-0.21%) 1.19%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 5.38 ms 5.37 ms -0.01 ms (-0.20%) 1.57%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.41 ms 1.40 ms -0.00 ms (-0.20%) 1.00%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 6.40 ms 6.39 ms -0.01 ms (-0.19%) 1.79%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.61 ms 3.62 ms 0.01 ms (0.19%) 1.09%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.61 ms 3.62 ms 0.01 ms (0.18%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.87 ms 6.86 ms -0.01 ms (-0.16%) 1.18%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 6.12 ms 6.11 ms -0.01 ms (-0.16%) 1.69%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 6.09 ms 6.08 ms -0.01 ms (-0.16%) 1.48%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 2.34 ms 2.34 ms -0.00 ms (-0.15%) 1.73%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 6.38 ms 6.37 ms -0.01 ms (-0.13%) 1.51%
handshake_tickets_ring_1.3_rsa_chacha 7.50 ms 7.49 ms -0.01 ms (-0.13%) 1.02%
handshake_session_id_ring_1.3_ecdsap256_aes 6.89 ms 6.88 ms -0.01 ms (-0.13%) 1.11%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.86 ms 6.85 ms -0.01 ms (-0.12%) 1.15%
handshake_session_id_ring_1.3_rsa_aes 7.53 ms 7.52 ms -0.01 ms (-0.10%) 1.00%
handshake_session_id_ring_1.3_rsa_chacha 7.49 ms 7.48 ms -0.01 ms (-0.09%) 1.30%
handshake_tickets_ring_1.3_ecdsap256_aes 6.91 ms 6.90 ms -0.01 ms (-0.09%) 1.08%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.36 ms 1.36 ms -0.00 ms (-0.08%) 1.00%
handshake_tickets_ring_1.3_rsa_aes 7.54 ms 7.54 ms -0.00 ms (-0.06%) 1.08%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.41 ms 1.41 ms -0.00 ms (-0.04%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.98 ms 9.98 ms -0.00 ms (-0.04%) 1.12%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.18 ms 1.18 ms 0.00 ms (0.04%) 1.04%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.97 ms 9.96 ms -0.00 ms (-0.04%) 1.00%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 6.39 ms 6.39 ms -0.00 ms (-0.03%) 1.13%
handshake_tickets_ring_1.3_ecdsap384_aes 10.02 ms 10.02 ms 0.00 ms (0.03%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 6.11 ms 6.11 ms -0.00 ms (-0.02%) 1.46%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 5.40 ms 5.40 ms 0.00 ms (0.02%) 1.89%
handshake_session_id_ring_1.3_ecdsap384_aes 9.99 ms 9.99 ms 0.00 ms (0.00%) 1.00%

Additional information

Historical results

Checkout details:

@codecov Codecov
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.26%. Comparing base (62e154c) to head (1769640).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1846   +/-   ##
=======================================
  Coverage   95.26%   95.26%           
=======================================
  Files          85       85           
  Lines       18960    18960           
=======================================
  Hits        18063    18063           
  Misses        897      897

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cpu
Copy link
Member

cpu commented Mar 13, 2024

New feature: groundwork for supporting post-quantum key exchange.

This feels a little bit terse. I was thinking it might be useful to mention:

  • It's X25519Kyber768Draft00 based
  • It's in a separate crate for now (and maybe a quick mention of why)
  • There's an example program based on simpleclient.rs to crib from

WDYT?

cpu
cpu reviewed Mar 13, 2024
View reviewed changes
README.md Show resolved Hide resolved
@ctz
Copy link
Member Author

ctz commented Mar 13, 2024

This feels a little bit terse.

Ah, I was just really thinking of the changes to the core crate. Expanded.

@cpu
Copy link
Member

cpu commented Mar 13, 2024

Ah, I was just really thinking of the changes to the core crate. Expanded.

Ahhh ok, that makes sense 👍 The updated language looks good to me.

@ctz ctz added this pull request to the merge queue Mar 13, 2024
Merged via the queue into main with commit bbef4b3 Mar 13, 2024
48 checks passed
@ctz ctz deleted the jbp-prepare-0.23.2 branch March 13, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpu cpu cpu approved these changes

@djc djc djc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ctz @cpu @djc