small no-std CI tweaks #1848
Merged
small no-std CI tweaks #1848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It uses `--no-default-features` but the name described using default features.
cpu
force-pushed
the
cpu-no-std-ci-tweaks
branch
from
8833adb
to
0c8d6c5
Compare
Previously the `std` feature was in the explicit rustls dependency feature list, and not opted-in by the provider's own `std` feature. I believe this means when building the provider with `--no-default-features` we were still using Rustls w/ the `std` feature.
cpu
force-pushed
the
cpu-no-std-ci-tweaks
branch
from
0c8d6c5
to
4f3913e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1848 +/- ##
=======================================
Coverage 95.26% 95.26%
=======================================
Files 85 85
Lines 18960 18960
=======================================
Hits 18063 18063
Misses 897 897 ☔ View full report in Codecov by Sentry. |
ctz
approved these changes
Mar 13, 2024
Benchmark resultsInstruction countsSignificant differencesThere are no significant instruction count differences Other differencesClick to expand
Wall-timeSignificant differencesThere are no significant wall-time differences Other differencesClick to expand
Additional informationCheckout details:
|
djc
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a couple of small things I noticed picking at the no-std work with fresh eyes.
It uses
--no-default-featuresbut the name described using default features.Previously the
stdfeature was in the explicit rustls dependency feature list, and not opted-in by the provider's ownstdfeature.I believe this means when building the provider with
--no-default-featureswe were still using Rustls w/ thestdfeature.