Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ffdhe no common cipher suite bug #1861

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Fix ffdhe no common cipher suite bug #1861

merged 1 commit into from
Mar 20, 2024

Conversation

Taowyoo
Copy link
Contributor

@Taowyoo Taowyoo commented Mar 20, 2024

Background

See:

Solution

  • Fix the bug that when both FFDHE and DHE ciphersuites are available on client and server, no ciphersuite is choose.
  • Add missing test cases.

This PR fixs #1860

@Taowyoo
fix: ffdhe no common cipher suite bug
4b034b0 
- Fix the bug that when both FFDHE and DHE ciphersuites are available on
  client and server, no ciphersuite is choose.
- Add missing test cases.
@Taowyoo Taowyoo mentioned this pull request Mar 20, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.26%. Comparing base (fb67f01) to head (4b034b0).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1861   +/-   ##
=======================================
  Coverage   95.26%   95.26%           
=======================================
  Files          85       85           
  Lines       18960    18960           
=======================================
  Hits        18063    18063           
  Misses        897      897

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented Mar 20, 2024 •
edited

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3936872 3872617 -64255 (-1.63%) 3.21%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 4344226 4359515 15289 (0.35%) 3.10%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8678182 8702723 24541 (0.28%) 0.66%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8699206 8677842 -21364 (-0.25%) 0.86%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 12299278 12320173 20895 (0.17%) 0.68%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 12655300 12676619 21319 (0.17%) 0.86%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 32587982 32550669 -37313 (-0.11%) 0.67%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 2136122 2133708 -2414 (-0.11%) 0.38%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 2137968 2135610 -2358 (-0.11%) 0.37%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 30095207 30127165 31958 (0.11%) 0.48%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 30310556 30283724 -26832 (-0.09%) 0.32%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46456002 46425918 -30084 (-0.06%) 0.29%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 30293483 30312784 19301 (0.06%) 0.43%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46393499 46364013 -29486 (-0.06%) 0.33%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3922049 3919682 -2367 (-0.06%) 0.24%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 32338963 32320886 -18077 (-0.06%) 0.60%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3365659 3363835 -1824 (-0.05%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3920252 3918157 -2095 (-0.05%) 0.24%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 30094169 30078601 -15568 (-0.05%) 0.40%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 32637150 32621912 -15238 (-0.05%) 0.37%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 12689786 12694973 5187 (0.04%) 0.86%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 13746733 13742076 -4657 (-0.03%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 32387040 32376849 -10191 (-0.03%) 0.49%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92695548 92676058 -19490 (-0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 3174507 3173943 -564 (-0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 30294903 30299648 4745 (0.02%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4245449 4246078 629 (0.01%) 0.60%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4288610 4289234 624 (0.01%) 0.95%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 3389934 3389482 -452 (-0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35477749 35473387 -4362 (-0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58216487 58209434 -7053 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 43413478 43408574 -4904 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 43620866 43625383 4517 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 41841360 41845689 4329 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 4271441 4271018 -423 (-0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80630787 80638763 7976 (0.01%) 0.30%
handshake_tickets_ring_1.3_ecdsap256_aes_server 43691465 43695586 4121 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 41846421 41842745 -3676 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 41967114 41970501 3387 (0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58216787 58221423 4636 (0.01%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4666496 4666141 -355 (-0.01%) 0.32%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1889034 1888893 -141 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3368399 3368148 -251 (-0.01%) 0.24%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1892701 1892565 -136 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 42030455 42033444 2989 (0.01%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 4566739 4566422 -317 (-0.01%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 4459450 4459164 -286 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 4267022 4266755 -267 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 41763197 41760607 -2590 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 30285803 30284019 -1784 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3970485 3970718 233 (0.01%) 0.66%
handshake_session_id_ring_1.3_ecdsap256_aes_server 43413042 43415403 2361 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 41962552 41964811 2259 (0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46454555 46456739 2184 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4514059 4513848 -211 (-0.00%) 0.73%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 30085075 30083728 -1347 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 32579812 32578381 -1431 (-0.00%) 0.23%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 32305588 32304375 -1213 (-0.00%) 0.26%
handshake_session_id_ring_1.2_rsa_aes_server 4240567 4240408 -159 (-0.00%) 0.32%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 3379184 3379059 -125 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 43622142 43623641 1499 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 42035135 42033747 -1388 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 32579616 32578617 -999 (-0.00%) 0.26%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58319610 58321398 1788 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 30099519 30100410 891 (0.00%) 0.22%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 32592228 32591279 -949 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 32333644 32332826 -818 (-0.00%) 0.23%
handshake_tickets_ring_1.3_rsa_chacha_server 43619536 43618503 -1033 (-0.00%) 0.22%
handshake_session_id_ring_1.3_rsa_aes_client 41893444 41894423 979 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 32592175 32591512 -663 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 43693528 43692651 -877 (-0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 43691018 43690187 -831 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92651997 92653753 1756 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 41766916 41766144 -772 (-0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 12049647 12049429 -218 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 12252591 12252375 -216 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 30145736 30145254 -482 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 32334019 32333503 -516 (-0.00%) 0.21%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80508601 80509859 1258 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 30131590 30132008 418 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58320107 58319357 -750 (-0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 42019945 42020485 540 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35475549 35475096 -453 (-0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 41814070 41813588 -482 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 4557188 4557136 -52 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46458460 46457970 -490 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92687805 92688620 815 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 12243256 12243150 -106 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92689500 92690301 801 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 13743565 13743450 -115 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46458022 46457703 -319 (-0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 43408955 43408665 -290 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 30332582 30332387 -195 (-0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 43312159 43311911 -248 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 43315367 43315156 -211 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 30346289 30346427 138 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 42088930 42088760 -170 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80608805 80608483 -322 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58221730 58221551 -179 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46418505 46418623 118 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46338339 46338227 -112 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 43315368 43315279 -89 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 68641831 68641971 140 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58202154 58202036 -118 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80511108 80511020 -88 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58316063 58316116 53 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80610584 80610518 -66 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80511385 80511447 62 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 32305117 32305135 18 (0.00%) 0.25%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46420136 46420161 25 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92648354 92648400 46 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92652233 92652265 32 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.55 ms 4.43 ms -0.12 ms (-2.73%) 4.48%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.28 ms 5.15 ms -0.13 ms (-2.39%) 3.57%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.50 ms 5.38 ms -0.13 ms (-2.34%) 3.76%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.50 ms 5.37 ms -0.13 ms (-2.31%) 3.63%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.40 ms 6.28 ms -0.12 ms (-1.84%) 3.27%
transfer_no_resume_ring_1.3_rsa_aes 6.98 ms 6.86 ms -0.12 ms (-1.74%) 2.64%
transfer_no_resume_ring_1.2_rsa_aes 6.90 ms 6.78 ms -0.12 ms (-1.71%) 2.94%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 479.30 µs 471.71 µs -7.59 µs (-1.58%) 2.37%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 478.44 µs 471.04 µs -7.40 µs (-1.55%) 2.70%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.51 ms 9.39 ms -0.12 ms (-1.25%) 2.40%
handshake_no_resume_ring_1.3_ecdsap256_aes 509.62 µs 503.57 µs -6.05 µs (-1.19%) 1.70%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.04 ms 12.91 ms -0.13 ms (-0.97%) 1.54%
handshake_no_resume_ring_1.3_ecdsap256_chacha 507.07 µs 502.19 µs -4.89 µs (-0.96%) 2.01%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.75 ms 13.63 ms -0.13 ms (-0.93%) 1.56%
transfer_no_resume_ring_1.3_ecdsap256_chacha 13.05 ms 12.93 ms -0.12 ms (-0.91%) 1.49%
transfer_no_resume_ring_1.3_rsa_chacha 13.63 ms 13.51 ms -0.12 ms (-0.90%) 1.47%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.98 ms 13.86 ms -0.12 ms (-0.88%) 1.47%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.15 ms 16.03 ms -0.12 ms (-0.74%) 1.31%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 2.06 ms 2.07 ms 0.01 ms (0.55%) 1.78%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.19 ms 1.18 ms -0.01 ms (-0.54%) 1.02%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.18 ms 1.18 ms -0.01 ms (-0.52%) 1.04%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.70 ms 6.74 ms 0.03 ms (0.51%) 1.16%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.41 ms 1.40 ms -0.01 ms (-0.50%) 1.00%
handshake_no_resume_ring_1.3_rsa_chacha 1.10 ms 1.09 ms -0.01 ms (-0.50%) 1.00%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 6.24 ms 6.21 ms -0.03 ms (-0.48%) 1.33%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 5.28 ms 5.25 ms -0.02 ms (-0.47%) 1.63%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.42 ms 1.41 ms -0.01 ms (-0.46%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 5.99 ms 5.96 ms -0.03 ms (-0.45%) 1.45%
handshake_no_resume_ring_1.3_rsa_aes 1.10 ms 1.09 ms -0.00 ms (-0.45%) 1.00%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.36 ms 1.36 ms -0.01 ms (-0.45%) 1.00%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 6.25 ms 6.23 ms -0.03 ms (-0.43%) 1.74%
handshake_no_resume_ring_1.2_rsa_aes 1.07 ms 1.07 ms -0.00 ms (-0.40%) 1.00%
handshake_session_id_ring_1.3_rsa_chacha 7.30 ms 7.33 ms 0.03 ms (0.40%) 1.15%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 5.28 ms 5.26 ms -0.02 ms (-0.40%) 1.66%
handshake_session_id_ring_1.3_ecdsap256_aes 6.74 ms 6.76 ms 0.03 ms (0.40%) 1.14%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 5.99 ms 5.97 ms -0.02 ms (-0.38%) 1.61%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.80 ms 9.83 ms 0.04 ms (0.37%) 1.00%
handshake_session_id_ring_1.3_rsa_aes 7.35 ms 7.37 ms 0.03 ms (0.37%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.72 ms 6.75 ms 0.02 ms (0.34%) 1.24%
handshake_tickets_ring_1.3_ecdsap256_aes 6.76 ms 6.78 ms 0.02 ms (0.29%) 1.04%
handshake_session_id_ring_1.3_ecdsap384_aes 9.83 ms 9.86 ms 0.03 ms (0.27%) 1.00%
handshake_tickets_ring_1.3_rsa_chacha 7.33 ms 7.35 ms 0.02 ms (0.25%) 1.04%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.82 ms 9.85 ms 0.02 ms (0.24%) 1.00%
handshake_tickets_ring_1.3_rsa_aes 7.37 ms 7.38 ms 0.02 ms (0.23%) 1.07%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 2.23 ms 2.23 ms 0.00 ms (0.22%) 1.81%
handshake_tickets_ring_1.3_ecdsap384_aes 9.86 ms 9.88 ms 0.02 ms (0.22%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 5.26 ms 5.25 ms -0.01 ms (-0.20%) 1.57%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.61 ms 3.61 ms -0.01 ms (-0.15%) 1.00%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 6.22 ms 6.22 ms -0.01 ms (-0.14%) 1.66%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 6.23 ms 6.22 ms -0.01 ms (-0.13%) 1.53%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.61 ms 3.61 ms -0.00 ms (-0.13%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 5.97 ms 5.97 ms -0.01 ms (-0.13%) 1.48%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 5.95 ms 5.95 ms -0.00 ms (-0.01%) 1.58%
handshake_session_id_ring_1.2_rsa_aes 1.66 ms 1.66 ms 0.00 ms (0.01%) 2.33%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 5.25 ms 5.25 ms -0.00 ms (-0.00%) 1.90%
handshake_tickets_ring_1.2_rsa_aes 1.74 ms 1.74 ms 0.00 ms (0.00%) 1.57%

Additional information

Historical results

Checkout details:

cpu
cpu approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing/fixing. This seems sensible to me 👍

ctz
ctz approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@ctz ctz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! And sorry for the regression!

@ctz ctz added this pull request to the merge queue Mar 20, 2024
@djc
Copy link
Member

djc commented Mar 20, 2024

Maybe time to release 0.23.3?

Merged via the queue into rustls:main with commit a3d21f2 Mar 20, 2024
25 checks passed
@Taowyoo Taowyoo deleted the yx/fix-ffdhe-bug branch March 20, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@cpu cpu cpu approved these changes

@ctz ctz ctz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Taowyoo @djc @cpu @ctz