Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add path for rustls-post-quantum -> rustls dependency #1865

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Add path for rustls-post-quantum -> rustls dependency #1865

merged 1 commit into from
Mar 21, 2024

Conversation

ctz
Copy link
Member

@ctz ctz commented Mar 21, 2024

This avoids our Cargo.lock containing a previous version of this crate, and means a local cargo build is sufficient to check rustls-post-quantum/ builds against the current rustls/.

@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented Mar 21, 2024 •
edited

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3950754 3934062 -16692 (-0.42%) 3.54%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 4403170 4416866 13696 (0.31%) 2.88%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 12687680 12651836 -35844 (-0.28%) 0.86%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 32567673 32649456 81783 (0.25%) 0.40%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 32334248 32394478 60230 (0.19%) 0.57%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3365228 3361155 -4073 (-0.12%) 0.21%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46430077 46482475 52398 (0.11%) 0.39%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 32571950 32607485 35535 (0.11%) 0.65%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 30320577 30294882 -25695 (-0.08%) 0.42%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 12293573 12303751 10178 (0.08%) 0.65%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46421538 46387867 -33671 (-0.07%) 0.31%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3920343 3922408 2065 (0.05%) 0.24%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 12682461 12688537 6076 (0.05%) 0.89%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 30115539 30129499 13960 (0.05%) 0.43%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8689464 8685774 -3690 (-0.04%) 0.86%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8677097 8673513 -3584 (-0.04%) 0.69%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 32291275 32304315 13040 (0.04%) 0.60%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3367774 3366497 -1277 (-0.04%) 0.24%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 30305365 30294671 -10694 (-0.04%) 0.33%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58238062 58223401 -14661 (-0.03%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80605231 80624401 19170 (0.02%) 0.30%
handshake_session_id_ring_1.2_rsa_aes_client 4245706 4246666 960 (0.02%) 0.56%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4288477 4289356 879 (0.02%) 0.98%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 30294935 30301083 6148 (0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 30103368 30108604 5236 (0.02%) 0.41%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 2138370 2138033 -337 (-0.02%) 0.37%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 3174654 3174181 -473 (-0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92693377 92704670 11293 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 43310145 43315340 5195 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 43693399 43688264 -5135 (-0.01%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4240092 4240576 484 (0.01%) 0.29%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 43616544 43620958 4414 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 41762356 41766472 4116 (0.01%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4513527 4513127 -400 (-0.01%) 0.75%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 41765165 41761741 -3424 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 41962867 41966144 3277 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 42034131 42030927 -3204 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46454267 46457737 3470 (0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58311944 58316272 4328 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 43413629 43410416 -3213 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58318868 58314754 -4114 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 43617947 43620888 2941 (0.01%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 4459817 4459539 -278 (-0.01%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 4566744 4566472 -272 (-0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58217404 58220794 3390 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 41842284 41840039 -2245 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46454782 46452463 -2319 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 12252649 12253217 568 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 4557521 4557316 -205 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 2136013 2136105 92 (0.00%) 0.38%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1892698 1892777 79 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 4271422 4271249 -173 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 32591898 32590590 -1308 (-0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 12049826 12049371 -455 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 4266885 4267031 146 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80505137 80507761 2624 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4665746 4665895 149 (0.00%) 0.29%
handshake_session_id_ring_1.3_rsa_chacha_server 43311742 43310642 -1100 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 41961750 41962795 1045 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 30286863 30286116 -747 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 30346495 30345748 -747 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 12243675 12243376 -299 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3920689 3920596 -93 (-0.00%) 0.23%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1889141 1889100 -41 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 13743654 13743934 280 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 32304722 32304119 -603 (-0.00%) 0.27%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 3379178 3379118 -60 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 32590714 32591195 481 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 32579105 32578628 -477 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 42031411 42030837 -574 (-0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 43617682 43618271 589 (0.00%) 0.23%
transfer_no_resume_ring_1.2_rsa_aes_server 46338293 46338901 608 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 30146482 30146121 -361 (-0.00%) 0.21%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 68641471 68642277 806 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46420622 46420085 -537 (-0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 43409170 43408682 -488 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46457295 46457749 454 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 43692409 43692826 417 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 32333090 32332785 -305 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80511039 80510283 -756 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 41847293 41846903 -390 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 43412641 43413045 404 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 43690016 43690409 393 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 30099005 30098746 -259 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 30085974 30086232 258 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 43315372 43315007 -365 (-0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 41894587 41894923 336 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92688794 92689522 728 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 42088743 42089041 298 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35477856 35477609 -247 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 30333311 30333100 -211 (-0.00%) 0.22%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35475368 35475126 -242 (-0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 42020228 42020493 265 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46418270 46418550 280 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58221997 58221647 -350 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58202016 58202300 284 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80608690 80608304 -386 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 30131931 30132072 141 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3970686 3970704 18 (0.00%) 0.67%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 32304897 32304770 -127 (-0.00%) 0.23%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80507267 80506953 -314 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92652335 92652672 337 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80610383 80610591 208 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 32333504 32333431 -73 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92690126 92689943 -183 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58319536 58319634 98 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92644106 92644259 153 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 13746696 13746674 -22 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 3389923 3389918 -5 (-0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 41814082 41814026 -56 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92651356 92651455 99 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 32579509 32579529 20 (0.00%) 0.28%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.44 ms 4.55 ms 0.11 ms (2.45%) 4.46%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.16 ms 5.27 ms 0.11 ms (2.08%) 3.72%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.37 ms 5.49 ms 0.11 ms (2.06%) 3.21%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 471.83 µs 480.50 µs 8.66 µs (1.84%) 2.36%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.39 ms 5.49 ms 0.10 ms (1.80%) 3.70%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 471.52 µs 479.37 µs 7.86 µs (1.67%) 2.79%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.29 ms 6.38 ms 0.09 ms (1.48%) 3.16%
transfer_no_resume_ring_1.3_rsa_aes 6.87 ms 6.97 ms 0.10 ms (1.47%) 2.66%
transfer_no_resume_ring_1.2_rsa_aes 6.79 ms 6.88 ms 0.10 ms (1.42%) 3.04%
handshake_no_resume_ring_1.3_ecdsap256_chacha 501.22 µs 507.06 µs 5.84 µs (1.17%) 2.00%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.39 ms 9.49 ms 0.10 ms (1.06%) 2.23%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 12.92 ms 13.02 ms 0.10 ms (0.81%) 1.49%
handshake_no_resume_ring_1.3_ecdsap256_aes 505.01 µs 509.08 µs 4.07 µs (0.81%) 1.90%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.62 ms 13.73 ms 0.11 ms (0.78%) 1.53%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.93 ms 13.03 ms 0.10 ms (0.78%) 1.57%
transfer_no_resume_ring_1.3_rsa_chacha 13.52 ms 13.62 ms 0.10 ms (0.76%) 1.74%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.86 ms 13.96 ms 0.10 ms (0.73%) 1.48%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.04 ms 16.14 ms 0.11 ms (0.66%) 1.32%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.36 ms 1.36 ms 0.01 ms (0.57%) 1.01%
handshake_session_id_ring_1.2_rsa_aes 1.65 ms 1.66 ms 0.01 ms (0.54%) 2.12%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.18 ms 1.18 ms 0.01 ms (0.54%) 1.12%
handshake_no_resume_ring_1.2_rsa_aes 1.07 ms 1.07 ms 0.01 ms (0.54%) 1.00%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 2.06 ms 2.07 ms 0.01 ms (0.54%) 1.69%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 2.22 ms 2.23 ms 0.01 ms (0.53%) 1.85%
handshake_no_resume_ring_1.3_rsa_aes 1.09 ms 1.10 ms 0.01 ms (0.52%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.18 ms 1.19 ms 0.01 ms (0.50%) 1.02%
handshake_no_resume_ring_1.3_rsa_chacha 1.09 ms 1.10 ms 0.01 ms (0.50%) 1.00%
handshake_tickets_ring_1.2_rsa_aes 1.73 ms 1.74 ms 0.01 ms (0.49%) 1.34%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.40 ms 1.41 ms 0.01 ms (0.39%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 5.22 ms 5.24 ms 0.02 ms (0.37%) 1.51%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 5.22 ms 5.24 ms 0.02 ms (0.35%) 1.60%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.41 ms 1.42 ms 0.00 ms (0.35%) 1.00%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 6.18 ms 6.20 ms 0.02 ms (0.34%) 1.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 5.21 ms 5.23 ms 0.02 ms (0.33%) 1.64%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 6.19 ms 6.21 ms 0.02 ms (0.32%) 1.45%
handshake_tickets_ring_1.3_rsa_aes 7.34 ms 7.37 ms 0.02 ms (0.32%) 1.00%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 6.18 ms 6.19 ms 0.02 ms (0.30%) 1.51%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 6.18 ms 6.20 ms 0.02 ms (0.30%) 1.51%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 5.93 ms 5.95 ms 0.02 ms (0.26%) 1.61%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 5.94 ms 5.95 ms 0.01 ms (0.21%) 1.26%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.61 ms 3.62 ms 0.01 ms (0.20%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.61 ms 3.62 ms 0.01 ms (0.20%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 5.91 ms 5.92 ms 0.01 ms (0.20%) 1.48%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 5.93 ms 5.94 ms 0.01 ms (0.19%) 1.44%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.71 ms 6.72 ms 0.01 ms (0.18%) 1.15%
handshake_tickets_ring_1.3_rsa_chacha 7.32 ms 7.33 ms 0.01 ms (0.18%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 5.21 ms 5.22 ms 0.01 ms (0.17%) 1.78%
handshake_session_id_ring_1.3_rsa_chacha 7.30 ms 7.31 ms 0.01 ms (0.16%) 1.05%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.81 ms 9.82 ms 0.01 ms (0.15%) 1.00%
handshake_session_id_ring_1.3_rsa_aes 7.33 ms 7.34 ms 0.01 ms (0.14%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_aes 6.74 ms 6.75 ms 0.01 ms (0.14%) 1.01%
handshake_session_id_ring_1.3_ecdsap256_aes 6.72 ms 6.73 ms 0.01 ms (0.12%) 1.09%
handshake_tickets_ring_1.3_ecdsap384_aes 9.84 ms 9.85 ms 0.01 ms (0.12%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_aes 9.82 ms 9.83 ms 0.01 ms (0.11%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.70 ms 6.70 ms 0.00 ms (0.07%) 1.11%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.80 ms 9.80 ms 0.01 ms (0.06%) 1.00%

Additional information

Historical results

Checkout details:

@codecov Codecov
Copy link

codecov bot commented Mar 21, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.49%. Comparing base (46454a9) to head (1aed96c).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1865   +/-   ##
=======================================
  Coverage   95.49%   95.49%           
=======================================
  Files          85       85           
  Lines       18585    18585           
=======================================
  Hits        17747    17747           
  Misses        838      838

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cpu
Copy link
Member

cpu commented Mar 21, 2024

rustls / Clippy (push) Failing after 1m

Looks like we have some more tidying to do on main

@ctz
Copy link
Member Author

ctz commented Mar 21, 2024

rustls / Clippy (push) Failing after 1m

Looks like we have some more tidying to do on main

#1866

@ctz ctz enabled auto-merge March 21, 2024 16:55
@ctz @cpu
Add path dependency for rustls-post-quantum
1aed96c 
This avoids our Cargo.lock containing a previous version of this
crate, and means a local `cargo build` is sufficient to check
rustls-post-quantum/ builds against the current rustls/.
@cpu
Copy link
Member

cpu commented Mar 21, 2024

cpu force-pushed the jbp-rpq-path-dep branch from cab850d to 1aed96c

Hit the UI button to rebase so the merge queue could take over.

@ctz ctz added this pull request to the merge queue Mar 21, 2024
Merged via the queue into main with commit 667482a Mar 21, 2024
46 checks passed
@ctz ctz deleted the jbp-rpq-path-dep branch March 21, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@cpu cpu cpu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ctz @cpu @djc