Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct ECDSA-SHA1 allergy #1869

Merged
merged 3 commits into from
Mar 22, 2024
Merged

Correct ECDSA-SHA1 allergy #1869

merged 3 commits into from
Mar 22, 2024

Conversation

ctz
Copy link
Member

@ctz ctz commented Mar 22, 2024

This aims to fix seanmonstar/reqwest#2191

Should be an easy backport to 0.22.

ctz added 3 commits March 22, 2024 16:34
@ctz
Move MockServerVerifier to tests::common
7990f81
@ctz
Map SignatureScheme::ECDSA_SHA1_Legacy to SignatureAlgorithm::ECDSA
bd2e740
@ctz
Test that reproduces the problem
0b316d1 
Prior to the fix this fails with:

```
called `Result::unwrap()` on an `Err` value: PeerMisbehaved(SignedKxWithWrongAlgorithm)
```
@codecov Codecov
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.49%. Comparing base (667482a) to head (0b316d1).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1869   +/-   ##
=======================================
  Coverage   95.49%   95.49%           
=======================================
  Files          85       85           
  Lines       18585    18585           
=======================================
  Hits        17747    17747           
  Misses        838      838

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented Mar 22, 2024 •
edited

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8723935 8666944 -56991 (-0.65%) 0.71%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3938359 3961126 22767 (0.58%) 3.54%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 4383328 4407875 24547 (0.56%) 2.85%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 30239220 30337881 98661 (0.33%) 0.34%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 30063978 30107920 43942 (0.15%) 0.41%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 32533061 32577472 44411 (0.14%) 0.43%
handshake_session_id_ring_1.2_rsa_aes_server 4240530 4235501 -5029 (-0.12%) 0.30%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8685601 8695145 9544 (0.11%) 0.84%
handshake_tickets_ring_1.2_rsa_aes_server 4665761 4660924 -4837 (-0.10%) 0.28%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 2135756 2133683 -2073 (-0.10%) 0.38%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92642645 92731063 88418 (0.10%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3368785 3365659 -3126 (-0.09%) 0.24%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 32349361 32319843 -29518 (-0.09%) 0.55%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 30313758 30286339 -27419 (-0.09%) 0.38%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 30134119 30106998 -27121 (-0.09%) 0.42%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3365590 3363628 -1962 (-0.06%) 0.21%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 12296632 12302577 5945 (0.05%) 0.62%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3920162 3918327 -1835 (-0.05%) 0.23%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46409016 46389228 -19788 (-0.04%) 0.31%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58222578 58245837 23259 (0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 32286595 32274111 -12484 (-0.04%) 0.60%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 32570172 32581011 10839 (0.03%) 0.65%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 13743757 13739592 -4165 (-0.03%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 42030167 42039494 9327 (0.02%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 43315000 43307158 -7842 (-0.02%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 2138334 2137953 -381 (-0.02%) 0.38%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 32591388 32586341 -5047 (-0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 30082060 30086409 4349 (0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35475454 35470644 -4810 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 32305566 32301210 -4356 (-0.01%) 0.23%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 30284740 30288756 4016 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 32591480 32587321 -4159 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3970815 3971321 506 (0.01%) 0.67%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 12720122 12721691 1569 (0.01%) 0.86%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 32578832 32574892 -3940 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 32578642 32574712 -3930 (-0.01%) 0.29%
handshake_tickets_ring_1.3_ecdsap384_aes_server 43687916 43693161 5245 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 32333233 32329373 -3860 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 41766146 41761247 -4899 (-0.01%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4513259 4513782 523 (0.01%) 0.75%
handshake_no_resume_ring_1.3_rsa_chacha_client 4566773 4566245 -528 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 3174468 3174107 -361 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1889449 1889235 -214 (-0.01%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 43409644 43404776 -4868 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 41846780 41851466 4686 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 30297408 30300626 3218 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 32303956 32300554 -3402 (-0.01%) 0.22%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 3389999 3389652 -347 (-0.01%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 4557096 4557562 466 (0.01%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 43690401 43685972 -4429 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 42029890 42034146 4256 (0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46452605 46457013 4408 (0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46457848 46462146 4298 (0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46420202 46415923 -4279 (-0.01%) 0.42%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 32332448 32329483 -2965 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 41840237 41843948 3711 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 43314639 43310852 -3787 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 12709594 12710690 1096 (0.01%) 0.86%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58315795 58320632 4837 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 43620981 43617560 -3421 (-0.01%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 43311337 43308109 -3228 (-0.01%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 43618413 43615198 -3215 (-0.01%) 0.23%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 43620532 43617766 -2766 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 41962532 41960040 -2492 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1892755 1892654 -101 (-0.01%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 42019441 42021577 2136 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 43693377 43691672 -1705 (-0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4246182 4246019 -163 (-0.00%) 0.52%
handshake_no_resume_ring_1.3_rsa_aes_server 12243231 12243687 456 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80589413 80592390 2977 (0.00%) 0.29%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58317299 58319423 2124 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92687245 92690620 3375 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 30130741 30131806 1065 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3922601 3922467 -134 (-0.00%) 0.23%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 30345838 30346685 847 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 4266814 4266907 93 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 4271245 4271153 -92 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 41762355 41761474 -881 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 30332482 30333114 632 (0.00%) 0.21%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58219258 58220415 1157 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 13746442 13746658 216 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 4459403 4459472 69 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 42089002 42088353 -649 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 43411092 43411641 549 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 41965715 41966241 526 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 30146270 30145893 -377 (-0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 12049453 12049591 138 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92689104 92690079 975 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 3379049 3379016 -33 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 43412514 43412935 421 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 68641387 68642008 621 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46457610 46457196 -414 (-0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 41814089 41813745 -344 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92652851 92653565 714 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58319967 58319534 -433 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46417797 46418124 327 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 12252582 12252522 -60 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80610037 80610415 378 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35477759 35477916 157 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 30098969 30098857 -112 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80505229 80505493 264 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4289237 4289250 13 (0.00%) 0.99%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46420331 46420195 -136 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58202121 58201986 -135 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58221563 58221698 135 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92648299 92648130 -169 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46338444 46338363 -81 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80511205 80511089 -116 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80608202 80608125 -77 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80510727 80510799 72 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92649106 92649026 -80 (-0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 41893983 41893955 -28 (-0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.44 ms 4.53 ms 0.09 ms (1.92%) 4.47%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.39 ms 5.48 ms 0.09 ms (1.75%) 3.78%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.16 ms 5.24 ms 0.08 ms (1.61%) 3.80%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.38 ms 5.46 ms 0.08 ms (1.45%) 3.63%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.29 ms 6.37 ms 0.08 ms (1.24%) 3.17%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 472.49 µs 478.14 µs 5.65 µs (1.20%) 2.37%
transfer_no_resume_ring_1.3_rsa_aes 6.87 ms 6.95 ms 0.08 ms (1.16%) 2.67%
transfer_no_resume_ring_1.2_rsa_aes 6.79 ms 6.86 ms 0.07 ms (1.10%) 3.21%
handshake_no_resume_ring_1.3_ecdsap256_aes 503.73 µs 509.08 µs 5.34 µs (1.06%) 1.90%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 471.65 µs 476.62 µs 4.97 µs (1.05%) 2.79%
handshake_no_resume_ring_1.3_ecdsap256_chacha 501.79 µs 506.97 µs 5.18 µs (1.03%) 2.00%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.40 ms 9.47 ms 0.07 ms (0.78%) 2.23%
handshake_tickets_ring_1.3_ecdsap256_aes 6.73 ms 6.78 ms 0.05 ms (0.76%) 1.04%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.87 ms 13.96 ms 0.09 ms (0.67%) 1.51%
handshake_no_resume_ring_1.3_rsa_chacha 1.09 ms 1.10 ms 0.01 ms (0.65%) 1.00%
handshake_session_id_ring_1.2_rsa_aes 1.65 ms 1.66 ms 0.01 ms (0.65%) 2.00%
transfer_no_resume_ring_1.3_rsa_chacha 13.52 ms 13.61 ms 0.09 ms (0.65%) 1.82%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 12.92 ms 13.01 ms 0.08 ms (0.64%) 1.51%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.94 ms 13.02 ms 0.08 ms (0.63%) 1.76%
handshake_session_id_ring_1.3_ecdsap256_aes 6.72 ms 6.76 ms 0.04 ms (0.62%) 1.11%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 5.92 ms 5.96 ms 0.04 ms (0.62%) 1.48%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.63 ms 13.72 ms 0.08 ms (0.62%) 1.54%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 5.24 ms 5.27 ms 0.03 ms (0.61%) 1.51%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 5.95 ms 5.98 ms 0.03 ms (0.59%) 1.61%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.69 ms 6.73 ms 0.04 ms (0.55%) 1.11%
handshake_tickets_ring_1.3_rsa_aes 7.34 ms 7.38 ms 0.04 ms (0.55%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 5.22 ms 5.25 ms 0.03 ms (0.55%) 1.78%
handshake_session_id_ring_1.3_rsa_chacha 7.29 ms 7.33 ms 0.04 ms (0.54%) 1.15%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 6.19 ms 6.22 ms 0.03 ms (0.53%) 1.51%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.04 ms 16.12 ms 0.09 ms (0.53%) 1.35%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.71 ms 6.75 ms 0.04 ms (0.53%) 1.17%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 6.20 ms 6.23 ms 0.03 ms (0.53%) 1.51%
handshake_session_id_ring_1.3_rsa_aes 7.33 ms 7.37 ms 0.04 ms (0.52%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_aes 9.84 ms 9.89 ms 0.05 ms (0.52%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 5.23 ms 5.25 ms 0.03 ms (0.51%) 1.64%
handshake_tickets_ring_1.3_rsa_chacha 7.31 ms 7.35 ms 0.04 ms (0.51%) 1.00%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 6.21 ms 6.24 ms 0.03 ms (0.50%) 1.45%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 6.20 ms 6.23 ms 0.03 ms (0.50%) 1.20%
handshake_session_id_ring_1.3_ecdsap384_aes 9.81 ms 9.86 ms 0.05 ms (0.49%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.79 ms 9.84 ms 0.05 ms (0.49%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 5.24 ms 5.26 ms 0.03 ms (0.48%) 1.60%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 5.95 ms 5.98 ms 0.03 ms (0.48%) 1.26%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.18 ms 1.19 ms 0.01 ms (0.46%) 1.02%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 5.94 ms 5.97 ms 0.03 ms (0.46%) 1.44%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.81 ms 9.85 ms 0.04 ms (0.44%) 1.00%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.36 ms 1.36 ms 0.01 ms (0.41%) 1.00%
handshake_tickets_ring_1.2_rsa_aes 1.73 ms 1.74 ms 0.01 ms (0.41%) 1.39%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.18 ms 1.18 ms 0.00 ms (0.40%) 1.08%
handshake_no_resume_ring_1.2_rsa_aes 1.07 ms 1.07 ms 0.00 ms (0.37%) 1.00%
handshake_no_resume_ring_1.3_rsa_aes 1.09 ms 1.09 ms 0.00 ms (0.35%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.41 ms 1.42 ms 0.00 ms (0.30%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.40 ms 1.41 ms 0.00 ms (0.26%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.61 ms 3.61 ms 0.01 ms (0.23%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.61 ms 3.61 ms 0.00 ms (0.07%) 1.00%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 2.07 ms 2.07 ms -0.00 ms (-0.02%) 1.70%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 2.22 ms 2.22 ms 0.00 ms (0.02%) 1.68%

Additional information

Historical results

Checkout details:

@ctz ctz added this pull request to the merge queue Mar 22, 2024
Merged via the queue into main with commit a7d2ad6 Mar 22, 2024
46 checks passed
@ctz ctz deleted the jbp-ecdsa-sha1-allergy branch March 22, 2024 17:13
@djc
Copy link
Member

djc commented Mar 22, 2024 •
edited

(This is getting boring, sorry, but:) I think this probably merits a 0.23.4? (And 0.22.3?)

@cpu cpu mentioned this pull request Mar 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@cpu cpu cpu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing to connect with rustls-tls in reqwest 0.12
3 participants
@ctz @djc @cpu