Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cargo.lock: update semver compatible deps #1874

Merged
merged 5 commits into from
Mar 25, 2024
Merged

Cargo.lock: update semver compatible deps #1874

merged 5 commits into from
Mar 25, 2024

Conversation

cpu
Copy link
Member

@cpu cpu commented Mar 25, 2024 •
edited

Replaces #1871

  • async-trait 0.1.78 -> 0.1.79
  • rayon 1.9.0 -> 1.10.0
  • rustls-pki-types 1.10.3 -> 1.10.4
  • regex 1.10.3 -> 1.10.4
  • base64 0.21.7 -> 0.22

@cpu cpu self-assigned this Mar 25, 2024
@cpu cpu mentioned this pull request Mar 25, 2024
Closed
@djc
Copy link
Member

djc commented Mar 25, 2024

So why aren't we updating to base64 0.22?

@cpu
Copy link
Member Author

cpu commented Mar 25, 2024

So why aren't we updating to base64 0.22?

cargo update -p base64 gives me no Cargo.lock diff. Same for env_logger.

You want to see the Cargo.toml versions manually incremented?

@codecov Codecov
Copy link

codecov bot commented Mar 25, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.47%. Comparing base (1dee8b1) to head (2c2e2e6).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1874   +/-   ##
=======================================
  Coverage   95.47%   95.47%           
=======================================
  Files          85       85           
  Lines       18589    18589           
=======================================
  Hits        17747    17747           
  Misses        842      842

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djc
Copy link
Member

djc commented Mar 25, 2024 •
edited

I would expect a change to update Cargo.toml in for the dev-dependency in rustls and in openssl-tests, yes, in a separate commit.

@cpu
Copy link
Member Author

cpu commented Mar 25, 2024

Added a separate commit for the base64 update. env_logger remains at 0.10 to avoid the 1.71 MSRV associated with 0.11.

I'll make sure to include these dev dep updates as part of the regular process for future PRs.

@cpu
Copy link
Member Author

cpu commented Mar 25, 2024

as part of the regular process

Though, now that we know the upstream dependabot folks aren't likely to make their automation work the way we want I'm perhaps more open to the idea of using renovatebot like @ctz suggested at one point.

djc
djc approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, I also think having one commit per semver-compatible dep isn't really worth it.

For Renovate, the rustup repo has a decent setup which we could steal from.

@rustls-benchmarking Rustls Benchmarking
Copy link

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3950177 3908256 -41921 (-1.06%) 3.54%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8705040 8668082 -36958 (-0.42%) 0.81%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 12265594 12317537 51943 (0.42%) 0.61%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 30061309 30139967 78658 (0.26%) 0.40%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 32238874 32309551 70677 (0.22%) 0.66%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 12720279 12693207 -27072 (-0.21%) 0.81%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 30268127 30331664 63537 (0.21%) 0.39%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8694778 8677302 -17476 (-0.20%) 0.72%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 12698828 12677800 -21028 (-0.17%) 0.88%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46417154 46365254 -51900 (-0.11%) 0.28%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 32566336 32602133 35797 (0.11%) 0.43%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 4388706 4384693 -4013 (-0.09%) 2.80%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 32552098 32574108 22010 (0.07%) 0.64%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80585202 80634684 49482 (0.06%) 0.26%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 30286804 30270033 -16771 (-0.06%) 0.34%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 30088931 30104354 15423 (0.05%) 0.47%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1889558 1888766 -792 (-0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 32310732 32322960 12228 (0.04%) 0.53%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 13743773 13739164 -4609 (-0.03%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92682210 92708023 25813 (0.03%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46433824 46446638 12814 (0.03%) 0.41%
handshake_tickets_ring_1.2_rsa_aes_server 4660087 4658829 -1258 (-0.03%) 0.28%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4287946 4288966 1020 (0.02%) 0.99%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58212775 58223212 10437 (0.02%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4245098 4245741 643 (0.02%) 0.43%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35475486 35470721 -4765 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 41762206 41756779 -5427 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3365815 3365386 -429 (-0.01%) 0.21%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3920615 3920128 -487 (-0.01%) 0.23%
handshake_tickets_ring_1.3_ecdsap384_aes_client 42034065 42039086 5021 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 43687997 43693123 5126 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 41846588 41851427 4839 (0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 2138028 2137786 -242 (-0.01%) 0.37%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 3174381 3174023 -358 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 43308827 43304610 -4217 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46458045 46462556 4511 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 43408416 43412516 4100 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 41961825 41957946 -3879 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 41766155 41762392 -3763 (-0.01%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 4459706 4459358 -348 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58316822 58321260 4438 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 30096863 30098643 1780 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 43615277 43612830 -2447 (-0.01%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4234042 4234264 222 (0.01%) 0.30%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3970788 3970989 201 (0.01%) 0.64%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 2135768 2135867 99 (0.00%) 0.38%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 43309389 43307408 -1981 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 4566378 4566579 201 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3368319 3368450 131 (0.00%) 0.23%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 3378988 3379117 129 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 12252684 12252220 -464 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 30284093 30285233 1140 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 32326999 32328133 1134 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 42020634 42019253 -1381 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 30084029 30083263 -766 (-0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 43305642 43306648 1006 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 4266890 4266802 -88 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 4557296 4557203 -93 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 32584960 32585619 659 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 32298581 32299232 651 (0.00%) 0.23%
handshake_no_resume_ring_1.2_rsa_aes_server 12049251 12049492 241 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 41842110 41842863 753 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 12243124 12242909 -215 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 42030928 42031633 705 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1892571 1892602 31 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3922190 3922130 -60 (-0.00%) 0.22%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46417701 46418391 690 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 43688452 43688970 518 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 32585805 32585427 -378 (-0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 43405529 43406023 494 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 3389642 3389680 38 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92689057 92688074 -983 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 43409009 43408572 -437 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58319722 58320291 569 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 41894423 41894056 -367 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92653925 92653119 -806 (-0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4513059 4513098 39 (0.00%) 0.74%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 41965919 41965562 -357 (-0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 41814366 41814011 -355 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 32298834 32299105 271 (0.00%) 0.22%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 32572931 32572672 -259 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46457614 46457974 360 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92652000 92652678 678 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 30298579 30298367 -212 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 32327486 32327710 224 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 30332846 30333055 209 (0.00%) 0.21%
transfer_no_resume_ring_1.2_rsa_aes_server 46338479 46338188 -291 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 30145519 30145706 187 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 13746319 13746235 -84 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80608587 80608107 -480 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 32573258 32573084 -174 (-0.00%) 0.26%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 30345357 30345195 -162 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92649326 92648921 -405 (-0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 43613072 43612886 -186 (-0.00%) 0.23%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58222468 58222222 -246 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 30132170 30132289 119 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35477711 35477594 -117 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 43615163 43615303 140 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 43686605 43686469 -136 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80507448 80507680 232 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92690616 92690368 -248 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58202762 58202905 143 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46454740 46454643 -97 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80610252 80610116 -136 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 4271205 4271211 6 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58219280 58219199 -81 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80510797 80510896 99 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 68642587 68642648 61 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 42088716 42088749 33 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46420109 46420089 -20 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58320477 58320456 -21 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80511333 80511314 -19 (-0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.51 ms 4.44 ms -0.07 ms (-1.59%) 4.68%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.23 ms 5.15 ms -0.08 ms (-1.46%) 3.68%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 480.39 µs 473.54 µs -6.85 µs (-1.43%) 2.46%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.46 ms 5.38 ms -0.08 ms (-1.40%) 3.82%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.46 ms 5.38 ms -0.07 ms (-1.34%) 3.78%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 477.70 µs 472.07 µs -5.63 µs (-1.18%) 2.79%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.35 ms 6.28 ms -0.07 ms (-1.17%) 3.27%
handshake_no_resume_ring_1.3_ecdsap256_aes 510.06 µs 504.49 µs -5.57 µs (-1.09%) 1.79%
transfer_no_resume_ring_1.3_rsa_aes 6.94 ms 6.87 ms -0.07 ms (-1.06%) 2.70%
transfer_no_resume_ring_1.2_rsa_aes 6.86 ms 6.79 ms -0.07 ms (-1.01%) 3.36%
handshake_no_resume_ring_1.3_ecdsap256_chacha 505.86 µs 501.69 µs -4.17 µs (-0.82%) 2.00%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.46 ms 9.39 ms -0.07 ms (-0.76%) 2.22%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 12.99 ms 12.92 ms -0.07 ms (-0.57%) 1.53%
transfer_no_resume_ring_1.3_ecdsap256_chacha 13.01 ms 12.93 ms -0.07 ms (-0.57%) 1.75%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.70 ms 13.63 ms -0.08 ms (-0.57%) 1.55%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.94 ms 13.87 ms -0.08 ms (-0.56%) 1.51%
transfer_no_resume_ring_1.3_rsa_chacha 13.59 ms 13.52 ms -0.07 ms (-0.55%) 1.84%
handshake_tickets_ring_1.2_rsa_aes 1.74 ms 1.73 ms -0.01 ms (-0.49%) 1.70%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.36 ms 1.36 ms -0.01 ms (-0.44%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 5.95 ms 5.93 ms -0.03 ms (-0.43%) 1.21%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.11 ms 16.04 ms -0.07 ms (-0.43%) 1.34%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.41 ms 1.40 ms -0.01 ms (-0.41%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.42 ms 1.41 ms -0.01 ms (-0.40%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 5.22 ms 5.20 ms -0.02 ms (-0.38%) 1.77%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 5.23 ms 5.21 ms -0.02 ms (-0.38%) 1.57%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 5.21 ms 5.19 ms -0.02 ms (-0.37%) 1.83%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 6.20 ms 6.18 ms -0.02 ms (-0.36%) 1.17%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.18 ms 1.18 ms -0.00 ms (-0.35%) 1.04%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 6.18 ms 6.16 ms -0.02 ms (-0.35%) 1.66%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 5.94 ms 5.92 ms -0.02 ms (-0.34%) 1.51%
handshake_no_resume_ring_1.3_rsa_chacha 1.09 ms 1.09 ms -0.00 ms (-0.34%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 5.91 ms 5.90 ms -0.02 ms (-0.32%) 1.57%
handshake_no_resume_ring_1.3_rsa_aes 1.10 ms 1.09 ms -0.00 ms (-0.29%) 1.04%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.19 ms 1.19 ms -0.00 ms (-0.28%) 1.07%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 6.19 ms 6.17 ms -0.02 ms (-0.25%) 1.57%
handshake_tickets_ring_1.3_ecdsap256_aes 6.75 ms 6.73 ms -0.02 ms (-0.24%) 1.06%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 5.93 ms 5.92 ms -0.01 ms (-0.24%) 1.48%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 5.23 ms 5.22 ms -0.01 ms (-0.24%) 1.51%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 6.20 ms 6.19 ms -0.01 ms (-0.23%) 1.43%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 2.21 ms 2.21 ms -0.00 ms (-0.19%) 1.63%
handshake_no_resume_ring_1.2_rsa_aes 1.07 ms 1.07 ms -0.00 ms (-0.15%) 1.00%
handshake_session_id_ring_1.2_rsa_aes 1.65 ms 1.65 ms -0.00 ms (-0.15%) 2.01%
handshake_tickets_ring_1.3_rsa_aes 7.35 ms 7.34 ms -0.01 ms (-0.13%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.71 ms 6.70 ms -0.01 ms (-0.11%) 1.22%
handshake_session_id_ring_1.3_ecdsap256_aes 6.72 ms 6.71 ms -0.01 ms (-0.10%) 1.13%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 2.06 ms 2.06 ms -0.00 ms (-0.09%) 1.70%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.61 ms 3.61 ms -0.00 ms (-0.07%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.68 ms 6.68 ms -0.00 ms (-0.06%) 1.15%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.79 ms 9.79 ms 0.01 ms (0.05%) 1.00%
handshake_session_id_ring_1.3_rsa_aes 7.33 ms 7.32 ms -0.00 ms (-0.05%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.61 ms 3.61 ms -0.00 ms (-0.03%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.80 ms 9.80 ms 0.00 ms (0.02%) 1.00%
handshake_session_id_ring_1.3_rsa_chacha 7.29 ms 7.29 ms -0.00 ms (-0.02%) 1.05%
handshake_tickets_ring_1.3_rsa_chacha 7.31 ms 7.31 ms 0.00 ms (0.02%) 1.04%
handshake_session_id_ring_1.3_ecdsap384_aes 9.82 ms 9.81 ms -0.00 ms (-0.02%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_aes 9.84 ms 9.84 ms -0.00 ms (-0.00%) 1.00%

Additional information

Historical results

Checkout details:

@cpu cpu added this pull request to the merge queue Mar 25, 2024
Merged via the queue into rustls:main with commit 074ced1 Mar 25, 2024
25 checks passed
@cpu cpu deleted the cpu-update-deps branch March 25, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

Assignees

@cpu cpu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cpu @djc