quic: make Suite Copy

[djc]

This would be nice to have for Quinn.

[rustls-benchmarking]

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand

Scenario	Baseline	Candidate	Diff	Threshold
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server	3965606	3933854	-31752 (-0.80%)	3.04%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server	12721497	12667175	-54322 (-0.43%)	0.89%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server	4403632	4388214	-15418 (-0.35%)	2.82%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server	32279394	32365998	86604 (0.27%)	0.53%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server	32527932	32596484	68552 (0.21%)	0.48%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client	8675547	8691962	16415 (0.19%)	0.70%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server	12693612	12715339	21727 (0.17%)	1.03%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client	8675321	8689223	13902 (0.16%)	0.94%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client	30327157	30282382	-44775 (-0.15%)	0.34%
handshake_no_resume_ring_1.3_ecdsap256_aes_server	2136037	2133894	-2143 (-0.10%)	0.38%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server	46381316	46423139	41823 (0.09%)	0.22%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client	30303310	30280519	-22791 (-0.08%)	0.34%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server	32302100	32279407	-22693 (-0.07%)	0.74%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server	80644986	80591197	-53789 (-0.07%)	0.28%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client	92725625	92676432	-49193 (-0.05%)	0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server	12311575	12305302	-6273 (-0.05%)	0.48%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server	32575622	32589432	13810 (0.04%)	0.51%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server	46409714	46421499	11785 (0.03%)	0.43%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client	30112565	30118422	5857 (0.02%)	0.41%
handshake_tickets_ring_1.2_rsa_aes_server	4659956	4659350	-606 (-0.01%)	0.24%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client	3368277	3367867	-410 (-0.01%)	0.26%
handshake_session_id_ring_1.2_rsa_aes_client	4246027	4245518	-509 (-0.01%)	0.37%
handshake_tickets_ring_1.3_ecdsap256_chacha_client	41957507	41962293	4786 (0.01%)	0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client	42038835	42034133	-4702 (-0.01%)	0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server	43693141	43688415	-4726 (-0.01%)	0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server	43685777	43690438	4661 (0.01%)	0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server	1892209	1892406	197 (0.01%)	0.20%
handshake_session_id_ring_1.2_rsa_aes_server	4234108	4233673	-435 (-0.01%)	0.29%
handshake_session_id_ring_1.3_ecdsap384_chacha_server	43305064	43309392	4328 (0.01%)	0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server	46458473	46462977	4504 (0.01%)	0.20%
handshake_no_resume_ring_1.3_rsa_aes_client	4557192	4557588	396 (0.01%)	0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client	58316648	58321361	4713 (0.01%)	0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client	3174135	3174377	242 (0.01%)	0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client	42028189	42031328	3139 (0.01%)	0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client	3389748	3389992	244 (0.01%)	0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client	41761466	41764322	2856 (0.01%)	0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client	4566230	4566533	303 (0.01%)	0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client	3365148	3365356	208 (0.01%)	0.24%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client	4288577	4288323	-254 (-0.01%)	0.92%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server	80511289	80506748	-4541 (-0.01%)	0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client	92649055	92644259	-4796 (-0.01%)	0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client	30106790	30105260	-1530 (-0.01%)	0.37%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client	30285205	30286660	1455 (0.00%)	0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client	30084402	30083007	-1395 (-0.00%)	0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client	58216454	58219071	2617 (0.00%)	0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client	3971252	3971088	-164 (-0.00%)	0.47%
handshake_session_id_ring_1.3_ecdsap256_chacha_client	41763430	41765105	1675 (0.00%)	0.20%
handshake_no_resume_ring_1.3_rsa_aes_server	12243745	12243330	-415 (-0.00%)	0.20%
handshake_no_resume_ring_1.2_rsa_aes_client	4459557	4459436	-121 (-0.00%)	0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server	12252544	12252222	-322 (-0.00%)	0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server	1888993	1889039	46 (0.00%)	0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server	32573735	32572955	-780 (-0.00%)	0.23%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server	32572944	32573591	647 (0.00%)	0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client	30098648	30099236	588 (0.00%)	0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server	32299520	32298898	-622 (-0.00%)	0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server	43309605	43308812	-793 (-0.00%)	0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server	4271252	4271328	76 (0.00%)	0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server	32584726	32585220	494 (0.00%)	0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client	3918391	3918334	-57 (-0.00%)	0.24%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server	13746445	13746629	184 (0.00%)	0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server	43613251	43613819	568 (0.00%)	0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server	43408164	43408727	563 (0.00%)	0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client	30131039	30130653	-386 (-0.00%)	0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server	32585730	32586146	416 (0.00%)	0.20%
handshake_tickets_ring_1.3_rsa_chacha_client	42020780	42020281	-499 (-0.00%)	0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server	4266848	4266894	46 (0.00%)	0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client	30345809	30345520	-289 (-0.00%)	0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server	43610863	43610454	-409 (-0.00%)	0.20%
handshake_session_id_ring_1.3_rsa_aes_client	41894060	41894441	381 (0.00%)	0.20%
handshake_tickets_ring_1.2_rsa_aes_client	4512603	4512562	-41 (-0.00%)	0.76%
transfer_no_resume_ring_1.3_rsa_aes_server	46457082	46457489	407 (0.00%)	0.20%
handshake_session_id_ring_1.3_rsa_chacha_client	41813610	41813975	365 (0.00%)	0.20%
handshake_no_resume_ring_1.2_rsa_aes_server	12049454	12049556	102 (0.00%)	0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client	35477830	35478114	284 (0.00%)	0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server	32327685	32327431	-254 (-0.00%)	0.20%
handshake_session_id_ring_1.3_rsa_chacha_server	43306150	43305820	-330 (-0.00%)	0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server	32299550	32299305	-245 (-0.00%)	0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client	41961584	41961284	-300 (-0.00%)	0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client	30332024	30332230	206 (0.00%)	0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server	80510691	80511207	516 (0.00%)	0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client	58220040	58219711	-329 (-0.00%)	0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client	3378973	3378954	-19 (-0.00%)	0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client	58222248	58222563	315 (0.00%)	0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client	41850844	41851066	222 (0.00%)	0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server	32327285	32327118	-167 (-0.00%)	0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server	46419995	46420234	239 (0.00%)	0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client	41842265	41842479	214 (0.00%)	0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client	35470871	35471026	155 (0.00%)	0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client	3920073	3920090	17 (0.00%)	0.21%
handshake_tickets_ring_1.3_rsa_aes_client	42088514	42088374	-140 (-0.00%)	0.20%
handshake_tickets_ring_1.3_rsa_chacha_server	43612668	43612807	139 (0.00%)	0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client	92653802	92653520	-282 (-0.00%)	0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server	2137862	2137856	-6 (-0.00%)	0.37%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client	68642427	68642237	-190 (-0.00%)	0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client	92654413	92654180	-233 (-0.00%)	0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client	92690492	92690261	-231 (-0.00%)	0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server	80507943	80507743	-200 (-0.00%)	0.20%
transfer_no_resume_ring_1.2_rsa_aes_server	46338297	46338191	-106 (-0.00%)	0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client	58319725	58319594	-131 (-0.00%)	0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client	92689203	92688997	-206 (-0.00%)	0.20%
handshake_tickets_ring_1.3_rsa_aes_server	43685867	43685959	92 (0.00%)	0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server	13739252	13739280	28 (0.00%)	0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server	46454370	46454452	82 (0.00%)	0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server	46418278	46418359	81 (0.00%)	0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client	30145706	30145749	43 (0.00%)	0.20%
transfer_no_resume_ring_1.3_rsa_aes_client	58320382	58320460	78 (0.00%)	0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client	30298182	30298221	39 (0.00%)	0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server	43413008	43413055	47 (0.00%)	0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server	80610267	80610192	-75 (-0.00%)	0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server	80608514	80608487	-27 (-0.00%)	0.20%
handshake_session_id_ring_1.3_rsa_aes_server	43404675	43404666	-9 (-0.00%)	0.20%
transfer_no_resume_ring_1.2_rsa_aes_client	58202710	58202706	-4 (-0.00%)	0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand

Scenario	Baseline	Candidate	Diff	Threshold
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes	4.45 ms	4.52 ms	0.06 ms (1.44%)	4.18%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes	5.17 ms	5.24 ms	0.07 ms (1.36%)	3.72%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes	5.39 ms	5.46 ms	0.07 ms (1.25%)	3.80%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes	5.40 ms	5.46 ms	0.07 ms (1.22%)	3.43%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes	473.54 µs	478.79 µs	5.25 µs (1.11%)	2.38%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha	472.30 µs	477.52 µs	5.21 µs (1.10%)	2.78%
transfer_no_resume_ring_1.3_ecdsap256_aes	6.30 ms	6.36 ms	0.07 ms (1.08%)	3.12%
handshake_no_resume_ring_1.3_ecdsap256_aes	504.88 µs	510.19 µs	5.31 µs (1.05%)	1.56%
transfer_no_resume_ring_1.2_rsa_aes	6.79 ms	6.86 ms	0.07 ms (1.05%)	3.24%
handshake_no_resume_ring_1.3_ecdsap256_chacha	502.35 µs	507.53 µs	5.18 µs (1.03%)	1.63%
transfer_no_resume_ring_1.3_rsa_aes	6.89 ms	6.95 ms	0.06 ms (0.93%)	2.68%
transfer_no_resume_ring_1.3_ecdsap384_aes	9.40 ms	9.48 ms	0.08 ms (0.82%)	2.05%
transfer_no_resume_ring_1.3_ecdsap256_chacha	12.95 ms	13.01 ms	0.07 ms (0.51%)	1.70%
handshake_no_resume_ring_1.3_rsa_chacha	1.09 ms	1.10 ms	0.01 ms (0.51%)	1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes	1.18 ms	1.19 ms	0.01 ms (0.50%)	1.00%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha	12.93 ms	13.00 ms	0.06 ms (0.50%)	1.52%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha	5.21 ms	5.23 ms	0.02 ms (0.48%)	1.35%
transfer_no_resume_ring_1.3_rsa_chacha	13.54 ms	13.61 ms	0.06 ms (0.48%)	1.58%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha	13.88 ms	13.95 ms	0.07 ms (0.48%)	1.38%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha	13.64 ms	13.71 ms	0.06 ms (0.47%)	1.42%
transfer_no_resume_ring_1.3_ecdsap384_chacha	16.06 ms	16.13 ms	0.07 ms (0.46%)	1.17%
handshake_no_resume_ring_1.3_rsa_aes	1.09 ms	1.10 ms	0.00 ms (0.45%)	1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha	5.91 ms	5.94 ms	0.03 ms (0.44%)	1.27%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha	5.19 ms	5.21 ms	0.02 ms (0.44%)	1.78%
handshake_no_resume_ring_1.2_rsa_aes	1.07 ms	1.07 ms	0.00 ms (0.41%)	1.00%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha	1.40 ms	1.41 ms	0.01 ms (0.41%)	1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha	5.88 ms	5.91 ms	0.02 ms (0.39%)	1.33%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes	5.92 ms	5.94 ms	0.02 ms (0.38%)	1.23%
handshake_tickets_aws_lc_rs_1.2_rsa_aes	2.21 ms	2.22 ms	0.01 ms (0.37%)	1.77%
handshake_tickets_ring_1.2_rsa_aes	1.72 ms	1.73 ms	0.01 ms (0.37%)	1.71%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha	1.18 ms	1.18 ms	0.00 ms (0.37%)	1.13%
handshake_session_id_ring_1.2_rsa_aes	1.65 ms	1.65 ms	0.01 ms (0.36%)	1.64%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes	5.19 ms	5.21 ms	0.02 ms (0.34%)	1.57%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes	5.21 ms	5.23 ms	0.02 ms (0.34%)	1.59%
handshake_session_id_ring_1.3_ecdsap256_chacha	6.68 ms	6.70 ms	0.02 ms (0.34%)	1.10%
handshake_session_id_ring_1.3_ecdsap256_aes	6.71 ms	6.73 ms	0.02 ms (0.34%)	1.05%
handshake_tickets_ring_1.3_ecdsap256_aes	6.73 ms	6.75 ms	0.02 ms (0.33%)	1.09%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes	1.36 ms	1.36 ms	0.00 ms (0.33%)	1.08%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha	6.18 ms	6.20 ms	0.02 ms (0.33%)	1.39%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes	5.90 ms	5.92 ms	0.02 ms (0.33%)	1.35%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha	6.15 ms	6.17 ms	0.02 ms (0.32%)	1.42%
handshake_session_id_ring_1.3_ecdsap384_chacha	9.78 ms	9.81 ms	0.03 ms (0.31%)	1.00%
handshake_tickets_ring_1.3_rsa_chacha	7.30 ms	7.32 ms	0.02 ms (0.29%)	1.00%
handshake_session_id_ring_1.3_rsa_aes	7.31 ms	7.34 ms	0.02 ms (0.29%)	1.00%
handshake_tickets_ring_1.3_ecdsap256_chacha	6.70 ms	6.72 ms	0.02 ms (0.28%)	1.09%
handshake_session_id_aws_lc_rs_1.2_rsa_aes	2.06 ms	2.06 ms	0.01 ms (0.28%)	1.62%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes	1.41 ms	1.41 ms	0.00 ms (0.28%)	1.00%
handshake_session_id_ring_1.3_ecdsap384_aes	9.81 ms	9.83 ms	0.03 ms (0.27%)	1.00%
handshake_session_id_ring_1.3_rsa_chacha	7.28 ms	7.30 ms	0.02 ms (0.27%)	1.02%
handshake_tickets_ring_1.3_ecdsap384_aes	9.83 ms	9.85 ms	0.02 ms (0.25%)	1.00%
handshake_tickets_aws_lc_rs_1.3_rsa_aes	6.17 ms	6.19 ms	0.01 ms (0.24%)	1.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes	6.17 ms	6.18 ms	0.01 ms (0.22%)	1.39%
handshake_tickets_ring_1.3_ecdsap384_chacha	9.80 ms	9.82 ms	0.02 ms (0.21%)	1.00%
handshake_tickets_ring_1.3_rsa_aes	7.34 ms	7.35 ms	0.01 ms (0.20%)	1.00%
handshake_no_resume_ring_1.3_ecdsap384_aes	3.61 ms	3.62 ms	0.01 ms (0.16%)	1.00%
handshake_no_resume_ring_1.3_ecdsap384_chacha	3.61 ms	3.61 ms	0.00 ms (0.06%)	1.00%

Additional information

Historical results

Checkout details:

• Base repo: https://github.com/rustls/rustls.git
• Base branch: main (074ced1)
• Candidate repo: https://github.com/rustls/rustls.git
• Candidate branch: quic-suite-copy (b846228)

[cpu]

Seems reasonable 👍

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.47%. Comparing base (074ced1) to head (b846228).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1879   +/-   ##
=======================================
  Coverage   95.47%   95.47%           
=======================================
  Files          85       85           
  Lines       18589    18589           
=======================================
  Hits        17747    17747           
  Misses        842      842           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.