connect-tests: ignore rsa8192.badssl.com #1886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test server's certificate has expired. The issue has been flagged with the upstream project. Until resolved let's ignore this test.
|
Here's a successful run that I invoked manually with the workflow dispatch. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1886 +/- ##
=======================================
Coverage 95.48% 95.48%
=======================================
Files 86 86
Lines 18624 18624
=======================================
Hits 17784 17784
Misses 840 840 ☔ View full report in Codecov by Sentry. |
ctz
approved these changes
Apr 2, 2024
Benchmark resultsInstruction countsSignificant differencesThere are no significant instruction count differences Other differencesClick to expand
Wall-timeSignificant differencesThere are no significant wall-time differences Other differencesClick to expand
Additional informationCheckout details:
|
|
I'm confused because I had missed these failures. Do you get notifications? I seem to recall we've encountered this (some people being notified while others aren't) but have forgotten the details. |
I only get notifications by trying to remember to sync my forks periodically. I reliably seem to get failure emails that way, but it requires manual effort. Otherwise I think GitHub only sends notifications to whoever last edited the workflow.... It's very crummy. The best idea I've for a workaround is to configure our repo with a webhook that dumps failures into the Discord in a bot-specific channel. It seems like a big hammer to wield but I don't know if there are good alternatives :-( |
Would be nice... but yeah, sounds hard? |
I dug up the reference I found before and it's more nuanced:
|
I think ( 🤞 ) it would be pretty easy (a bit of clicking around for someone that has admin privs both here and for the Discord server). The main hesitation I have is that Discord's notification policy is very "on-by-default" and the many folks in the Discord would each have to mute the new bot channel to avoid seeing chatter they might not care about. |
|
Maybe a private channel, so that we can make it opt-in? |
|
That's a good idea. Maybe I can try and prototype something with a private repo/discord and then share the steps I used so that you could replicate it w/ the "production" discord/repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test server's certificate has expired, breaking the connect tests portion of the daily CI jobs since March 27th. The issue has been flagged with the upstream project (chromium/badssl.com#530, chromium/badssl.com#499 (comment)). Until resolved let's ignore this test.