Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: aws-lc-rs 1.6.2 -> 1.6.4 #1888

Merged
merged 1 commit into from
Apr 5, 2024
Merged

deps: aws-lc-rs 1.6.2 -> 1.6.4 #1888

merged 1 commit into from
Apr 5, 2024

Conversation

cpu
Copy link
Member

@cpu cpu commented Apr 5, 2024

Notably this brings in pre-generated bindings for more platforms. See the upstream release notes12 for more details.

aws-ls-rs diff.rs

Footnotes

  1. https://github.com/aws/aws-lc-rs/releases/tag/v1.6.3

  2. https://github.com/aws/aws-lc-rs/releases/tag/v1.6.4

Notably this brings in pre-generated bindings for more platforms.
See the upstream release notes[0][1] for more details.

[0]: https://github.com/aws/aws-lc-rs/releases/tag/v1.6.3
[1]: https://github.com/aws/aws-lc-rs/releases/tag/v1.6.4
@cpu cpu self-assigned this Apr 5, 2024
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.48%. Comparing base (c5d283a) to head (c2fdf44).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1888   +/-   ##
=======================================
  Coverage   95.48%   95.48%           
=======================================
  Files          86       86           
  Lines       18624    18624           
=======================================
  Hits        17784    17784           
  Misses        840      840           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

rustls-benchmarking bot commented Apr 5, 2024

Benchmark results

Instruction counts

Significant differences

⚠️ There are significant instruction count differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 12272480 13058474 ⚠️ 785994 (6.40%) 0.82%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 12693065 13455465 ⚠️ 762400 (6.01%) 0.83%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 12664730 13423224 ⚠️ 758494 (5.99%) 1.39%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 4424970 4395159 -29811 (-0.67%) 3.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8674581 8707245 32664 (0.38%) 0.80%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 32285298 32348246 62948 (0.19%) 0.68%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8678133 8692668 14535 (0.17%) 0.91%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 3378090 3383674 5584 (0.17%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3948548 3954860 6312 (0.16%) 4.03%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 3389202 3394452 5250 (0.15%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 3174344 3178998 4654 (0.15%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 32286127 32330518 44391 (0.14%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 30059488 30100394 40906 (0.14%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 30094172 30135103 40931 (0.14%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 32532696 32576926 44230 (0.14%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 32532365 32576421 44056 (0.14%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 32545306 32589121 43815 (0.13%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 32286540 32329944 43404 (0.13%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 32258353 32301377 43024 (0.13%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 32258001 32300994 42993 (0.13%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 32545813 32588837 43024 (0.13%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 30296193 30335960 39767 (0.13%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 30308836 30348490 39654 (0.13%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3362500 3366890 4390 (0.13%) 0.24%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 30262516 30302026 39510 (0.13%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 30110066 30149256 39190 (0.13%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 30048940 30087953 39013 (0.13%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 30249892 30288388 38496 (0.13%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80687129 80602383 -84746 (-0.11%) 0.27%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 32283804 32315305 31501 (0.10%) 0.59%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 32559261 32590961 31700 (0.10%) 0.54%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1887527 1889326 1799 (0.10%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1891212 1892640 1428 (0.08%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46429575 46396791 -32784 (-0.07%) 0.29%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 2134296 2135782 1486 (0.07%) 0.34%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 30087446 30066916 -20530 (-0.07%) 0.39%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 4265599 4267440 1841 (0.04%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 4270113 4271873 1760 (0.04%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92706560 92669218 -37342 (-0.04%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3918602 3920172 1570 (0.04%) 0.21%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3367604 3368836 1232 (0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 30100467 30089761 -10706 (-0.04%) 0.32%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 13739408 13743392 3984 (0.03%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46425709 46439113 13404 (0.03%) 0.44%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 30280422 30289129 8707 (0.03%) 0.26%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 13742402 13746196 3794 (0.03%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4660638 4659610 -1028 (-0.02%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 41851791 41842654 -9137 (-0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 30269225 30275793 6568 (0.02%) 0.41%
handshake_session_id_ring_1.3_ecdsap384_aes_server 43412245 43403922 -8323 (-0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 32568470 32562255 -6215 (-0.02%) 0.51%
handshake_tickets_ring_1.2_rsa_aes_client 4514766 4513947 -819 (-0.02%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4247710 4247008 -702 (-0.02%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 42032005 42025125 -6880 (-0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4290023 4290666 643 (0.01%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4234888 4235515 627 (0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 2135719 2135421 -298 (-0.01%) 0.38%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35473821 35478120 4299 (0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35471071 35475233 4162 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 42039743 42035363 -4380 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 41770312 41766029 -4283 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 43693259 43688796 -4463 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 43409497 43405570 -3927 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46462393 46458203 -4190 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 43312976 43309313 -3663 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 41761297 41764641 3344 (0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58321163 58316645 -4518 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 41962492 41965150 2658 (0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58222248 58218836 -3412 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 41844017 41841615 -2402 (-0.01%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 4459612 4459371 -241 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80515228 80511435 -3793 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 43616186 43618191 2005 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92653017 92648978 -4039 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 4557376 4557187 -189 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 4566443 4566612 169 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3971855 3971719 -136 (-0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 42020853 42019499 -1354 (-0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 41815061 41813793 -1268 (-0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 43305532 43306652 1120 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 43688182 43689283 1101 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3919902 3919819 -83 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 12252573 12252332 -241 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92652672 92654488 1816 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 12049358 12049146 -212 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46454117 46454770 653 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92688813 92690072 1259 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 43404961 43404392 -569 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 43311341 43311746 405 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46418782 46418366 -416 (-0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 43612767 43613078 311 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58222903 58222546 -357 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 41966726 41966484 -242 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92689950 92690471 521 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58319561 58319852 291 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80509783 80510163 380 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 41895210 41895015 -195 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92653186 92652761 -425 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80608469 80608825 356 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 43686511 43686682 171 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46457448 46457621 173 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 12243361 12243317 -44 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 43615404 43615549 145 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58202627 58202779 152 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58225738 58225588 -150 (-0.00%) 0.21%
transfer_no_resume_ring_1.3_rsa_chacha_server 80510597 80510783 186 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 42089582 42089491 -91 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 68642243 68642385 142 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46420265 46420183 -82 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58320458 58320380 -78 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80610107 80610012 -95 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46338334 46338362 28 (0.00%) 0.20%

Wall-time

Significant differences

⚠️ There are significant wall-time differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.36 ms 1.40 ms ⚠️ 0.05 ms (3.45%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.41 ms 1.46 ms ⚠️ 0.05 ms (3.38%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.40 ms 1.45 ms ⚠️ 0.05 ms (3.36%) 1.00%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 2.06 ms 2.11 ms ⚠️ 0.05 ms (2.39%) 1.39%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 2.21 ms 2.26 ms ⚠️ 0.05 ms (2.26%) 1.83%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.40 ms 5.48 ms 0.08 ms (1.47%) 3.40%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.40 ms 5.47 ms 0.08 ms (1.39%) 4.04%
handshake_session_id_ring_1.2_rsa_aes 1.64 ms 1.65 ms 0.02 ms (1.08%) 1.49%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 6.19 ms 6.25 ms 0.06 ms (0.95%) 1.23%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 6.17 ms 6.22 ms 0.06 ms (0.90%) 1.52%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 6.18 ms 6.23 ms 0.05 ms (0.88%) 1.57%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 6.19 ms 6.24 ms 0.05 ms (0.87%) 1.14%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.45 ms 4.49 ms 0.03 ms (0.74%) 4.59%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 471.81 µs 475.20 µs 3.40 µs (0.72%) 2.54%
handshake_no_resume_ring_1.3_ecdsap256_chacha 502.91 µs 506.18 µs 3.27 µs (0.65%) 1.72%
transfer_no_resume_ring_1.3_rsa_aes 6.88 ms 6.92 ms 0.04 ms (0.58%) 1.87%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.17 ms 5.20 ms 0.03 ms (0.57%) 3.83%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.29 ms 6.33 ms 0.04 ms (0.57%) 3.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.88 ms 13.95 ms 0.07 ms (0.53%) 1.09%
handshake_tickets_ring_1.2_rsa_aes 1.73 ms 1.73 ms 0.01 ms (0.51%) 1.33%
transfer_no_resume_ring_1.2_rsa_aes 6.79 ms 6.82 ms 0.03 ms (0.46%) 3.56%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 472.83 µs 474.93 µs 2.10 µs (0.44%) 2.38%
handshake_no_resume_ring_1.3_ecdsap256_aes 504.39 µs 506.63 µs 2.23 µs (0.44%) 1.34%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.41 ms 9.44 ms 0.03 ms (0.36%) 1.82%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.95 ms 12.98 ms 0.04 ms (0.29%) 1.49%
handshake_tickets_ring_1.3_ecdsap256_aes 6.78 ms 6.76 ms -0.02 ms (-0.28%) 1.17%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 12.93 ms 12.96 ms 0.03 ms (0.23%) 1.44%
transfer_no_resume_ring_1.3_rsa_chacha 13.54 ms 13.57 ms 0.03 ms (0.22%) 1.36%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.64 ms 13.67 ms 0.03 ms (0.22%) 1.37%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.06 ms 16.09 ms 0.03 ms (0.21%) 1.20%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.74 ms 6.73 ms -0.01 ms (-0.18%) 1.18%
handshake_no_resume_ring_1.3_rsa_aes 1.09 ms 1.09 ms 0.00 ms (0.17%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.71 ms 6.70 ms -0.01 ms (-0.17%) 1.10%
handshake_session_id_ring_1.3_ecdsap256_aes 6.74 ms 6.73 ms -0.01 ms (-0.16%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 5.95 ms 5.94 ms -0.01 ms (-0.10%) 1.23%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.82 ms 9.81 ms -0.01 ms (-0.09%) 1.00%
handshake_no_resume_ring_1.3_rsa_chacha 1.09 ms 1.09 ms 0.00 ms (0.09%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_aes 9.87 ms 9.87 ms -0.01 ms (-0.09%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 5.23 ms 5.23 ms 0.00 ms (0.09%) 1.34%
handshake_tickets_ring_1.3_rsa_chacha 7.34 ms 7.33 ms -0.01 ms (-0.08%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.18 ms 1.18 ms 0.00 ms (0.07%) 1.12%
handshake_session_id_ring_1.3_rsa_aes 7.34 ms 7.35 ms 0.01 ms (0.07%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.61 ms 3.61 ms 0.00 ms (0.06%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 5.21 ms 5.20 ms -0.00 ms (-0.06%) 1.81%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 5.93 ms 5.93 ms -0.00 ms (-0.05%) 1.54%
handshake_no_resume_ring_1.2_rsa_aes 1.07 ms 1.07 ms 0.00 ms (0.05%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.84 ms 9.83 ms -0.00 ms (-0.04%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 5.23 ms 5.23 ms 0.00 ms (0.03%) 1.58%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.61 ms 3.61 ms 0.00 ms (0.03%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 5.21 ms 5.22 ms 0.00 ms (0.03%) 1.61%
handshake_session_id_ring_1.3_rsa_chacha 7.31 ms 7.31 ms -0.00 ms (-0.03%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 5.94 ms 5.94 ms -0.00 ms (-0.02%) 1.18%
handshake_tickets_ring_1.3_rsa_aes 7.37 ms 7.37 ms -0.00 ms (-0.02%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.19 ms 1.19 ms 0.00 ms (0.01%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 5.90 ms 5.90 ms -0.00 ms (-0.01%) 1.27%
handshake_session_id_ring_1.3_ecdsap384_aes 9.83 ms 9.83 ms 0.00 ms (0.01%) 1.00%

Additional information

Historical results

Checkout details:

@cpu cpu added this pull request to the merge queue Apr 5, 2024
Merged via the queue into rustls:main with commit cc87ce1 Apr 5, 2024
25 checks passed
@cpu cpu deleted the cpu-aws-lc-rs-1.6.4 branch April 5, 2024 16:16
@djc
Copy link
Member

djc commented Apr 5, 2024

Those look like potentially substantial handshake latency regressions?

@cpu
Copy link
Member Author

cpu commented Apr 5, 2024

@justsmth Is there something top-of-mind for you that might explain performance differences between 1.6.2 and 1.6.4? 🤔

@cpu
Copy link
Member Author

cpu commented Apr 5, 2024

@djc Looking at the results closer it seems like the significant changes in the wrong direction are isolated to the instruction count benchmarks that we know can be a less accurate measure of the real world performance. The wall-time benchmarks look OK to me. Which benchmarks seem concerning to you?

@justsmth
Copy link

justsmth commented Apr 5, 2024

Short answer is that I'm not aware of any significant performance regression, but I potentially can provide insight for changes in RSA-related latencies.

I'll check our internal metrics on RSA and follow-up with you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants