Expose connection resumption details #1899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark resultsInstruction countsSignificant differencesThere are no significant instruction count differences Other differencesClick to expand
Wall-timeSignificant differencesThere are no significant wall-time differences Other differencesClick to expand
Additional informationCheckout details:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1899 +/- ##
=======================================
Coverage 95.48% 95.49%
=======================================
Files 86 86
Lines 18624 18647 +23
=======================================
+ Hits 17784 17807 +23
Misses 840 840 ☔ View full report in Codecov by Sentry. |
|
Is there any vocabulary in the spec that we could reuse? I do feel like |
cpu
approved these changes
Apr 16, 2024
This allows callers to see if their handshake was Resumed, Full, or Full-with-HelloRetryRequest (which, broadly, are the three "cost" levels for handshakes). This is exposed as soon as it is known for sure.
ctz
force-pushed
the
jbp-expose-connection-resumption-details
branch
from
a3cdc04
to
bf9bb68
Compare
cpu
approved these changes
Apr 16, 2024
djc
reviewed
Apr 16, 2024
| /// | ||
| /// This will return `Err(Error::HandshakeNotComplete)` before it is | ||
| /// known which sort of handshake occurred. | ||
| pub fn handshake_kind(&self) -> Result<HandshakeKind, Error> { |
There was a problem hiding this comment.
I'm a little surprised at the choice of Result here? IIRC most of the similar methods just return Option, which seems appropriate here, too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My goal with this is to support implementation of
SSL_session_reusedbut this should also fix #705.I'm hoping what and how this works is relatively uncontroversial, but I'm not 100% pleased with the naming.