deps: update cargo semver compatible deps #1914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1914 +/- ##
=======================================
Coverage 95.49% 95.49%
=======================================
Files 86 86
Lines 18650 18650
=======================================
Hits 17810 17810
Misses 840 840 ☔ View full report in Codecov by Sentry. |
djc
approved these changes
Apr 22, 2024
Benchmark resultsInstruction countsSignificant differencesClick to expand
Other differencesClick to expand
Wall-timeSignificant differencesClick to expand
Other differencesClick to expand
Additional informationCheckout details:
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Odd, Build+test (stable, macos-latest) failed on the |
Just wanted to leave a note that I'll spend some time figuring this out but it's lower than some other priorities ATM. I thought we excluded FIPS for the non-Linux runs so this is probably something small/silly. |
|
FWIW it's also broken on main prior to this PR: https://github.com/rustls/rustls/actions/runs/8805061439/job/24166840004 This appears to be due to macos-latest transitioning to macos-14-arm64: https://github.blog/changelog/2024-04-01-macos-14-sonoma-is-generally-available-and-the-latest-macos-runner-image/ previous (working): broken: Those "included software" pages confirm the macos-14 image doesn't come with golang preinstalled. |
Ah interesting! Thanks for taking a look.
I'm still unsure why we need Go for these builds since the FIPS support is specific to Linux 🤔 |
Discussed & fixed in #1919 - I will rebase once that gets through the merge queue. |
Updating hickory-resolver v0.24.0 -> v0.24.1 Updating serde v1.0.197 -> v1.0.198 Updating serde_derive v1.0.197 -> v1.0.198 Updating serde_json v1.0.115 -> v1.0.116 Updating aws-lc-rs v1.6.4 -> v1.7.0 Updating aws-lc-sys v0.14.1 -> v0.15.0 Updating hashbrown v0.13.2 -> v0.14.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #1910
Updating hickory-resolver v0.24.0 -> v0.24.1 diff.rs
Updating serde v1.0.197 -> v1.0.198 diff.rs
Updating serde_derive v1.0.197 -> v1.0.198 diff.rs
Updating serde_json v1.0.115 -> v1.0.116 diff.rs
Updating aws-lc-rs v1.6.4 -> v1.7.0 diff.rs
Updating aws-lc-sys v0.14.1 -> v0.15.0 diff.rs
Updating hashbrown v0.13.2 -> v0.14.3 diff.rs
Updating rustls-webpki v0.102.2 -> v0.102.3 diff.rs
Note: the
hashbrownupdate was one we were previously holding because of an MSRV 1.63 requirement that is now met. However, I also had to adjust the default features to excludeallocator-api2, it was giving errors on MSRV of the form: