Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md: fix spelling error #1933

Merged
merged 1 commit into from
May 1, 2024
Merged

README.md: fix spelling error #1933

merged 1 commit into from
May 1, 2024

Conversation

ctz
Copy link
Member

@ctz ctz commented May 1, 2024

No description provided.

Copy link

rustls-benchmarking bot commented May 1, 2024

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 4358958 4399785 40827 (0.94%) 1.65%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3905329 3882030 -23299 (-0.60%) 7.31%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 13793303 13744089 -49214 (-0.36%) 2.11%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8744241 8716357 -27884 (-0.32%) 1.12%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 32598357 32694853 96496 (0.30%) 0.71%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 30085870 30157302 71432 (0.24%) 0.32%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 30294831 30347325 52494 (0.17%) 0.40%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 13402756 13379787 -22969 (-0.17%) 0.72%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80566954 80648840 81886 (0.10%) 0.31%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 13748300 13735015 -13285 (-0.10%) 1.73%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 32345044 32374594 29550 (0.09%) 0.62%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46372761 46345429 -27332 (-0.06%) 0.37%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3364307 3366160 1853 (0.06%) 0.27%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 30352615 30368671 16056 (0.05%) 0.46%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58233366 58208335 -25031 (-0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 32384609 32398426 13817 (0.04%) 0.74%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 32633279 32645097 11818 (0.04%) 0.75%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1892338 1891777 -561 (-0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4299512 4298544 -968 (-0.02%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92682669 92702437 19768 (0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 30144599 30150898 6299 (0.02%) 0.29%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3366412 3365860 -552 (-0.02%) 0.22%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 2014863 2015190 327 (0.02%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2949274 2948806 -468 (-0.02%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46425152 46419377 -5775 (-0.01%) 0.31%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 4273012 4273489 477 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 2215593 2215825 232 (0.01%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4233737 4234106 369 (0.01%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4231905 4231574 -331 (-0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 2129414 2129258 -156 (-0.01%) 0.22%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1895034 1894906 -128 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 30359001 30357014 -1987 (-0.01%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4507715 4508004 289 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 41964994 41967613 2619 (0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58321057 58318274 -2783 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3912172 3912331 159 (0.00%) 0.23%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 30135166 30136381 1215 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2954954 2954838 -116 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 30158212 30157049 -1163 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 4276377 4276219 -158 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58233706 58231772 -1934 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 41761880 41763186 1306 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 13740107 13739681 -426 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 42037555 42038839 1284 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 30171314 30170402 -912 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 30347247 30348135 888 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 41861721 41862812 1091 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 2222733 2222676 -57 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 2131419 2131369 -50 (-0.00%) 0.35%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 32673416 32672673 -743 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92650839 92648750 -2089 (-0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4664194 4664102 -92 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 43692868 43692015 -853 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 43411912 43411103 -809 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 32649716 32649127 -589 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 12174435 12174217 -218 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 32673250 32673814 564 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 41961836 41962555 719 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 32410772 32411323 551 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 43615122 43615828 706 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 30336061 30336547 486 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58315094 58316022 928 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 41844188 41843524 -664 (-0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 43307526 43308192 666 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11985301 11985477 176 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 43310400 43310999 599 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 42050332 42050881 549 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 32411091 32411513 422 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 30145938 30146281 343 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 41850591 41851049 458 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 43409013 43409436 423 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8725585 8725504 -81 (-0.00%) 0.91%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 32371412 32371673 261 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46462186 46461835 -351 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 32371612 32371375 -237 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3916120 3916146 26 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 41767631 41767364 -267 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35473996 35473771 -225 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 68656041 68655621 -420 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46361714 46361439 -275 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 32650106 32649914 -192 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 43617689 43617945 256 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46430239 46429975 -264 (-0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 41780964 41780733 -231 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58203185 58202875 -310 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 42031748 42031968 220 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92692627 92693109 482 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 30370873 30371025 152 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 43410825 43411033 208 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92692014 92692452 438 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58319386 58319660 274 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 43617491 43617314 -177 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80506783 80507054 271 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 43310974 43311115 141 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 13737717 13737761 44 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46429757 46429881 124 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92652193 92652437 244 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80609586 80609387 -199 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58234179 58234036 -143 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 12168067 12168095 28 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 43692572 43692474 -98 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35471814 35471892 78 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80609575 80609735 160 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2856140 2856135 -5 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46457141 46457069 -72 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3972412 3972416 4 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92647341 92647411 70 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 43690354 43690324 -30 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80510431 80510475 44 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80514635 80514599 -36 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46454112 46454132 20 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 41981080 41981090 10 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_tickets_ring_1.3_ecdsap256_chacha 6.71 ms 6.67 ms -0.04 ms (-0.61%) 1.06%
handshake_session_id_ring_1.3_ecdsap256_aes 6.74 ms 6.70 ms -0.04 ms (-0.58%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_aes 6.76 ms 6.72 ms -0.04 ms (-0.55%) 1.06%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.69 ms 6.65 ms -0.04 ms (-0.53%) 1.00%
handshake_tickets_ring_1.3_rsa_aes 7.25 ms 7.21 ms -0.04 ms (-0.51%) 1.00%
handshake_session_id_ring_1.3_rsa_aes 7.23 ms 7.20 ms -0.04 ms (-0.51%) 1.00%
handshake_session_id_ring_1.2_rsa_aes 1.55 ms 1.56 ms 0.01 ms (0.50%) 1.55%
handshake_tickets_ring_1.3_rsa_chacha 7.19 ms 7.16 ms -0.03 ms (-0.48%) 1.00%
handshake_session_id_ring_1.3_rsa_chacha 7.18 ms 7.15 ms -0.03 ms (-0.46%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 478.20 µs 476.20 µs -1.99 µs (-0.42%) 4.17%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 5.27 ms 5.24 ms -0.02 ms (-0.40%) 1.01%
handshake_tickets_ring_1.3_ecdsap384_aes 9.85 ms 9.81 ms -0.04 ms (-0.39%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_aes 9.82 ms 9.79 ms -0.04 ms (-0.37%) 1.00%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 2.20 ms 2.21 ms 0.01 ms (0.37%) 1.99%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 5.98 ms 5.96 ms -0.02 ms (-0.36%) 1.00%
handshake_no_resume_ring_1.3_ecdsap256_chacha 504.03 µs 502.26 µs -1.77 µs (-0.35%) 2.34%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.78 ms 9.74 ms -0.03 ms (-0.33%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.79 ms 9.76 ms -0.03 ms (-0.32%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 5.26 ms 5.25 ms -0.01 ms (-0.27%) 1.08%
handshake_no_resume_ring_1.3_rsa_chacha 998.86 µs 996.37 µs -2.50 µs (-0.25%) 1.01%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 5.97 ms 5.96 ms -0.01 ms (-0.24%) 1.00%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 6.20 ms 6.19 ms -0.01 ms (-0.24%) 1.06%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 6.20 ms 6.19 ms -0.01 ms (-0.24%) 1.04%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 476.77 µs 475.67 µs -1.10 µs (-0.23%) 3.45%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 6.21 ms 6.19 ms -0.01 ms (-0.23%) 1.32%
transfer_no_resume_ring_1.2_rsa_aes 6.73 ms 6.75 ms 0.01 ms (0.20%) 3.28%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 5.25 ms 5.24 ms -0.01 ms (-0.20%) 1.00%
handshake_no_resume_ring_1.3_rsa_aes 997.78 µs 995.97 µs -1.81 µs (-0.18%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.19 ms 1.19 ms -0.00 ms (-0.16%) 1.08%
handshake_tickets_ring_1.2_rsa_aes 1.64 ms 1.64 ms -0.00 ms (-0.15%) 2.03%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 5.24 ms 5.24 ms -0.01 ms (-0.13%) 1.00%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 6.18 ms 6.17 ms -0.01 ms (-0.11%) 1.07%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 5.96 ms 5.96 ms -0.01 ms (-0.10%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 5.94 ms 5.93 ms -0.00 ms (-0.08%) 1.00%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.35 ms 1.35 ms -0.00 ms (-0.08%) 1.46%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.52 ms 4.51 ms -0.00 ms (-0.07%) 3.85%
handshake_no_resume_ring_1.2_rsa_aes 976.56 µs 977.20 µs 0.64 µs (0.07%) 1.04%
transfer_no_resume_ring_1.3_rsa_aes 6.83 ms 6.84 ms 0.00 ms (0.06%) 2.66%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.41 ms 1.41 ms -0.00 ms (-0.06%) 1.49%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.18 ms 1.18 ms 0.00 ms (0.05%) 1.20%
handshake_no_resume_ring_1.3_ecdsap256_aes 505.28 µs 505.51 µs 0.23 µs (0.04%) 2.93%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.45 ms 5.45 ms 0.00 ms (0.04%) 4.01%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.34 ms 6.34 ms 0.00 ms (0.03%) 2.55%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 2.05 ms 2.05 ms 0.00 ms (0.03%) 2.52%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.60 ms 3.60 ms 0.00 ms (0.03%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.23 ms 5.23 ms 0.00 ms (0.03%) 3.26%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.09 ms 16.09 ms -0.00 ms (-0.01%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.45 ms 5.45 ms -0.00 ms (-0.01%) 3.87%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.69 ms 13.69 ms -0.00 ms (-0.01%) 1.43%
transfer_no_resume_ring_1.3_rsa_chacha 13.48 ms 13.48 ms -0.00 ms (-0.01%) 1.35%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.99 ms 12.98 ms -0.00 ms (-0.01%) 1.35%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.92 ms 13.92 ms 0.00 ms (0.01%) 1.40%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.60 ms 3.60 ms 0.00 ms (0.01%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 12.97 ms 12.97 ms -0.00 ms (-0.01%) 1.47%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.44 ms 9.44 ms 0.00 ms (0.01%) 1.59%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.40 ms 1.40 ms 0.00 ms (0.00%) 1.17%

Additional information

Historical results

Checkout details:

Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.49%. Comparing base (a74f9d5) to head (d5ef115).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1933   +/-   ##
=======================================
  Coverage   95.49%   95.49%           
=======================================
  Files          86       86           
  Lines       18650    18650           
=======================================
  Hits        17810    17810           
  Misses        840      840           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ctz ctz added this pull request to the merge queue May 1, 2024
Merged via the queue into main with commit ffcc718 May 1, 2024
46 checks passed
@ctz ctz deleted the jbp-readme-typo branch May 1, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants