Rename SignatureScheme::sign

[ctz]

The old name doesn't really make sense for me.

[rustls-benchmarking]

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand

Scenario	Baseline	Candidate	Diff	Threshold
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server	4419408	4348689	-70719 (-1.60%)	1.64%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client	8761480	8718428	-43052 (-0.49%)	1.07%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server	13367142	13418878	51736 (0.39%)	0.60%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server	13740605	13701024	-39581 (-0.29%)	1.53%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server	46397523	46499433	101910 (0.22%)	0.30%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client	30090324	30145509	55185 (0.18%)	0.32%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server	13750619	13727113	-23506 (-0.17%)	0.93%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server	32677218	32725060	47842 (0.15%)	0.78%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client	30161998	30119421	-42577 (-0.14%)	0.28%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server	3892508	3897824	5316 (0.14%)	7.17%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server	46420761	46363729	-57032 (-0.12%)	0.40%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client	30299798	30334183	34385 (0.11%)	0.30%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server	32462888	32437275	-25613 (-0.08%)	0.74%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client	3366263	3368719	2456 (0.07%)	0.22%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server	80603529	80657822	54293 (0.07%)	0.24%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client	8730481	8727565	-2916 (-0.03%)	0.83%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client	30344395	30353957	9562 (0.03%)	0.43%
handshake_session_id_ring_1.2_rsa_aes_server	4231198	4232227	1029 (0.02%)	0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client	2014644	2015106	462 (0.02%)	0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server	32649103	32656143	7040 (0.02%)	0.50%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server	1894864	1895226	362 (0.02%)	0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client	2215234	2215634	400 (0.02%)	0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client	3913603	3914229	626 (0.02%)	0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client	3365124	3365653	529 (0.02%)	0.24%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client	30136170	30131577	-4593 (-0.02%)	0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server	2129486	2129799	313 (0.01%)	0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server	2131158	2131428	270 (0.01%)	0.20%
handshake_no_resume_ring_1.2_rsa_aes_client	2855860	2856216	356 (0.01%)	0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client	2222402	2222666	264 (0.01%)	0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client	30336851	30333288	-3563 (-0.01%)	0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client	4299904	4299427	-477 (-0.01%)	0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client	41770978	41766633	-4345 (-0.01%)	0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client	30354910	30357741	2831 (0.01%)	0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client	41849094	41845917	-3177 (-0.01%)	0.20%
handshake_tickets_ring_1.2_rsa_aes_client	4507650	4507947	297 (0.01%)	0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client	42037580	42034928	-2652 (-0.01%)	0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server	4276395	4276653	258 (0.01%)	0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client	2954796	2954967	171 (0.01%)	0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server	4272923	4273168	245 (0.01%)	0.20%
handshake_no_resume_ring_1.3_rsa_aes_client	2948899	2949064	165 (0.01%)	0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client	92674400	92679542	5142 (0.01%)	0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client	30156286	30157874	1588 (0.01%)	0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client	92693199	92688350	-4849 (-0.01%)	0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client	3972640	3972436	-204 (-0.01%)	0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client	30171652	30170666	-986 (-0.00%)	0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client	30347214	30348180	966 (0.00%)	0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server	1891808	1891864	56 (0.00%)	0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client	3914566	3914679	113 (0.00%)	0.20%
handshake_session_id_ring_1.2_rsa_aes_client	4233658	4233779	121 (0.00%)	0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client	92653449	92650828	-2621 (-0.00%)	0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server	43617103	43618329	1226 (0.00%)	0.20%
handshake_no_resume_ring_1.3_rsa_aes_server	12167920	12168262	342 (0.00%)	0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server	32649964	32649049	-915 (-0.00%)	0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server	32349770	32350674	904 (0.00%)	0.51%
handshake_no_resume_ring_1.3_rsa_chacha_server	12173779	12174085	306 (0.00%)	0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server	43410630	43411631	1001 (0.00%)	0.20%
handshake_tickets_ring_1.2_rsa_aes_server	4663977	4663872	-105 (-0.00%)	0.20%
handshake_tickets_ring_1.3_rsa_aes_client	42050265	42051150	885 (0.00%)	0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client	41970021	41969182	-839 (-0.00%)	0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server	32371759	32371112	-647 (-0.00%)	0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client	58230825	58229689	-1136 (-0.00%)	0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server	43411759	43410925	-834 (-0.00%)	0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client	42032067	42032842	775 (0.00%)	0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server	43692094	43691342	-752 (-0.00%)	0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client	58207710	58208710	1000 (0.00%)	0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server	13737461	13737690	229 (0.00%)	0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client	30147384	30146894	-490 (-0.00%)	0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server	32371267	32371788	521 (0.00%)	0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server	43692118	43691421	-697 (-0.00%)	0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server	32411284	32410785	-499 (-0.00%)	0.20%
handshake_session_id_ring_1.3_rsa_chacha_client	41781450	41780816	-634 (-0.00%)	0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server	32411303	32410833	-470 (-0.00%)	0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server	32673084	32673511	427 (0.00%)	0.20%
handshake_tickets_ring_1.3_rsa_chacha_server	43615836	43615285	-551 (-0.00%)	0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server	32673335	32672983	-352 (-0.00%)	0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client	30371117	30370843	-274 (-0.00%)	0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client	92651905	92652722	817 (0.00%)	0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client	35471121	35471433	312 (0.00%)	0.20%
handshake_no_resume_ring_1.2_rsa_aes_server	11985406	11985307	-99 (-0.00%)	0.20%
handshake_session_id_ring_1.3_rsa_chacha_server	43308429	43308082	-347 (-0.00%)	0.20%
handshake_tickets_ring_1.3_rsa_aes_server	43690121	43689784	-337 (-0.00%)	0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server	32649558	32649805	247 (0.00%)	0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client	92691808	92692485	677 (0.00%)	0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server	80510186	80510757	571 (0.00%)	0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client	41762958	41763242	284 (0.00%)	0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client	35473538	35473770	232 (0.00%)	0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server	43617096	43617376	280 (0.00%)	0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server	43310863	43311127	264 (0.00%)	0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client	58234550	58234213	-337 (-0.00%)	0.20%
handshake_tickets_ring_1.3_rsa_chacha_client	41980454	41980694	240 (0.00%)	0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server	46430056	46429799	-257 (-0.00%)	0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client	41844255	41844482	227 (0.00%)	0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client	68656123	68655768	-355 (-0.00%)	0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server	46430590	46430354	-236 (-0.00%)	0.20%
handshake_session_id_ring_1.3_rsa_aes_server	43408291	43408509	218 (0.00%)	0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server	13739709	13739778	69 (0.00%)	0.20%
transfer_no_resume_ring_1.2_rsa_aes_server	46361389	46361593	204 (0.00%)	0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client	41962681	41962501	-180 (-0.00%)	0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server	43310146	43309971	-175 (-0.00%)	0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server	80507352	80507045	-307 (-0.00%)	0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client	58318151	58318354	203 (0.00%)	0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client	58315771	58315963	192 (0.00%)	0.20%
handshake_session_id_ring_1.3_rsa_aes_client	41862156	41862034	-122 (-0.00%)	0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client	92647758	92647500	-258 (-0.00%)	0.20%
transfer_no_resume_ring_1.3_rsa_aes_server	46461641	46461573	-68 (-0.00%)	0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server	80609421	80609312	-109 (-0.00%)	0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server	46453603	46453662	59 (0.00%)	0.20%
transfer_no_resume_ring_1.3_rsa_aes_client	58319431	58319469	38 (0.00%)	0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server	80609245	80609193	-52 (-0.00%)	0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server	46457493	46457466	-27 (-0.00%)	0.20%
transfer_no_resume_ring_1.2_rsa_aes_client	58202955	58202929	-26 (-0.00%)	0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server	80514908	80514921	13 (0.00%)	0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand

Scenario	Baseline	Candidate	Diff	Threshold
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes	5.16 ms	5.21 ms	0.05 ms (0.88%)	4.11%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha	5.22 ms	5.26 ms	0.05 ms (0.88%)	1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes	5.94 ms	5.99 ms	0.05 ms (0.82%)	1.00%
transfer_no_resume_ring_1.3_ecdsap256_aes	6.28 ms	6.33 ms	0.05 ms (0.80%)	2.99%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha	5.24 ms	5.28 ms	0.04 ms (0.79%)	1.00%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes	4.46 ms	4.49 ms	0.03 ms (0.78%)	5.27%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes	5.24 ms	5.28 ms	0.04 ms (0.75%)	1.17%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes	5.39 ms	5.43 ms	0.04 ms (0.73%)	4.31%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes	5.23 ms	5.27 ms	0.04 ms (0.72%)	1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes	5.96 ms	6.00 ms	0.04 ms (0.71%)	1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha	5.92 ms	5.96 ms	0.04 ms (0.69%)	1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha	5.95 ms	5.99 ms	0.04 ms (0.67%)	1.00%
handshake_session_id_aws_lc_rs_1.3_rsa_aes	6.18 ms	6.22 ms	0.04 ms (0.66%)	1.00%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha	6.18 ms	6.22 ms	0.04 ms (0.65%)	1.00%
transfer_no_resume_ring_1.3_ecdsap384_aes	9.38 ms	9.44 ms	0.06 ms (0.65%)	2.28%
transfer_no_resume_ring_1.3_rsa_aes	6.77 ms	6.81 ms	0.04 ms (0.64%)	2.79%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes	5.39 ms	5.42 ms	0.03 ms (0.64%)	3.54%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha	6.16 ms	6.20 ms	0.04 ms (0.64%)	1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes	473.37 µs	476.35 µs	2.98 µs (0.63%)	4.26%
handshake_tickets_aws_lc_rs_1.3_rsa_aes	6.19 ms	6.23 ms	0.04 ms (0.61%)	1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes	1.19 ms	1.19 ms	0.01 ms (0.54%)	1.05%
transfer_no_resume_ring_1.2_rsa_aes	6.68 ms	6.72 ms	0.03 ms (0.52%)	3.23%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha	473.53 µs	475.86 µs	2.33 µs (0.49%)	3.51%
handshake_no_resume_ring_1.3_ecdsap256_chacha	499.72 µs	502.11 µs	2.39 µs (0.48%)	2.34%
handshake_no_resume_ring_1.3_ecdsap256_aes	502.23 µs	504.30 µs	2.07 µs (0.41%)	3.25%
handshake_no_resume_ring_1.3_ecdsap384_chacha	3.60 ms	3.61 ms	0.01 ms (0.41%)	1.00%
handshake_no_resume_ring_1.3_ecdsap384_aes	3.60 ms	3.61 ms	0.01 ms (0.38%)	1.00%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes	1.40 ms	1.41 ms	0.01 ms (0.37%)	1.36%
handshake_tickets_ring_1.3_ecdsap256_aes	6.72 ms	6.74 ms	0.02 ms (0.35%)	1.00%
handshake_tickets_ring_1.3_ecdsap256_chacha	6.67 ms	6.69 ms	0.02 ms (0.33%)	1.01%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha	12.91 ms	12.96 ms	0.04 ms (0.31%)	1.84%
transfer_no_resume_ring_1.3_ecdsap384_chacha	16.02 ms	16.07 ms	0.05 ms (0.31%)	1.10%
handshake_session_id_ring_1.3_ecdsap256_chacha	6.66 ms	6.68 ms	0.02 ms (0.31%)	1.00%
handshake_tickets_ring_1.2_rsa_aes	1.63 ms	1.63 ms	0.00 ms (0.30%)	2.03%
handshake_no_resume_ring_1.2_rsa_aes	973.66 µs	976.57 µs	2.90 µs (0.30%)	1.25%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha	13.63 ms	13.67 ms	0.04 ms (0.30%)	1.69%
handshake_no_resume_ring_1.3_rsa_aes	993.48 µs	996.37 µs	2.89 µs (0.29%)	1.21%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes	1.35 ms	1.35 ms	0.00 ms (0.29%)	1.46%
handshake_session_id_ring_1.3_ecdsap256_aes	6.70 ms	6.72 ms	0.02 ms (0.28%)	1.00%
transfer_no_resume_ring_1.3_ecdsap256_chacha	12.93 ms	12.97 ms	0.04 ms (0.28%)	1.59%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha	13.86 ms	13.89 ms	0.04 ms (0.26%)	1.22%
handshake_tickets_ring_1.3_ecdsap384_aes	9.82 ms	9.84 ms	0.02 ms (0.25%)	1.00%
transfer_no_resume_ring_1.3_rsa_chacha	13.42 ms	13.46 ms	0.03 ms (0.24%)	1.35%
handshake_session_id_ring_1.3_ecdsap384_aes	9.79 ms	9.82 ms	0.02 ms (0.24%)	1.00%
handshake_tickets_aws_lc_rs_1.2_rsa_aes	2.20 ms	2.21 ms	0.01 ms (0.24%)	1.80%
handshake_tickets_ring_1.3_ecdsap384_chacha	9.76 ms	9.79 ms	0.02 ms (0.23%)	1.00%
handshake_session_id_ring_1.2_rsa_aes	1.55 ms	1.55 ms	0.00 ms (0.23%)	1.33%
handshake_tickets_ring_1.3_rsa_aes	7.22 ms	7.23 ms	0.02 ms (0.22%)	1.00%
handshake_session_id_aws_lc_rs_1.2_rsa_aes	2.04 ms	2.05 ms	0.00 ms (0.22%)	1.57%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha	1.18 ms	1.18 ms	0.00 ms (0.22%)	1.15%
handshake_session_id_ring_1.3_rsa_aes	7.20 ms	7.22 ms	0.02 ms (0.22%)	1.00%
handshake_no_resume_ring_1.3_rsa_chacha	995.97 µs	998.10 µs	2.13 µs (0.21%)	1.17%
handshake_session_id_ring_1.3_ecdsap384_chacha	9.75 ms	9.77 ms	0.02 ms (0.21%)	1.00%
handshake_session_id_ring_1.3_rsa_chacha	7.15 ms	7.16 ms	0.01 ms (0.15%)	1.00%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha	1.39 ms	1.40 ms	0.00 ms (0.14%)	1.04%
handshake_tickets_ring_1.3_rsa_chacha	7.17 ms	7.18 ms	0.01 ms (0.14%)	1.00%

Additional information

Historical results

Checkout details:

• Base repo: https://github.com/rustls/rustls.git
• Base branch: main (c46cf7e)
• Candidate repo: https://github.com/rustls/rustls.git
• Candidate branch: jbp-rename-sigscheme-sign (17e6c95)

[codecov]

Codecov Report

Attention: Patch coverage is 90.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 95.49%. Comparing base (c46cf7e) to head (17e6c95).

Files	Patch %	Lines
rustls/src/client/tls12.rs	66.66%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1936   +/-   ##
=======================================
  Coverage   95.49%   95.49%           
=======================================
  Files          86       86           
  Lines       18650    18651    +1     
=======================================
+ Hits        17810    17811    +1     
  Misses        840      840           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.