Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo.lock: update rustls version under hickory #1937

Merged
merged 1 commit into from
May 3, 2024
Merged

Conversation

ctz
Copy link
Member

@ctz ctz commented May 3, 2024

This avoids a dependency on a vulnerable version of ourself.

This avoids a dependency on a vulnerable version of ourself.
Copy link

rustls-benchmarking bot commented May 3, 2024

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3958438 3921355 -37083 (-0.94%) 7.17%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 4443681 4419652 -24029 (-0.54%) 1.65%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8729313 8684426 -44887 (-0.51%) 0.87%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 13768897 13713113 -55784 (-0.41%) 1.53%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8744011 8713859 -30152 (-0.34%) 1.15%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 32385240 32472162 86922 (0.27%) 0.82%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 30090005 30161440 71435 (0.24%) 0.32%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 13334049 13364436 30387 (0.23%) 0.91%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 30360587 30407502 46915 (0.15%) 0.46%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 13733526 13713137 -20389 (-0.15%) 0.96%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46396919 46463905 66986 (0.14%) 0.30%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 32642834 32687167 44333 (0.14%) 0.78%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 30316033 30348277 32244 (0.11%) 0.35%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 32384324 32417861 33537 (0.10%) 0.52%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 30176852 30200790 23938 (0.08%) 0.29%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3365791 3368147 2356 (0.07%) 0.22%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3913955 3916175 2220 (0.06%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3914613 3912523 -2090 (-0.05%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58241592 58269646 28054 (0.05%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92649130 92686895 37765 (0.04%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80621716 80651624 29908 (0.04%) 0.25%
handshake_session_id_ring_1.2_rsa_aes_client 4234562 4233610 -952 (-0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3972865 3972063 -802 (-0.02%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4663313 4664201 888 (0.02%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 41769870 41763130 -6740 (-0.02%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4507757 4507069 -688 (-0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1895042 1894784 -258 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 2222896 2222594 -302 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 30336495 30332837 -3658 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 2215402 2215654 252 (0.01%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4231740 4231338 -402 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 41969540 41965814 -3726 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 30357674 30355288 -2386 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 42034401 42037701 3300 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 2014858 2015000 142 (0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 2131479 2131339 -140 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4299526 4299808 282 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 4276600 4276335 -265 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 32693514 32691648 -1866 (-0.01%) 0.51%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 30157818 30156336 -1482 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58315700 58318261 2561 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 2129489 2129402 -87 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 30346571 30347638 1067 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 32410587 32411701 1114 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2954836 2954932 96 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 41844847 41843646 -1201 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 32371112 32372022 910 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92653742 92651186 -2556 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 32674116 32673222 -894 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 32673862 32672976 -886 (-0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2856161 2856225 64 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11985527 11985259 -268 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 4273097 4273003 -94 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 30135023 30134381 -642 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 32371998 32371336 -662 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 30370340 30370888 548 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 32412058 32411482 -576 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 41763189 41762463 -726 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1891772 1891804 32 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 41980203 41980870 667 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 43409294 43408616 -678 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 13739885 13739676 -209 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92691949 92690552 -1397 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 30146297 30145864 -433 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35473440 35473940 500 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 32649653 32650106 453 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 32649740 32650174 434 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 43308745 43308234 -511 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46431037 46430514 -523 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 43692250 43692733 483 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92691510 92692373 863 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 12174217 12174106 -111 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58234485 58233990 -495 (-0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 41781130 41781435 305 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 43617846 43618162 316 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46461477 46461793 316 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 12168148 12168068 -80 (-0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 43690163 43690445 282 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46402623 46402901 278 (0.00%) 0.40%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92647856 92647336 -520 (-0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 41862371 41862137 -234 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58202765 58202446 -319 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 41963249 41963474 225 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2948981 2948996 15 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 43310516 43310736 220 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 43411689 43411483 -206 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46457720 46457505 -215 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46361290 46361504 214 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 42050387 42050552 165 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 43411531 43411688 157 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92652701 92652373 -328 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 41848991 41848847 -144 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 13737444 13737489 45 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35471413 35471524 111 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 43615769 43615658 -111 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58315655 58315513 -142 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46453776 46453672 -104 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3365073 3365080 7 (0.00%) 0.25%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 43618172 43618248 76 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58232471 58232376 -95 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46429911 46429842 -69 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 30170494 30170452 -42 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80510478 80510579 101 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58319429 58319364 -65 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 43692290 43692246 -44 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80506955 80507020 65 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80609249 80609296 47 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 68656000 68656040 40 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80609562 80609596 34 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 43311280 43311292 12 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80514725 80514721 -4 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 42032272 42032273 1 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.45 ms 4.50 ms 0.05 ms (1.10%) 5.39%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.17 ms 5.22 ms 0.04 ms (0.87%) 4.11%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.39 ms 5.43 ms 0.04 ms (0.83%) 3.54%
handshake_session_id_ring_1.2_rsa_aes 1.54 ms 1.55 ms 0.01 ms (0.80%) 1.35%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.39 ms 5.43 ms 0.04 ms (0.72%) 4.31%
transfer_no_resume_ring_1.2_rsa_aes 6.68 ms 6.73 ms 0.04 ms (0.67%) 3.23%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.28 ms 6.32 ms 0.04 ms (0.62%) 3.14%
transfer_no_resume_ring_1.3_rsa_aes 6.77 ms 6.82 ms 0.04 ms (0.60%) 2.79%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 473.01 µs 475.71 µs 2.71 µs (0.57%) 3.51%
handshake_no_resume_ring_1.3_ecdsap256_chacha 499.47 µs 502.21 µs 2.75 µs (0.55%) 2.35%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.38 ms 9.43 ms 0.05 ms (0.53%) 2.39%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 473.71 µs 476.03 µs 2.32 µs (0.49%) 4.26%
handshake_no_resume_ring_1.3_ecdsap256_aes 502.22 µs 504.62 µs 2.40 µs (0.48%) 3.29%
handshake_tickets_ring_1.2_rsa_aes 1.62 ms 1.63 ms 0.01 ms (0.47%) 2.03%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.19 ms 1.19 ms 0.01 ms (0.43%) 1.05%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 2.20 ms 2.21 ms 0.01 ms (0.38%) 1.95%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 2.04 ms 2.04 ms 0.01 ms (0.36%) 1.83%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.40 ms 1.41 ms 0.00 ms (0.31%) 1.36%
handshake_no_resume_ring_1.2_rsa_aes 973.45 µs 976.40 µs 2.95 µs (0.30%) 1.29%
transfer_no_resume_ring_1.3_rsa_chacha 13.42 ms 13.46 ms 0.04 ms (0.29%) 1.47%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.93 ms 12.97 ms 0.04 ms (0.29%) 1.78%
handshake_session_id_ring_1.3_ecdsap256_aes 6.69 ms 6.71 ms 0.02 ms (0.29%) 1.00%
handshake_no_resume_ring_1.3_rsa_aes 993.74 µs 996.62 µs 2.88 µs (0.29%) 1.22%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.63 ms 13.67 ms 0.04 ms (0.28%) 1.71%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.86 ms 13.90 ms 0.04 ms (0.28%) 1.22%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 5.22 ms 5.23 ms 0.01 ms (0.27%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.18 ms 1.18 ms 0.00 ms (0.27%) 1.24%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 12.92 ms 12.96 ms 0.03 ms (0.26%) 1.91%
handshake_session_id_ring_1.3_rsa_aes 7.19 ms 7.21 ms 0.02 ms (0.26%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_aes 6.72 ms 6.74 ms 0.02 ms (0.26%) 1.00%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.03 ms 16.07 ms 0.04 ms (0.25%) 1.28%
handshake_no_resume_ring_1.3_rsa_chacha 995.00 µs 997.41 µs 2.41 µs (0.24%) 1.17%
handshake_tickets_ring_1.3_ecdsap384_aes 9.80 ms 9.83 ms 0.02 ms (0.24%) 1.00%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 6.17 ms 6.19 ms 0.01 ms (0.23%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.39 ms 1.40 ms 0.00 ms (0.22%) 1.04%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.35 ms 1.35 ms 0.00 ms (0.21%) 1.52%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 6.18 ms 6.19 ms 0.01 ms (0.20%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 5.96 ms 5.97 ms 0.01 ms (0.20%) 1.00%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 6.15 ms 6.16 ms 0.01 ms (0.19%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 5.22 ms 5.23 ms 0.01 ms (0.19%) 1.00%
handshake_tickets_ring_1.3_rsa_aes 7.21 ms 7.23 ms 0.01 ms (0.19%) 1.00%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 6.18 ms 6.19 ms 0.01 ms (0.19%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.65 ms 6.67 ms 0.01 ms (0.17%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.60 ms 3.61 ms 0.01 ms (0.17%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 5.91 ms 5.92 ms 0.01 ms (0.17%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 5.94 ms 5.95 ms 0.01 ms (0.17%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.60 ms 3.60 ms 0.01 ms (0.17%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 5.94 ms 5.95 ms 0.01 ms (0.16%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.67 ms 6.68 ms 0.01 ms (0.16%) 1.01%
handshake_session_id_ring_1.3_rsa_chacha 7.14 ms 7.15 ms 0.01 ms (0.14%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_aes 9.79 ms 9.80 ms 0.01 ms (0.14%) 1.00%
handshake_tickets_ring_1.3_rsa_chacha 7.16 ms 7.17 ms 0.01 ms (0.14%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 5.24 ms 5.24 ms 0.01 ms (0.10%) 1.23%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.76 ms 9.77 ms 0.01 ms (0.10%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 5.24 ms 5.24 ms 0.00 ms (0.09%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.74 ms 9.75 ms 0.01 ms (0.07%) 1.00%

Additional information

Historical results

Checkout details:

@ctz ctz enabled auto-merge May 3, 2024 10:06
Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.49%. Comparing base (08af80a) to head (d25ac2f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1937   +/-   ##
=======================================
  Coverage   95.49%   95.49%           
=======================================
  Files          86       86           
  Lines       18650    18650           
=======================================
  Hits        17810    17810           
  Misses        840      840           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ctz ctz added this pull request to the merge queue May 3, 2024
Merged via the queue into main with commit 4ba3a0a May 3, 2024
46 checks passed
@ctz ctz deleted the jbp-fix-vuln-version branch May 3, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants