Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

key_update review follow-up #2016

Merged
merged 7 commits into from
Jun 24, 2024
Merged

key_update review follow-up #2016

merged 7 commits into from
Jun 24, 2024

Conversation

ctz
Copy link
Member

@ctz ctz commented Jun 21, 2024

Follow-on from #2003

@ctz ctz mentioned this pull request Jun 21, 2024
Merged
@codecov Codecov
Copy link

codecov bot commented Jun 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.24%. Comparing base (8a8023a) to head (640ba13).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2016   +/-   ##
=======================================
  Coverage   94.23%   94.24%           
=======================================
  Files          97       97           
  Lines       21729    21724    -5     
=======================================
- Hits        20477    20473    -4     
+ Misses       1252     1251    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented Jun 21, 2024 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3911684 3943128 31444 (0.80%) 6.36%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8723434 8705538 -17896 (-0.21%) 1.12%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 33180942 33240522 59580 (0.18%) 0.58%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 33256540 33199512 -57028 (-0.17%) 0.64%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 30840243 30888291 48048 (0.16%) 0.31%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 13753862 13774126 20264 (0.15%) 1.03%
handshake_session_id_ring_1.2_rsa_aes_server 4239124 4245346 6222 (0.15%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4672020 4678833 6813 (0.15%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 4416562 4410725 -5837 (-0.13%) 3.28%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8720515 8730491 9976 (0.11%) 0.87%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 32937922 32974739 36817 (0.11%) 0.58%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46508192 46462931 -45261 (-0.10%) 0.35%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 13761837 13749789 -12048 (-0.09%) 0.89%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4313350 4316825 3475 (0.08%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58237724 58281879 44155 (0.08%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 30629720 30651928 22208 (0.07%) 0.30%
handshake_tickets_ring_1.2_rsa_aes_client 4522448 4525576 3128 (0.07%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3988327 3990315 1988 (0.05%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 30599087 30613671 14584 (0.05%) 0.30%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1911904 1911011 -893 (-0.05%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46380351 46359547 -20804 (-0.04%) 0.42%
handshake_session_id_ring_1.2_rsa_aes_client 4254176 4256056 1880 (0.04%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 13411329 13405572 -5757 (-0.04%) 0.83%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3383307 3384645 1338 (0.04%) 0.27%
handshake_tickets_ring_1.3_ecdsap256_aes_server 43723777 43740221 16444 (0.04%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 33188615 33200854 12239 (0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 32925950 32937664 11714 (0.04%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92741247 92708863 -32384 (-0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 33189028 33200612 11584 (0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 33164568 33176061 11493 (0.03%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 32885550 32896426 10876 (0.03%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 32927486 32938306 10820 (0.03%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80649173 80674809 25636 (0.03%) 0.23%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 32885818 32896249 10431 (0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 33164358 33174268 9910 (0.03%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 43442377 43454789 12412 (0.03%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 43721491 43733233 11742 (0.03%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 43336166 43347656 11490 (0.03%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 43644252 43655575 11323 (0.03%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 43339656 43350871 11215 (0.03%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 32938558 32947040 8482 (0.03%) 0.47%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 43648423 43659197 10774 (0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 2227105 2226562 -543 (-0.02%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 43648451 43659086 10635 (0.02%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 43441964 43452406 10442 (0.02%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 43439047 43449448 10401 (0.02%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 43724896 43735338 10442 (0.02%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 42065475 42075418 9943 (0.02%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 43340567 43350774 10207 (0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 30835908 30842377 6469 (0.02%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2956674 2956094 -580 (-0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3382526 3381956 -570 (-0.02%) 0.24%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 30654766 30659596 4830 (0.02%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 2133017 2132681 -336 (-0.02%) 0.77%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 30629635 30634233 4598 (0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 30860192 30864681 4489 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 30642207 30646618 4411 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1914581 1914316 -265 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 41992743 41998461 5718 (0.01%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 42010775 42016482 5707 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 30819787 30823756 3969 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 2234033 2233748 -285 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46457463 46463142 5679 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 30842533 30846186 3653 (0.01%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 41811191 41816076 4885 (0.01%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 41891577 41896430 4853 (0.01%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 42079160 42084004 4844 (0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 2131009 2130773 -236 (-0.01%) 0.85%
handshake_session_id_ring_1.3_ecdsap384_aes_client 41873351 41877713 4362 (0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3916379 3915977 -402 (-0.01%) 0.45%
handshake_no_resume_ring_1.2_rsa_aes_client 2853511 2853222 -289 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 41793436 41797624 4188 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 42061610 42065635 4025 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 41997158 42001158 4000 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 41877553 41881235 3682 (0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58316621 58321681 5060 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 30815850 30813516 -2334 (-0.01%) 0.38%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 30618076 30619606 1530 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 2016232 2016134 -98 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 41798511 41800122 1611 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2950651 2950753 102 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 4287759 4287620 -139 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 4291406 4291281 -125 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46431426 46432652 1226 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92647633 92649563 1930 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46431518 46432371 853 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80525853 80527095 1242 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46469561 46470235 674 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92714294 92715627 1333 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58318425 58317647 -778 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46375529 46376065 536 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80610892 80611767 875 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35475435 35475066 -369 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80538247 80539083 836 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80610173 80610941 768 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46461264 46461688 424 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80529478 80530181 703 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11988138 11988042 -96 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3917658 3917686 28 (0.00%) 0.42%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35473383 35473185 -198 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 13741155 13741084 -71 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58257771 58257483 -288 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92717698 92718146 448 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 68657661 68657337 -324 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92650879 92651258 379 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58200266 58200036 -230 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 12182774 12182732 -42 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58314104 58314299 195 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 12176795 12176761 -34 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 13739123 13739085 -38 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58260536 58260674 138 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92646607 92646488 -119 (-0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.41 ms 1.42 ms 0.01 ms (0.99%) 2.82%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.36 ms 1.37 ms 0.01 ms (0.94%) 2.29%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.40 ms 1.41 ms 0.01 ms (0.89%) 3.06%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 2.05 ms 2.06 ms 0.02 ms (0.85%) 1.35%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 2.21 ms 2.22 ms 0.02 ms (0.73%) 1.00%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 6.27 ms 6.31 ms 0.04 ms (0.57%) 1.48%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 6.31 ms 6.34 ms 0.03 ms (0.53%) 1.56%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 6.29 ms 6.33 ms 0.03 ms (0.53%) 1.70%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 6.31 ms 6.34 ms 0.03 ms (0.46%) 1.66%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.40 ms 5.42 ms 0.02 ms (0.45%) 3.35%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 5.36 ms 5.38 ms 0.02 ms (0.33%) 2.11%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 6.07 ms 6.09 ms 0.02 ms (0.32%) 1.58%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 6.05 ms 6.07 ms 0.02 ms (0.31%) 1.56%
handshake_session_id_ring_1.2_rsa_aes 1.55 ms 1.55 ms 0.00 ms (0.29%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 5.36 ms 5.38 ms 0.01 ms (0.27%) 2.33%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 5.34 ms 5.36 ms 0.01 ms (0.27%) 1.72%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 6.03 ms 6.05 ms 0.02 ms (0.25%) 1.59%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 6.07 ms 6.09 ms 0.01 ms (0.24%) 2.12%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 5.33 ms 5.35 ms 0.01 ms (0.23%) 1.56%
handshake_no_resume_ring_1.3_ecdsap256_aes 506.10 µs 505.00 µs -1.10 µs (-0.22%) 2.61%
handshake_session_id_ring_1.3_rsa_aes 7.24 ms 7.25 ms 0.01 ms (0.20%) 1.00%
handshake_tickets_ring_1.2_rsa_aes 1.63 ms 1.64 ms 0.00 ms (0.20%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.41 ms 5.42 ms 0.01 ms (0.20%) 4.12%
transfer_no_resume_ring_1.2_rsa_aes 6.72 ms 6.73 ms 0.01 ms (0.19%) 3.07%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.72 ms 6.73 ms 0.01 ms (0.16%) 1.00%
handshake_session_id_ring_1.3_rsa_chacha 7.19 ms 7.21 ms 0.01 ms (0.16%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_aes 6.75 ms 6.76 ms 0.01 ms (0.11%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.74 ms 6.75 ms 0.01 ms (0.11%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_aes 9.83 ms 9.84 ms 0.01 ms (0.10%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.80 ms 9.81 ms 0.01 ms (0.10%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.19 ms 1.19 ms -0.00 ms (-0.08%) 1.00%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.40 ms 9.39 ms -0.01 ms (-0.07%) 2.26%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.88 ms 13.89 ms 0.01 ms (0.07%) 1.66%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 476.83 µs 477.16 µs 0.32 µs (0.07%) 2.81%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.83 ms 9.83 ms 0.01 ms (0.06%) 1.00%
handshake_tickets_ring_1.3_rsa_chacha 7.22 ms 7.22 ms 0.00 ms (0.05%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_aes 9.87 ms 9.86 ms -0.00 ms (-0.05%) 1.00%
handshake_no_resume_ring_1.3_rsa_aes 986.42 µs 986.00 µs -0.42 µs (-0.04%) 1.14%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.94 ms 12.95 ms 0.01 ms (0.04%) 1.62%
handshake_no_resume_ring_1.3_rsa_chacha 986.68 µs 987.08 µs 0.40 µs (0.04%) 1.21%
handshake_tickets_ring_1.3_rsa_aes 7.26 ms 7.27 ms 0.00 ms (0.04%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.47 ms 4.47 ms -0.00 ms (-0.04%) 5.03%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.60 ms 3.60 ms 0.00 ms (0.03%) 1.00%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.04 ms 16.04 ms 0.00 ms (0.03%) 1.27%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 477.49 µs 477.62 µs 0.13 µs (0.03%) 2.77%
transfer_no_resume_ring_1.3_rsa_chacha 13.43 ms 13.43 ms -0.00 ms (-0.03%) 1.42%
handshake_no_resume_ring_1.2_rsa_aes 975.99 µs 976.22 µs 0.23 µs (0.02%) 1.13%
transfer_no_resume_ring_1.3_rsa_aes 6.78 ms 6.78 ms -0.00 ms (-0.02%) 2.93%
handshake_tickets_ring_1.3_ecdsap256_aes 6.78 ms 6.78 ms 0.00 ms (0.02%) 1.00%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.30 ms 6.30 ms 0.00 ms (0.01%) 3.18%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.65 ms 13.65 ms -0.00 ms (-0.01%) 1.51%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.18 ms 1.18 ms 0.00 ms (0.01%) 1.27%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.19 ms 5.19 ms -0.00 ms (-0.01%) 4.23%
handshake_no_resume_ring_1.3_ecdsap256_chacha 502.83 µs 502.85 µs 0.02 µs (0.00%) 2.30%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.60 ms 3.60 ms 0.00 ms (0.00%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 12.94 ms 12.94 ms -0.00 ms (-0.00%) 1.56%

Additional information

Historical results

Checkout details:

djc
djc approved these changes Jun 22, 2024
View reviewed changes
Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice -- hope you felt that was still worth it.

rustls/src/client/tls13.rs Outdated Show resolved Hide resolved
@ctz ctz force-pushed the jbp-key-update-request-2 branch from 824570b to 640ba13 Compare June 24, 2024 09:43
@ctz ctz added this pull request to the merge queue Jun 24, 2024
Merged via the queue into main with commit 185cc71 Jun 24, 2024
46 checks passed
@ctz ctz deleted the jbp-key-update-request-2 branch June 24, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@cpu cpu cpu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ctz @djc @cpu