Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Bogo test working on M1 ("Apple Silicon") macOS Big Sur. #427

Merged
merged 1 commit into from Dec 5, 2020

Commits on Dec 2, 2020

  1. Get Bogo test working on M1 ("Apple Silicon") macOS Big Sur.

    Fix the "build bogo_shim if it doesn't exist" logic; it was broken even
    on Linux as newer versions of Rust don't allow `--features` to be used
    at workspace level.
    
    I had to bootstrap Go on a Linux machine using the procedure at
    golang/go#42684 (comment):
    ```
    git clone https://go.googlesource.com/go
    cd go
    git fetch https://go.googlesource.com/go refs/changes/58/272258/1 && git checkout FETCH_HEAD
    cd src
    GOOS=darwin GOARCH=arm64 ./bootstrap.bash
    ```
    
    This version of Go required me to have a go.mod file. Change the way Bogo is
    downloaded from BoringSSL's repo to get this to work. The script now uses a
    sparse checkout with depth 1, which seems pretty fast. In particular, avoid
    `wget` since my Mac doesn't have `wget` available.
    
    Remove two of the patches to Bogo that seem to not be necessary if using a
    newer version of Go. Patch the remaining patch to work with the new directory
    structure.
    
    I verified that ./runme runs the tests and spits out "PASS" at the end on both macOS
    and Linux.
    briansmith committed Dec 2, 2020
    Copy the full SHA
    9478602 View commit details
    Browse the repository at this point in the history