Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up formatting in CI #478

Merged
merged 2 commits into from
Mar 16, 2021
Merged

Set up formatting in CI #478

merged 2 commits into from
Mar 16, 2021

Conversation

djc
Copy link
Member

@djc djc commented Feb 9, 2021

No description provided.

@djc djc force-pushed the ci-fmt branch 7 times, most recently from 21167ea to 1714da8 Compare February 10, 2021 08:48
@codecov-io
Copy link

codecov-io commented Feb 10, 2021

Codecov Report

Merging #478 (00e9e0e) into main (d3c5ff6) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #478      +/-   ##
==========================================
+ Coverage   96.83%   96.85%   +0.01%     
==========================================
  Files          50       50              
  Lines        8979     9175     +196     
==========================================
+ Hits         8695     8886     +191     
- Misses        284      289       +5     
Impacted Files Coverage Δ
rustls/src/verify.rs 83.59% <100.00%> (ø)
rustls/src/verifybench.rs 100.00% <100.00%> (ø)
rustls/src/client/hs.rs 96.69% <0.00%> (-0.40%) ⬇️
rustls/src/client/tls12.rs 99.26% <0.00%> (-0.22%) ⬇️
rustls/src/server/hs.rs 97.70% <0.00%> (+0.11%) ⬆️
rustls/src/server/handy.rs 100.00% <0.00%> (+0.80%) ⬆️
rustls/src/client/handy.rs 100.00% <0.00%> (+1.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3c5ff6...d0f3066. Read the comment docs.

@djc djc force-pushed the ci-fmt branch 4 times, most recently from 778879f to 00e9e0e Compare February 17, 2021 08:20
@djc djc marked this pull request as ready for review February 17, 2021 08:20
@djc djc force-pushed the ci-fmt branch 2 times, most recently from d0f3066 to e1150e2 Compare February 17, 2021 09:09
@ctz
Copy link
Member

ctz commented Mar 10, 2021

I'd like to get #443, #537, #547 merged before attending to this. But it seems straightforward to merge -- taking e1150e2 as-is and remaking d47c1ee

@djc
Copy link
Member Author

djc commented Mar 10, 2021

I'm also generally happy to rebase my own PRs on top of this. Thanks for following up!

@djc djc force-pushed the ci-fmt branch 2 times, most recently from ef1fb7d to 4098a9d Compare March 11, 2021 14:45
@djc
Copy link
Member Author

djc commented Mar 14, 2021

Should we just get this merged? It will always be a nuisance, but I'll make a standing offer to rebase anyone's branches.

@djc
Copy link
Member Author

djc commented Mar 16, 2021

Rebased this on current main. Now seems like a pretty good time to land this?

@ctz ctz merged commit e3e626d into main Mar 16, 2021
@ctz ctz deleted the ci-fmt branch March 16, 2021 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants