Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets rid of the
WebPkiError
andWebPkiOp
types in favor of a small number ofError
variants:InvalidCertificateEncoding
-- representsBadDer
andBadDerTime
InvalidCertificateSignature
-- representsInvalidSignatureForPublicKey
InvalidCertificateSignatureType
-- representsUnsupportedSignatureAlgorithm
andUnsupportedSignatureAlgorithmForPublicKey
InvalidCertificateData
This plays off of the distinctions useful to the bogo test suite as well as the need to send a different alert for invalid encoding errors.
Alternatively, we could still combine this with
WebPkiOp
. However, my feeling is thatWebPkiOp
doesn't quite carry its weight.Fixes #782.