Don't reference ALL_CIPHER_SUITES from ClientSessionValue methods #847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
force-pushed
the
resume-cipher-suites
branch
3 times, most recently
from
10956a1
to
8c88eea
Compare
This will prevent link-time elimination of unused cipher suites. The new approach also prevents double-parsing of the CipherSuite, at the expense of moving Codec methods to inherent implementations.
djc
force-pushed
the
resume-cipher-suites
branch
from
8c88eea
to
71ac040
Compare
Codecov Report
@@ Coverage Diff @@
## main #847 +/- ##
==========================================
- Coverage 96.19% 96.16% -0.04%
==========================================
Files 59 59
Lines 9387 9380 -7
==========================================
- Hits 9030 9020 -10
- Misses 357 360 +3
Continue to review full report at Codecov.
|
Closed
ctz
approved these changes
Nov 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will prevent link-time elimination of unused cipher suites.
The new approach also prevents double-parsing of the CipherSuite,
at the expense of moving Codec methods to inherent implementations.
Fixes #846.