Skip to content

Commit

Permalink
ci: ubuntu-20.04 -> ubuntu-latest
Browse files Browse the repository at this point in the history
Changing the runner image to `ubuntu-latest` takes a Ubuntu 22.04 image
that includes GCC 11. This is notable because the latest aws-lc-rs build
script bails[0] when compiled with a GCC version affected by a `memcpy`
bug[1]. The 20.04 image uses GCC 9 and _is_ affected.

We prefer `ubuntu-latest` in our other repositories so this change
should be uncontroversial.

[0]: https://github.com/aws/aws-lc-rs/blob/575f7d0656250e5302f8a9ce2ae34b3d098799b2/aws-lc-sys/builder/cc_builder.rs#L202-L260
[1]: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95189
  • Loading branch information
cpu committed Apr 22, 2024
1 parent 6f57e3c commit b9727af
Showing 1 changed file with 17 additions and 17 deletions.
34 changes: 17 additions & 17 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ on:
jobs:
rustfmt:
name: Format
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
steps:
- name: Checkout sources
uses: actions/checkout@v4
Expand All @@ -30,7 +30,7 @@ jobs:

clippy:
name: Clippy
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
steps:
- name: Checkout sources
uses: actions/checkout@v4
Expand All @@ -46,7 +46,7 @@ jobs:

deny:
name: Cargo Deny
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
steps:
- name: Checkout sources
uses: actions/checkout@v4
Expand All @@ -64,7 +64,7 @@ jobs:
# Verify that documentation builds.
rustdoc:
name: Check for documentation errors
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
strategy:
matrix:
rust_channel:
Expand All @@ -89,7 +89,7 @@ jobs:

package:
name: Cargo Package
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
steps:
- name: Checkout sources
uses: actions/checkout@v4
Expand Down Expand Up @@ -141,37 +141,37 @@ jobs:
- features: # Default
mode: # debug
rust_channel: stable
host_os: ubuntu-20.04
host_os: ubuntu-latest

- features: --features=alloc
mode: # debug
rust_channel: stable
host_os: ubuntu-20.04
host_os: ubuntu-latest

- features: --no-default-features
mode: # debug
rust_channel: stable
host_os: ubuntu-20.04
host_os: ubuntu-latest

- features: --no-default-features --features alloc,std
mode: # debug
rust_channel: stable
host_os: ubuntu-20.04
host_os: ubuntu-latest

- features: --all-features
mode: --release
rust_channel: stable
host_os: ubuntu-20.04
host_os: ubuntu-latest

- features: --all-features
mode: # debug
rust_channel: nightly
host_os: ubuntu-20.04
host_os: ubuntu-latest

- features: --all-features
mode: # debug
rust_channel: beta
host_os: ubuntu-20.04
host_os: ubuntu-latest

- features: --all-features
mode: # debug
Expand Down Expand Up @@ -230,7 +230,7 @@ jobs:

msrv:
name: MSRV
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
steps:
- name: Checkout sources
uses: actions/checkout@v4
Expand All @@ -245,7 +245,7 @@ jobs:

cross:
name: Check cross compilation targets
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
steps:
- name: Checkout sources
uses: actions/checkout@v4
Expand Down Expand Up @@ -294,7 +294,7 @@ jobs:

coverage:
name: Measure coverage
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
steps:
- name: Checkout sources
uses: actions/checkout@v4
Expand All @@ -321,7 +321,7 @@ jobs:

nostd:
name: Verify that no-std modes do not rely on libstd
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
# a target without a pre-compiled libstd like this one will catch any use of libstd in the
# entire dependency graph whereas a target like x86_64-unknown-linux-gnu will not
env:
Expand All @@ -347,7 +347,7 @@ jobs:

feature-powerset:
name: Feature Powerset
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
steps:
- name: Checkout sources
uses: actions/checkout@v4
Expand Down

0 comments on commit b9727af

Please sign in to comment.