Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't distribute 3-clause BSD test artifacts #102

Merged
merged 2 commits into from
Jun 27, 2023

Conversation

ctz
Copy link
Member

@ctz ctz commented Jun 27, 2023

resolves #101

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #102 (8344bae) into main (ec3b2c1) will not change coverage.
The diff coverage is n/a.

❗ Current head 8344bae differs from pull request most recent head 6563e6d. Consider uploading reports for the commit 6563e6d to get more accurate results

@@           Coverage Diff           @@
##             main     #102   +/-   ##
=======================================
  Coverage   95.41%   95.41%           
=======================================
  Files          15       15           
  Lines        3272     3272           
=======================================
  Hits         3122     3122           
  Misses        150      150           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ctz ctz force-pushed the jbp-dont-distribute-bsd3-test-artifacts branch from 8344bae to 6563e6d Compare June 27, 2023 10:40
@djc
Copy link
Member

djc commented Jun 27, 2023

After this branch we don't pass cargo test in the target/package. Do you intend to fix that?

@ctz
Copy link
Member Author

ctz commented Jun 27, 2023

I don't really have any good ideas for fixing that, short of taking new dependencies, exposing crate internals or introducing a build.rs. None of those feel very good.

@djc
Copy link
Member

djc commented Jun 27, 2023

We could do something with an internal Cargo feature that is disabled by default -- but I guess it's not that important.

@cpu
Copy link
Member

cpu commented Jun 27, 2023

I don't think I have enough context on the packaging side of the equation to weigh in on this one. Happy with whatever folks think is the best path forward.

@ctz ctz added this pull request to the merge queue Jun 27, 2023
Merged via the queue into main with commit b97bbd4 Jun 27, 2023
38 checks passed
@ctz ctz deleted the jbp-dont-distribute-bsd3-test-artifacts branch June 27, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clarify license: does BSD-3-Clause actually apply to crate sources?
3 participants