Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use signature verification trait from pki-types #166

Merged
merged 3 commits into from Sep 7, 2023

Conversation

ctz
Copy link
Member

@ctz ctz commented Sep 6, 2023

No description provided.

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #166 (e1f5cb6) into main (7e38e97) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #166   +/-   ##
=======================================
  Coverage   96.61%   96.62%           
=======================================
  Files          15       15           
  Lines        4463     4442   -21     
=======================================
- Hits         4312     4292   -20     
+ Misses        151      150    -1     
Files Changed Coverage Δ
src/crl.rs 99.53% <ø> (ø)
src/end_entity.rs 100.00% <ø> (ø)
src/verify_cert.rs 97.83% <ø> (ø)
src/ring_algs.rs 100.00% <100.00%> (ø)
src/signed_data.rs 100.00% <100.00%> (+1.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ctz ctz force-pushed the jbp-sigver-types-in-pki-types branch from 1045ac8 to 7604bba Compare September 7, 2023 08:26
@ctz ctz marked this pull request as ready for review September 7, 2023 08:28
@ctz ctz marked this pull request as draft September 7, 2023 09:31
@ctz ctz force-pushed the jbp-sigver-types-in-pki-types branch from 7604bba to 701815a Compare September 7, 2023 10:08
@ctz ctz force-pushed the jbp-sigver-types-in-pki-types branch from 701815a to 3842312 Compare September 7, 2023 10:09
@ctz ctz marked this pull request as ready for review September 7, 2023 10:10
src/signed_data.rs Outdated Show resolved Hide resolved
@ctz ctz force-pushed the jbp-sigver-types-in-pki-types branch from 3842312 to 86f260b Compare September 7, 2023 10:25
@djc
Copy link
Member

djc commented Sep 7, 2023

(The commit message still describes the pki-types 0.1.2 situation, maybe clean that up to prevent future confusion?)

Some minor changes in how `AlgorithmIdentifier` is constructed and tested for
equality against a slice/`untrusted::Input`.
@ctz ctz force-pushed the jbp-sigver-types-in-pki-types branch from 86f260b to e1f5cb6 Compare September 7, 2023 10:38
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@ctz ctz added this pull request to the merge queue Sep 7, 2023
Merged via the queue into main with commit ea75ebb Sep 7, 2023
46 checks passed
@ctz ctz deleted the jbp-sigver-types-in-pki-types branch September 7, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants