Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

derive Debug for RingAlgorithm, AwsLcRsAlgorithm #212

Merged
merged 2 commits into from Nov 29, 2023

Conversation

cpu
Copy link
Member

@cpu cpu commented Nov 28, 2023

The SignatureVerificationAlgorithm in pki-types was changed to have a Debug bound (rustls/pki-types#13), so these type needs to be Debug to implement the trait.

@cpu cpu changed the title ring_algs: derive Debug for RingAlgorithm derive Debug for RingAlgorithm, AwsLcRsAlgorithm Nov 28, 2023
The `SignatureVerificationAlgorithm` in pki-types was changed to have
a `Debug` bound, so these types needs to be `Debug` to implement the
trait.
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (6a8ae20) 97.21% compared to head (ebd4ccc) 97.16%.

Files Patch % Lines
src/aws_lc_rs_algs.rs 0.00% 1 Missing ⚠️
src/ring_algs.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #212      +/-   ##
==========================================
- Coverage   97.21%   97.16%   -0.05%     
==========================================
  Files          19       19              
  Lines        4266     4268       +2     
==========================================
  Hits         4147     4147              
- Misses        119      121       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@GlenDC GlenDC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (FWIW)

@cpu cpu added this pull request to the merge queue Nov 29, 2023
Merged via the queue into rustls:main with commit 20daab2 Nov 29, 2023
28 of 30 checks passed
@cpu cpu deleted the cpu-debug-for-ring-algo branch November 29, 2023 21:09
@cpu
Copy link
Member Author

cpu commented Nov 29, 2023

  • Pushed v/0.102.0-alpha.8 tag
  • Published rustls-webpki v0.102.0-alpha.8 at registry crates-io
  • Created a GitHub release - it looks like we didn't make one for alpha.7 so I included the changes since .6 in the description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants