Add notice ed25519-dalek
#1361
Closed
Add notice ed25519-dalek
#1361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pinkforest <36498018+pinkforest@users.noreply.github.com>
Signed-off-by: pinkforest <36498018+pinkforest@users.noreply.github.com>
pinkforest
added
crypto
|
The associated issue has been closed, so I'm going to go ahead and close this as well. However, the fix still hasn't shipped to crates.io; if it turns out that crates.io releases are infeasible, we might need to revive this PR. |
|
We still need to notify about older versions re: PK Oracle - I've re-opened and further clarified the tracking issue that reflected this. I will edit the PR in a moment to remove the unmaintained part of it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1360
NOTE: This does NOT necessarily mean the crypto on ed25519-dalek is inherently broken or insecure as of now
e.g. Depending on how we classify / see broken / insecure - people often see crypto-failure where pub API was not misused
dalek-cryptography/ed25519-dalek#192
dalek-cryptography/ed25519-dalek#209
dalek-cryptography/ed25519-dalek#205
EDIT: This is about older versions having pub API weakness which needs a notice. Not a maintenance issue at this stage.
Will Merge when the new release is merged which is still some time away.