Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto generate platforms crate #516

Merged
merged 219 commits into from Apr 23, 2022
Merged

Auto generate platforms crate #516

merged 219 commits into from Apr 23, 2022

Conversation

Shnatsel
Copy link
Member

@Shnatsel Shnatsel commented Mar 5, 2022 •
edited

  • Implement an auto-generator for platforms crate data
  • Generate a new version of it, 3.0.0-alpha.1 using the generator
  • Add two new fields, target_endian and target_pointer_width
  • Mark the Platform struct #[non_exhaustive]
  • Update platforms crate tests not to depend on data that evolves over time
  • Add a script to re-generate the platforms crate (excluding the README.md)
  • Update the in-tree rustsec crate to use platforms 3.0
  • Remove hacky cfg tricks to report some of the properties of the current platform; superseded by current_platform crate

Closes #513

@Shnatsel
Initial boilerplate for auto-generating the platforms crate data
a2babe3
@Shnatsel
Initial implementation of platforms crate auto-generation; can genera…
095f7c6 
…te list of targets, sans the conversion to enum values and tiers
@Shnatsel
Refactor and speed up gathering target info from rustc
97bc3bc
@Shnatsel
Also print endianness and pointer width
fc0197d
@Shnatsel
WIP enum utils
02dc814
@Shnatsel
pub(crate) to get correct unused warnings
8f67be4
@Shnatsel
Auto-generate enum definitions
f179c19
@Shnatsel
Generate proper stuct definitions, incl. names
923823b
@Shnatsel
Beginnings of markdown documentation parser
b7641b8
@Shnatsel
cargo fmt
58d9cf6
@Shnatsel
Finish implementation of doc file parsing (but not debugging of it, lol)
a59071b
@Shnatsel
more unit tests and asserts
417e9a8
@Shnatsel
found the bug lol
149694b
@Shnatsel
Validate that markdown and rustc agree on the list of supported targets
dc432ea
@Shnatsel
Work around rust-lang/rust#94475
b5f68d6
@Shnatsel
Wire up documentation data to auto-generation; now writes tier and a …
e235874 
…doc commment
@Shnatsel
cargo fmt; plus added an opt-out from formatting
1e167bb
@Shnatsel
comment
a179650
@Shnatsel
Add a list of exceptions to the straightforward naming scheme as a do…
95bcd59 
…c comment
@Shnatsel
Implement exceptions in enum variant naming, add a unit test
9df0ea4
@Shnatsel
Add #[must_use] annotations
a804983
@Shnatsel
Comment
7904684
@Shnatsel
More #[must_use] on pure functions
b1fbb5a
@Shnatsel
Rename doc parser module and types for consistency
d3e5d0f
@Shnatsel
Add docs
abe4e7a
@Shnatsel
Start refactoring writing: configurable output location, separate module
63753c8
@Shnatsel
Refactoring: Split iteration over targets from struct writing
7f65cab
@Shnatsel
cargo fmt
5706b2f
@Shnatsel
docs
e9f1e43
@Shnatsel
Split enum writing into a separate function
2b79167
@Shnatsel @tarcieri
platforms: Regenerate README.md
5d1f6bd
@Shnatsel @tarcieri
cargo fmt
ae393e1
@Shnatsel @tarcieri
cargo fmt
7d4fea2
@Shnatsel @tarcieri
update outdated tests
08c4392
@Shnatsel @tarcieri
Revert "update outdated tests"
c41c3c1 
This reverts commit 92aa620.
@Shnatsel @tarcieri
Test glob matching on fixed data instead of evolving production data
f2b6505
@Shnatsel @tarcieri
cargo fmt
99f8013
@Shnatsel @tarcieri
Add a script to regenerate the platforms crate
53577b1
@Shnatsel @tarcieri
add #![allow(missing_docs)]
8191158
@Shnatsel @tarcieri
cargo fmt
61f6906
@Shnatsel @tarcieri
remove platforms-data-gen from workspace because 2021 edition breaks …
8adc6db 
…CI that's set up to use rustc 1.40; somehow adding it to exclude list has no effect
@Shnatsel @tarcieri
cargo fmt
7f1846a
@Shnatsel @tarcieri
use TryFrom trait from core, not std
dfb5158
@Shnatsel @tarcieri
Test feasibility of detecting target triple from cfg values
0396b37
@Shnatsel @tarcieri
Move detection feasibility test to a non-auto-generated file
69d5382
@Shnatsel @tarcieri
Expand doc comment on detection feasibility test
c81ec08
@tarcieri tarcieri reopened this Apr 16, 2022
@tarcieri
Copy link
Member

@Shnatsel can you check if I rebased correctly now? (or rebase and force push yourself)

@tarcieri
Copy link
Member

@Shnatsel okay, we're to an error I think you mentioned before. This advisory:

https://github.com/rustsec/advisory-db/blob/main/crates/time/RUSTSEC-2020-0071.md

...contains a list of bogus OSes. It doesn't like capital-R redox, and there's "rolaris" where ostensibly it should be "solaris".

I think we should just remove that OS list from that advisory? That's not how it's intended to be used.

@Shnatsel
Copy link
Member Author

Yeah, there's a bunch of bogus platforms there. We should change the advisory to conform to the actual list of platforms we support.

@Shnatsel
Copy link
Member Author

I've fixed the problematic advisory in rustsec/advisory-db#1222

@Shnatsel
Copy link
Member Author

CI is now green.

@tarcieri tarcieri merged commit 6699d1d into main Apr 23, 2022
@tarcieri tarcieri deleted the auto-generate-platforms-crate branch April 23, 2022 14:09
@tarcieri tarcieri mentioned this pull request Apr 23, 2022
Merged
@ascjones ascjones mentioned this pull request Apr 25, 2022
Merged
@Shnatsel Shnatsel mentioned this pull request Aug 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarcieri tarcieri Awaiting requested review from tarcieri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Auto-generate the platforms crate
2 participants
@Shnatsel @tarcieri