Skip to content

Commit

Permalink
Remove the criterion dependency and add comment to re-add it to run b…
Browse files Browse the repository at this point in the history
…enchmarks.

We are forced to remove the dependency because of the Cargo bug rust-lang/cargo#4866 that would break compilation for #[no-std].

In practice, this means benchmarks will not compile any more unless we manually uncomment the criterion dependency.
  • Loading branch information
sebcrozet committed Mar 31, 2019
1 parent 7dbff7c commit 86fa4be
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,11 @@ alga = { git = "https://github.com/rustsim/alga", branch = "dev" }
[dev-dependencies]
serde_json = "1.0"
rand_xorshift = "0.1"
# Newer vesrion of criterion make the compilation with no-std fail.
# This problem is partly due to https://github.com/rust-lang/cargo/issues/1796
criterion = "=0.2.7"
### Uncomment this line before running benchmarks.
### We can't just let this uncommented because that would breack
### compilation for #[no-std] because of the terrible Cargo bug
### https://github.com/rust-lang/cargo/issues/4866
#criterion = "0.2.10"

[workspace]
members = [ "nalgebra-lapack", "nalgebra-glm" ]
Expand Down

0 comments on commit 86fa4be

Please sign in to comment.