Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace fs2 with fs4 #25

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Conversation

BobBinaryBuilder
Copy link

@BobBinaryBuilder BobBinaryBuilder commented Sep 22, 2023

The fs2 crate is not maintained anymore and has been forked to fs4.

Trying to build binary-install on a illumos host fails because of an missing cfg target for illumos in fs2 unix.rs. The corresponding pull request on their side has not been merged within 3 years besides the recommendation to switch from fs2 to fs4 (see danburkert/fs2-rs#32).

Changed dependencies from fs2 to fs4 to allow binary-install to build on illumos hosts primarily but also because fs2 is not maintained anymore.

The fs2 crate is not maintained anymore and has been forked to fs4.
Copy link
Member

@drager drager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@drager drager merged commit 3419c47 into rustwasm:master Sep 28, 2023
3 checks passed
@BobBinaryBuilder BobBinaryBuilder deleted the fs2-to-fs4 branch October 4, 2023 09:26
@BobBinaryBuilder
Copy link
Author

Thanks a lot for merging @drager. Will this also get published on crates.io?
wasm-pack with the dependency to binary-install still fails to build via cargo install on illumos hosts.

@drager
Copy link
Member

drager commented Oct 6, 2023

Thanks a lot for merging @drager. Will this also get published on crates.io? wasm-pack with the dependency to binary-install still fails to build via cargo install on illumos hosts.

Yes, will try to publish this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants