Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to output version numbers in cache download directory #7

Merged
merged 2 commits into from Feb 13, 2020
Merged

Add ability to output version numbers in cache download directory #7

merged 2 commits into from Feb 13, 2020

Conversation

EverlastingBugstopper
Copy link
Collaborator

No description provided.

@EverlastingBugstopper EverlastingBugstopper force-pushed the avery/version-version-version-version-version-version branch 2 times, most recently from ab63b9b to c594179 Compare January 17, 2020 18:16
@EverlastingBugstopper EverlastingBugstopper force-pushed the avery/version-version-version-version-version-version branch from c594179 to de69baf Compare January 17, 2020 22:21
@EverlastingBugstopper EverlastingBugstopper changed the title [wip] put version numbers in cache download directory Add ability to output version numbers in cache download directory Jan 17, 2020
@EverlastingBugstopper EverlastingBugstopper mentioned this pull request Jan 17, 2020
Merged
@drager
Copy link
Member

drager commented Jan 20, 2020

I think the code looks good! Looks like the tests are failing on Windows. However, I don't think it's your fault. Will have to investigate what's causing it to fail.

@EverlastingBugstopper
Copy link
Collaborator Author

Yeah it seems as if the Rust install is borked for some reason

"C:\windows\system32\cmd.exe" /D /E:ON /V:OFF /S /C "CALL "D:\a\_temp\843ee89d-39b1-4759-9b02-86d05d918cbc.cmd""
info: profile set to 'default'
info: default host triple is i686-pc-windows-msvc
error: toolchain 'stable' is not installed
error: caused by: not a directory: 'C:\Users\VssAdministrator\.rustup\toolchains\stable-i686-pc-windows-msvc'

@drager
Copy link
Member

drager commented Jan 21, 2020

@EverlastingBugstopper Yeah... I'm currently investigating it

@drager
Copy link
Member

drager commented Jan 21, 2020

@EverlastingBugstopper I have pushed a fix for the CI into master. Rebase master into your branch and the tests should pass!

@drager
Copy link
Member

drager commented Feb 13, 2020

@EverlastingBugstopper Want to try and merge master into your branch?

@EverlastingBugstopper
Copy link
Collaborator Author

whoopps - completely forgot about this

@drager drager merged commit 2e94979 into rustwasm:master Feb 13, 2020
@aleclarson
Copy link

aleclarson commented Mar 17, 2020 •
edited

Can this be published now? Need it for cloudflare/wrangler-legacy#1003

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@EverlastingBugstopper @drager @aleclarson