Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make RequestBuilder and ResponseBuilder public for docs #359

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Make RequestBuilder and ResponseBuilder public for docs #359

merged 1 commit into from
Jul 24, 2023

Conversation

haileys
Copy link
Contributor

@haileys haileys commented Jul 24, 2023 •
edited by ranile
Loading

Docs are not currently generated for RequestBuilder or ResponseBuilder:

image

These types need to be made public here to fix this

fixes #353

@flosse
Copy link
Contributor

flosse commented Jul 24, 2023

Are the any blockers?
This PR also fixes #353 😃
It would be cool to have this fixed soon.

ranile
ranile approved these changes Jul 24, 2023
View reviewed changes
Copy link
Collaborator

@ranile ranile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@ranile ranile merged commit 859e7d2 into rustwasm:master Jul 24, 2023
7 checks passed
@ranile
Copy link
Collaborator

ranile commented Jul 24, 2023 •
edited
Loading

Released in gloo-net 0.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ranile ranile ranile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gloo_net's RequestBuilder is not public
3 participants
@haileys @flosse @ranile