Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The wasm-bindgen-test runtime should capture all console logging methods #1183

Closed
2 of 5 tasks
fitzgen opened this issue Jan 15, 2019 · 1 comment
Closed
2 of 5 tasks

The wasm-bindgen-test runtime should capture all console logging methods #1183

fitzgen opened this issue Jan 15, 2019 · 1 comment
Labels
wasm-bindgen-test The wasm-bindgen-test crate

Comments

@fitzgen
Copy link
Member

fitzgen commented Jan 15, 2019

Right now, we capture console.log and console.error, but there are quite a few more: https://developer.mozilla.org/en-US/docs/Web/API/Console#Methods

In particular, we should capture the console methods used by the console_log logging backend: https://github.com/iamcodemaker/console_log#details

  • console.debug()
  • console.log()
  • console.info()
  • console.warn()
  • console.error()
@fitzgen fitzgen added the wasm-bindgen-test The wasm-bindgen-test crate label Jan 15, 2019
@fitzgen
Copy link
Member Author

fitzgen commented Jan 15, 2019

Whipping up a patch.

fitzgen added a commit to fitzgen/wasm-bindgen that referenced this issue Jan 15, 2019
@fitzgen
wasm-bindgen-test: Capture more console logging methods' output
41eefa7 
Fixes rustwasm#1183
@fitzgen fitzgen mentioned this issue Jan 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wasm-bindgen-test The wasm-bindgen-test crate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fitzgen