Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should .slice called on TypedArray return the same type as the original? #1317

Closed
ibaryshnikov opened this issue Mar 6, 2019 · 2 comments
Closed
Labels

Comments

@ibaryshnikov
Copy link
Member

Summary

In JS for example .slice called on Int32Array will return Int32Array.
In wasm-bindgen there is

pub fn slice(this: &Int32Array, begin: u32, end: u32) -> Uint8ClampedArray;

Should it return Int32Array instead?

@alexcrichton
Copy link
Contributor

Thanks for the report! I think that this may actually just be a typo, want to send a PR to correct it?

@ibaryshnikov
Copy link
Member Author

Yes, I'd like to fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants