Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasm-bindgen-test failed to deserialize module with SIMD #2522

Closed
calebzulawski opened this issue Apr 11, 2021 · 2 comments · Fixed by #2529
Closed

wasm-bindgen-test failed to deserialize module with SIMD #2522

calebzulawski opened this issue Apr 11, 2021 · 2 comments · Fixed by #2529
Labels

Comments

@calebzulawski
Copy link

An example from CI: https://travis-ci.com/github/rust-lang/stdsimd/jobs/497585556

Error: failed to deserialize wasm module

Caused by:

    0: failed to parse code section

    1: Unknown 0xfd opcode (at offset 568559)

This occurred after I added SIMD comparisons (simd_eq, etc) to tests, which looks like it's fixed in bytecodealliance/wasm-tools#222, so hopefully it's a matter of "just" updating dependencies.

alexcrichton added a commit to alexcrichton/wasm-bindgen that referenced this issue Apr 15, 2021
alexcrichton added a commit that referenced this issue Apr 16, 2021
@workingjubilee
Copy link

I do not mean to be a bother, but please reopen this, or if I should direct this to another repository, then please tell me where. This remains an issue, you see, even when I did pull in wasm-bindgen from trunk.

Error: failed to deserialize wasm module

Caused by:
    0: failed to parse code section
    1: Unknown 0xfd opcode (at offset 462132)
error: test failed, to rerun pass '--test f32_ops'
Error: Running Wasm tests with wasm-bindgen-test failed
Caused by: failed to execute `cargo test`: exited with exit code: 1
  full command: "cargo" "test" "--release" "--target" "wasm32-unknown-unknown"

This was used in the root Cargo.toml of the workspace:

[patch.crates-io]
wasm-bindgen = { git = "https://github.com/rustwasm/wasm-bindgen" }
wasm-bindgen-test = { git = "https://github.com/rustwasm/wasm-bindgen" }

The commands I used were

> $Env:RUSTFLAGS="-Ctarget-feature=+simd128"
> wasm-pack test --release --firefox crates/core_simd

@workingjubilee
Copy link

Ah, I am told (more or less) that we have to wait on the update to cascade to wasm-pack, it seems. Though I suppose we could also restructure our tests to use another test runner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants