Don't use path dependencies in examples #1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates all examples to not use `path` dependencies but rather use versioned dependencies like would typically be found in the wild. This should hopefully make the examples more copy-pastable and less alien to onlookers! The development of the examples remains the same where they continue to use the `wasm-bindgen`, `js-sys`, `web-sys`, etc from in-tree. The workspace-level `[patch]` section ensures that they use the in-tree versions instead of the crates.io versions.
alexcrichton
force-pushed
the
example-changes
branch
from
d1f032c
to
56400c3
Compare
mstange
added a commit
to mstange/wasm-bindgen
that referenced
this pull request
May 11, 2020
The path dependency was turned into a regular version dependency in PR rustwasm#1015, so it doesn't need to be called out as special anymore. This commit also changes the phrasing in the preceding sentence.
alexcrichton
pushed a commit
that referenced
this pull request
May 11, 2020
The path dependency was turned into a regular version dependency in PR #1015, so it doesn't need to be called out as special anymore. This commit also changes the phrasing in the preceding sentence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates all examples to not use
pathdependencies butrather use versioned dependencies like would typically be found in the
wild. This should hopefully make the examples more copy-pastable and
less alien to onlookers!
The development of the examples remains the same where they continue to
use the
wasm-bindgen,js-sys,web-sys, etc from in-tree. Theworkspace-level
[patch]section ensures that they use the in-treeversions instead of the crates.io versions.