Implement transitive support for NPM dependencies #1305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fitzgen
approved these changes
Mar 22, 2019
alexcrichton
force-pushed
the
npm-dependencies
branch
from
8034368
to
dfaed38
Compare
This commit implements [RFC 8], which enables transitive and transparent dependencies on NPM. The `module` attribute, when seen and not part of a local JS snippet, triggers detection of a `package.json` next to `Cargo.toml`. If found it will cause the `wasm-bindgen` CLI tool to load and parse the `package.json` within each crate and then create a merged `package.json` at the end. [RFC 8]: rustwasm/rfcs#8
alexcrichton
force-pushed
the
npm-dependencies
branch
4 times, most recently
from
2ef2b7d
to
df0e547
Compare
We have very few tests today so this starts to add the basics of a test suite which compiles Cargo projects on-the-fly which will hopefully help us bolster the amount of assertions we can make about the output.
alexcrichton
force-pushed
the
npm-dependencies
branch
from
df0e547
to
362777f
Compare
|
Ok I've opened a follow-up for this in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements RFC 8, which enables transitive and transparent
dependencies on NPM. The
moduleattribute, when seen and not part of alocal JS snippet, triggers detection of a
package.jsonnext toCargo.toml. If found it will cause thewasm-bindgenCLI tool to loadand parse the
package.jsonwithin each crate and then create a mergedpackage.jsonat the end.