Rewrite the parallel raytracing example with rayon
#1380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we'll want to hold off on merging this until the upstream rayon PR is merged, but I wanted to post this for others interested! |
alexcrichton
force-pushed
the
rayon-example
branch
from
7f31e7f
to
badf5c1
Compare
cuviper
reviewed
Mar 21, 2019
alexcrichton
force-pushed
the
rayon-example
branch
from
badf5c1
to
a76a1e6
Compare
alexcrichton
force-pushed
the
rayon-example
branch
from
a76a1e6
to
a77eecd
Compare
alexcrichton
force-pushed
the
rayon-example
branch
from
a77eecd
to
2e1030e
Compare
|
And now updated with the merged API on rayon-rs/rayon#636! r? @fitzgen |
|
Or actually you've already approved so I'll merge when green |
cuviper
reviewed
Jun 5, 2019
One of the best parts about concurrency in Rust is using `rayon` and how easy it makes parallelization of tasks, so it's the ideal example for parallel Rust on the web! Previously we've been unable to use `rayon` because there wasn't a way to customize how rayon threads themselves are spawned, but [that's now being developed for us][rayon]! This commit uses that PR to rewrite the `raytrace-parallel` example in this repository. While not a perfect idiomatic representation of using `rayon` I think this is far more idiomatic than the previous iteration of `raytrace-parallel`! I'm hoping that we can continue to iterate on this, but otherwise show it off as a good example of parallel Rust on the web. [rayon]: rayon-rs/rayon#636
alexcrichton
force-pushed
the
rayon-example
branch
from
2e1030e
to
eafc602
Compare
|
Thanks so much again for the help in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the best parts about concurrency in Rust is using
rayonand howeasy it makes parallelization of tasks, so it's the ideal example for
parallel Rust on the web! Previously we've been unable to use
rayonbecause there wasn't a way to customize how rayon threads themselves are
spawned, but that's now being developed for us!
This commit uses that PR to rewrite the
raytrace-parallelexample inthis repository. While not a perfect idiomatic representation of using
rayonI think this is far more idiomatic than the previous iterationof
raytrace-parallel! I'm hoping that we can continue to iterate onthis, but otherwise show it off as a good example of parallel Rust on
the web.
Closes #1349