Fix instantiation with a Module
#1419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the `init` function when passed a `WebAssembly.Module`. Upon closer reading of the [spec] we see there's two possible return values from `WebAssembly.instantiate`. If passed a `Module`, it will return only the `Instance`. If passed a buffer source, though, it'll return an object with the module/instance. The fix here is to check the result value is an `Instance`, and if so assume the input must have been a module so it's paired up in the output. Closes rustwasm#1418 [spec]: http://webassembly.github.io/spec/js-api/index.html#webassembly-namespace
alexcrichton
force-pushed
the
init-is-hard
branch
from
5bbd0e6
to
e3473f5
Compare
fitzgen
approved these changes
Apr 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the
initfunction when passed aWebAssembly.Module. Upon closer reading of the spec we see there'stwo possible return values from
WebAssembly.instantiate. If passed aModule, it will return only theInstance. If passed a buffer source,though, it'll return an object with the module/instance.
The fix here is to check the result value is an
Instance, and if soassume the input must have been a module so it's paired up in the
output.
Closes #1418