Fix __wbindgen_object_drop_ref unnecessary bindings
#1504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue where bindings for `__wbindgen_object_drop_ref` are generated even if the function isn't actually used by the final wasm file. This is currently due to the fact that we run gc passes pretty late in wasm-bindgen and one of the intrinsics that ended up getting gc'd referenced the `__wbindgen_object_drop_ref` intrinsic function. The fix here is somewhat naive by just updating the intrinsic to not actually use `__wbindgen_object_drop_ref`. This may not be a long-term solution but it should be good enough for now at least.
fitzgen
approved these changes
May 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue where bindings for
__wbindgen_object_drop_refare generated even if the function isn'tactually used by the final wasm file. This is currently due to the fact
that we run gc passes pretty late in wasm-bindgen and one of the
intrinsics that ended up getting gc'd referenced the
__wbindgen_object_drop_refintrinsic function.The fix here is somewhat naive by just updating the intrinsic to not
actually use
__wbindgen_object_drop_ref. This may not be a long-termsolution but it should be good enough for now at least.
Closes #1498