Add Array#flat and Array#flatMap to js-sys (fixes #1454) #1573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not-an-aardvark
commented
Jun 3, 2019
| #[wasm_bindgen(method, js_name = flatMap)] | ||
| pub fn flat_map( | ||
| this: &Array, | ||
| callback: &mut dyn FnMut(JsValue, u32, Array) -> Vec<JsValue>, |
There was a problem hiding this comment.
I wasn't sure of the best type to use for the callback here. In JS, it's possible for the flatMap callback to return a non-array value v, which has the same effect as returning the one-element array [v]. But it seems cleaner to be more strict in the Rust type.
I think Vec<JsValue> is the most appropriate return value here (as opposed to e.g. a slice), but it might be worth double-checking this; I don't have a lot of experience with lifetimes.
|
Looks great to me and I agree this is a good signature for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
Array#flatandArray#flatMaptojs-sys. These JS proposals both reached stage 4 in January, as noted in #1454.This is my first time working with
wasm-bindgen, so please review thoroughly.