Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make HTMLHyperlinkElementUtils a mixin, not a NoInterfaceObject #1604

Merged
merged 1 commit into from
Jun 17, 2019
Merged

Make HTMLHyperlinkElementUtils a mixin, not a NoInterfaceObject #1604

merged 1 commit into from
Jun 17, 2019

Conversation

marienz
Copy link
Contributor

@marienz marienz commented Jun 17, 2019

Fixes #1315.

@marienz
Make HTMLHyperlinkElementUtils a mixin, not a NoInterfaceObject
46e3cd5 
Commit b8afa0a converted several interfaces
from NoInterfaceObject to mixins. It looks like it missed
HTMLHyperlinkElementUtils: it did update the interfaces that use
HTMLHyperlinkElementUtils (from "implements" to "includes"), but did not mark
HTMLHyperlinkElementUtils as a mixin.

Fix it, which makes HtmlAnchorElement gain useful functions like `set_href`.
@alexcrichton alexcrichton merged commit 1aa6773 into rustwasm:master Jun 17, 2019
@alexcrichton
Copy link
Contributor

Thanks!

@marienz marienz deleted the link-utils-mixin branch June 18, 2019 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Anchor tag does not contain href property
2 participants
@marienz @alexcrichton