Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings in raytrace-parallel example #1738

Merged
merged 1 commit into from Aug 28, 2019
Merged

Fix warnings in raytrace-parallel example #1738

merged 1 commit into from Aug 28, 2019

Conversation

ghost
Copy link

@ghost ghost commented Aug 27, 2019

This fixes two warnings I'm seeing in the raytrace-parallel example when running cargo build --all with nightly-2019-08-23-x86_64-apple-darwin.

@alexcrichton
Copy link
Contributor

Thanks! This warning doesn't actually happen on wasm so perhaps at the top of pool.rs you could put #![cfg_attr(not(target_arch = "wasm32"), allow(dead_code))]?

(with a comment indicating why it's there)

@ghost
Copy link
Author

ghost commented Aug 28, 2019

@alexcrichton thanks. I've made the requested change along with a comment.

@alexcrichton alexcrichton merged commit 1f39a30 into rustwasm:master Aug 28, 2019
@alexcrichton
Copy link
Contributor

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants