Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix return type of WebIDL indexing getters #1789

Merged
merged 9 commits into from
Oct 4, 2019
Merged

Fix return type of WebIDL indexing getters #1789

merged 9 commits into from
Oct 4, 2019

Commits on Sep 25, 2019

  1. Wrap the return type of indexing getters as Option<T> if necessary.

    @j-devel
    j-devel committed Sep 25, 2019
    Configuration menu
    Copy the full SHA
    547f3dd View commit details
    Browse the repository at this point in the history

  2. Update tests for indexing getters

    @j-devel
    j-devel committed Sep 25, 2019
    Configuration menu
    Copy the full SHA
    46dd0aa View commit details
    Browse the repository at this point in the history

  3. Fix typo

    @j-devel
    j-devel committed Sep 25, 2019
    Configuration menu
    Copy the full SHA
    487fc30 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2019

  1. Add comments describing what the code segment is doing

    @j-devel
    j-devel committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    624a14c View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2019

  1. Update indexing getter usage

    @j-devel
    j-devel committed Sep 30, 2019
    Configuration menu
    Copy the full SHA
    50fbb5c View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2019

  1. Revert "Add comments describing what the code segment is doing" 

    This reverts commit 624a14c.
    @j-devel
    j-devel committed Oct 2, 2019
    Configuration menu
    Copy the full SHA
    e04a697 View commit details
    Browse the repository at this point in the history

  2. Revert "Fix typo" 

    This reverts commit 487fc30.
    @j-devel
    j-devel committed Oct 2, 2019
    Configuration menu
    Copy the full SHA
    60d315c View commit details
    Browse the repository at this point in the history

  3. Revert "Wrap the return type of indexing getters as Option<T> if nece… 

    …ssary."

This reverts commit 547f3dd.
    @j-devel
    j-devel committed Oct 2, 2019
    Configuration menu
    Copy the full SHA
    57522cd View commit details
    Browse the repository at this point in the history

  4. Update the return signatures of WebIDL indexing getters

    @j-devel
    j-devel committed Oct 2, 2019
    Configuration menu
    Copy the full SHA
    53b0cd0 View commit details
    Browse the repository at this point in the history