Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local webdriver discovery via PATH #1794

Merged
merged 1 commit into from Sep 26, 2019

Conversation

j-devel
Copy link
Contributor

@j-devel j-devel commented Sep 26, 2019

Fixes the following bug (minor regression after eeebec0)

Describe the Bug

Local webdriver discovery via PATH is not working.

Steps to Reproduce

$ cd crates/web-sys
$ which geckodriver  # make sure geckodriver is installed and in PATH
/usr/local/bin/geckodriver
$ unset GECKODRIVER_REMOTE  # make sure not remotely using geckodriver via env vars
$ unset GECKODRIVER  # make sure not using geckodriver via env vars
$ cargo test --target wasm32-unknown-unknown --all-features

Expected Behavior

...
Running headless tests in Firefox on `http://127.0.0.1:55305/`
...
test result: ok. 56 passed; 0 failed; 0 ignored

Actual Behavior

/usr/local/bin/geckodriver is incorrectly resolved to "/user/local/bin":

...
error: failed to spawn "/usr/local/bin" binary
	caused by: Permission denied (os error 13)
error: test failed, to rerun pass '--test wasm'

@alexcrichton
Copy link
Contributor

Oops, thanks!

@alexcrichton alexcrichton merged commit 6b31777 into rustwasm:master Sep 26, 2019
@j-devel j-devel deleted the fix-local-testing branch September 28, 2019 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants