Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update webidl_ty field in multi-value transform #1839

Merged
merged 2 commits into from Oct 29, 2019

Conversation

alexcrichton
Copy link
Contributor

@alexcrichton alexcrichton commented Oct 29, 2019

When we're emitting a bindings section we need to be sure to update the
listed type of the binding in addition to the actual binding
expressions. This should help remove the stray return pointer being
listed there by accident!

When we're emitting a bindings section we need to be sure to update the
listed type of the binding in addition to the actual binding
expressions. This should help remove the stray return pointer being
listed there by accident!
@alexcrichton alexcrichton requested a review from fitzgen Oct 29, 2019
@alexcrichton alexcrichton merged commit 9b8711a into rustwasm:master Oct 29, 2019
20 checks passed
@alexcrichton alexcrichton deleted the remove-retptr branch Oct 29, 2019
Copy link
Member

@fitzgen fitzgen left a comment

Good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants