Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update `webidl_ty` field in multi-value transform #1839

Merged
merged 2 commits into from Oct 29, 2019

Conversation

@alexcrichton
Copy link
Collaborator

alexcrichton commented Oct 29, 2019

When we're emitting a bindings section we need to be sure to update the
listed type of the binding in addition to the actual binding
expressions. This should help remove the stray return pointer being
listed there by accident!

When we're emitting a bindings section we need to be sure to update the
listed type of the binding in addition to the actual binding
expressions. This should help remove the stray return pointer being
listed there by accident!
@alexcrichton alexcrichton requested a review from fitzgen Oct 29, 2019
@alexcrichton alexcrichton merged commit 9b8711a into rustwasm:master Oct 29, 2019
20 checks passed
20 checks passed
rustwasm.wasm-bindgen Build #20191029.2 succeeded
Details
rustwasm.wasm-bindgen (Build almost all examples) Build almost all examples succeeded
Details
rustwasm.wasm-bindgen (Build benchmarks) Build benchmarks succeeded
Details
rustwasm.wasm-bindgen (Build raytrace examples) Build raytrace examples succeeded
Details
rustwasm.wasm-bindgen (Deploy everything) Deploy everything succeeded
Details
rustwasm.wasm-bindgen (Dist Darwin binary) Dist Darwin binary succeeded
Details
rustwasm.wasm-bindgen (Dist Linux binary) Dist Linux binary succeeded
Details
rustwasm.wasm-bindgen (Dist Windows binary) Dist Windows binary succeeded
Details
rustwasm.wasm-bindgen (Doc - build the API documentation) Doc - build the API documentation succeeded
Details
rustwasm.wasm-bindgen (Doc - build the book) Doc - build the book succeeded
Details
rustwasm.wasm-bindgen (Run UI tests) Run UI tests succeeded
Details
rustwasm.wasm-bindgen (Run js-sys crate tests) Run js-sys crate tests succeeded
Details
rustwasm.wasm-bindgen (Run wasm-bindgen crate tests (Windows)) Run wasm-bindgen crate tests (Windows) succeeded
Details
rustwasm.wasm-bindgen (Run wasm-bindgen crate tests (nightly)) Run wasm-bindgen crate tests (nightly) succeeded
Details
rustwasm.wasm-bindgen (Run wasm-bindgen crate tests (unix)) Run wasm-bindgen crate tests (unix) succeeded
Details
rustwasm.wasm-bindgen (Run wasm-bindgen-cli crate tests) Run wasm-bindgen-cli crate tests succeeded
Details
rustwasm.wasm-bindgen (Run wasm-bindgen-wasm-interpreter tests) Run wasm-bindgen-wasm-interpreter tests succeeded
Details
rustwasm.wasm-bindgen (Run wasm-bindgen-webidl crate tests) Run wasm-bindgen-webidl crate tests succeeded
Details
rustwasm.wasm-bindgen (Run web-sys crate tests) Run web-sys crate tests succeeded
Details
rustwasm.wasm-bindgen (Test TypeScript output of wasm-bindgen) Test TypeScript output of wasm-bindgen succeeded
Details
@alexcrichton alexcrichton deleted the alexcrichton:remove-retptr branch Oct 29, 2019
Copy link
Member

fitzgen left a comment

Good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.