Add an unsafe method view_mut_raw #1850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lshlyapnikov
commented
Nov 4, 2019
lshlyapnikov
commented
Nov 4, 2019
|
Looking good! I'd be happy to merge when you're ready! |
lshlyapnikov
commented
Nov 6, 2019
| /// | ||
| /// Additionally the returned object can be safely mutated, | ||
| /// the changes are guranteed to be reflected in the input array. | ||
| pub unsafe fn view_mut_raw(ptr: *mut $ty, length: usize) -> $name { |
There was a problem hiding this comment.
@alexcrichton please doublecheck the rustdoc.
added 7 commits
November 5, 2019 23:29
it is cleaner, safer and better that way
|
Looks great to me, thanks! |
|
Thank you! |
josephlr
added a commit
to rust-random/getrandom
that referenced
this pull request
Oct 23, 2022
We can use [`Uint8Array::view_mut_raw`](https://rustwasm.github.io/wasm-bindgen/api/js_sys/struct.Uint8Array.html#method.view_mut_raw) which was [added](rustwasm/wasm-bindgen#1850) in version `0.2.54` of `wasm-bindgen`. This method was introduced to deal with uninitialized memory, see the Safety comment for more info. Signed-off-by: Joe Richey <joerichey@google.com>
josephlr
added a commit
to rust-random/getrandom
that referenced
this pull request
Oct 23, 2022
We can use [`Uint8Array::view_mut_raw`](https://rustwasm.github.io/wasm-bindgen/api/js_sys/struct.Uint8Array.html#method.view_mut_raw) which was [added](rustwasm/wasm-bindgen#1850) in version `0.2.54` of `wasm-bindgen`. This method was introduced to deal with uninitialized memory, see the Safety comment for more info. Signed-off-by: Joe Richey <joerichey@google.com>
josephlr
added a commit
to rust-random/getrandom
that referenced
this pull request
Oct 23, 2022
We can use [`Uint8Array::view_mut_raw`](https://rustwasm.github.io/wasm-bindgen/api/js_sys/struct.Uint8Array.html#method.view_mut_raw) which was [added](rustwasm/wasm-bindgen#1850) in version `0.2.54` of `wasm-bindgen`. This method was introduced to deal with uninitialized memory, see the Safety comment for more info. Signed-off-by: Joe Richey <joerichey@google.com>
josephlr
added a commit
to rust-random/getrandom
that referenced
this pull request
Oct 23, 2022
We can use [`Uint8Array::view_mut_raw`](https://rustwasm.github.io/wasm-bindgen/api/js_sys/struct.Uint8Array.html#method.view_mut_raw) which was [added](rustwasm/wasm-bindgen#1850) in version `0.2.54` of `wasm-bindgen`. This method was introduced to deal with uninitialized memory, see the Safety comment for more info. Signed-off-by: Joe Richey <joerichey@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1643
TODO:
Uint8Array::view_mut_rawtestInt16Array::view_mut_rawtestUint32Array::view_mut_rawtestFloat64Array::view_mut_rawtest